search for: test_unit_mathop

........... yes > ---------------------------------------------------------------------- - -- > > > [...] > > $ make check PASS: celt/tests/test_unit_types ./test-driver: line > 107: 10065 Illegal instruction "$@" > $log_file 2>&1 FAIL: > celt/tests/test_unit_mathops PASS: celt/tests/test_unit_entropy > PASS: celt/tests/test_unit_laplace PASS: celt/tests/test_unit_dft > PASS: celt/tests/test_unit_mdct PASS: celt/tests/test_unit_rotation > PASS: celt/tests/test_unit_cwrs32 PASS: tests/test_opus_api PASS: > tests/test_opus_decode PASS: tests/test_o...

Hi everyone, After much waiting, Opus 1.1.1 is finally here. The main changes are: - x86 SSE, SSE2 and SSE4.1 optimizations contributed by Cisco, - MIPS optimizations contributed by Imagination Technologies, - ARM Neon optimizations contributed by Linaro and ARM, - many architecture-independent optimizations, - memory footprint reductions, and - several minor bug fixes. The quality of the

--- celt/tests/test_unit_dft.c | 3 +-- celt/tests/test_unit_mathops.c | 3 +-- celt/tests/test_unit_mdct.c | 3 +-- celt/tests/test_unit_rotation.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/celt/tests/test_unit_dft.c b/celt/tests/test_unit_dft.c index bcee440..484dc57 100644 --- a/celt/tests/test_unit_dft.c +++ b/celt/tests/test_...

--- celt/tests/test_unit_dft.c | 3 +-- celt/tests/test_unit_mathops.c | 3 +-- celt/tests/test_unit_mdct.c | 3 +-- celt/tests/test_unit_rotation.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/celt/tests/test_unit_dft.c b/celt/tests/test_unit_dft.c index bcee440..484dc57 100644 --- a/celt/tests/test_unit_dft.c +++ b/celt/tests/test_...

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics. --- silk/fixed/main_FIX.h | 11 +++++++++++ silk/x86/x86_silk_map.c | 2 ++ 2 files changed, 13 insertions(+) diff --git a/silk/fixed/main_FIX.h b/silk/fixed/main_FIX.h index ffeb4f3..375b5eb 100644 --- a/silk/fixed/main_FIX.h +++ b/silk/fixed/main_FIX.h @@ -97,6 +97,17 @@ void

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics. --- silk/fixed/main_FIX.h | 11 +++++++++++ silk/x86/x86_silk_map.c | 2 ++ 2 files changed, 13 insertions(+) diff --git a/silk/fixed/main_FIX.h b/silk/fixed/main_FIX.h index ffeb4f3..375b5eb 100644 --- a/silk/fixed/main_FIX.h +++ b/silk/fixed/main_FIX.h @@ -97,6 +97,17 @@ void

...The actual encoder and decoder should work fine > since they are compiled without -msse except for the files that are > behind auto-detect. Good guess. I have tried this: 1. Compile everything as is. 2. "make check" -> Illegal Instruction. Good. 3. Delete file "celt/tests/test_unit_mathopsi.o". 4. Edit "Makefile" and delete all "-msse*" directives. 5. "make". It should rebuild file "celt/tests/test_unit_mathops". 6. Error: """ # make make all-recursive make[1]: Entering directory `/tmp/opus-1.1.1' make[2]: Entering di...

............... yes Extra programs: ................ yes ------------------------------------------------------------------------ [...] $ make check PASS: celt/tests/test_unit_types ./test-driver: line 107: 10065 Illegal instruction "$@" > $log_file 2>&1 FAIL: celt/tests/test_unit_mathops PASS: celt/tests/test_unit_entropy PASS: celt/tests/test_unit_laplace PASS: celt/tests/test_unit_dft PASS: celt/tests/test_unit_mdct PASS: celt/tests/test_unit_rotation PASS: celt/tests/test_unit_cwrs32 PASS: tests/test_opus_api PASS: tests/test_opus_decode PASS: tests/test_opus_decode PASS: tests...

...er should work fine since they are compiled without -msse >> except for the files that are behind auto-detect. > > Good guess. I have tried this: > > 1. Compile everything as is. 2. "make check" -> Illegal > Instruction. Good. 3. Delete file > "celt/tests/test_unit_mathopsi.o". 4. Edit "Makefile" and delete > all "-msse*" directives. 5. "make". It should rebuild file > "celt/tests/test_unit_mathops". 6. Error: > > """ # make make all-recursive make[1]: Entering directory > `/tmp/opus-1.1.1&...

...from RFCv3: - celt_neon_intr.c - removed warnings due to not having constant pointers - Put simpler loop to take care of corner cases. Unrolling using intrinsics was not really mapping well to what was done in celt_pitch_xcorr_arm.s - Makefile.am Removed explicit -O3 optimization - test_unit_mathops.c, test_unit_rotation.c followed recommendation to use #if #elif to guarantee that only one of "arm/arm_celt_map.c" or "x86/x86_celt_map.c" is included Viswanath Puttagunta (1): armv7: celt_pitch_xcorr: Introduce ARM neon intrinsics Makefile.am...

...e.am | 12 ++ celt/arm/arm_celt_map.c | 15 ++- celt/arm/celt_neon_intr.c | 256 +++++++++++++++++++++++++++++++++++++++ celt/arm/pitch_arm.h | 13 +- celt/cpu_support.h | 3 +- celt/pitch.h | 6 +- celt/tests/test_unit_mathops.c | 9 +- celt/tests/test_unit_rotation.c | 9 +- celt_sources.mk | 3 + configure.ac | 83 +++++++++++-- 10 files changed, 390 insertions(+), 19 deletions(-) create mode 100644 celt/arm/celt_neon_intr.c -- 1.7.9.5

....am | 11 ++ celt/arm/arm_celt_map.c | 15 ++- celt/arm/celt_neon_intr.c | 242 +++++++++++++++++++++++++++++++++++++++ celt/arm/pitch_arm.h | 13 ++- celt/cpu_support.h | 3 +- celt/pitch.h | 6 +- celt/tests/test_unit_mathops.c | 10 +- celt/tests/test_unit_rotation.c | 9 +- celt_sources.mk | 3 + configure.ac | 77 +++++++++++-- 10 files changed, 370 insertions(+), 19 deletions(-) create mode 100644 celt/arm/celt_neon_intr.c -- 1.7.9.5

...celt/arm/arm_celt_map.c | 4 +- celt/arm/celt_ne10_fft.c | 2 + celt/arm/celt_ne10_mdct.c | 3 ++ celt/arm/pitch_arm.h | 2 +- celt/dump_modes/Makefile | 2 +- celt/pitch.h | 5 +-- celt/tests/test_unit_dft.c | 3 +- celt/tests/test_unit_mathops.c | 7 ++-- celt/tests/test_unit_mdct.c | 4 +- celt/tests/test_unit_rotation.c | 5 ++- configure.ac | 93 +++++++++++++++++++---------------------- 12 files changed, 67 insertions(+), 67 deletions(-) diff --git a/Makefile.am b/Makefile.am index 3a75740..8bd7447 100644...

...+- celt/arm/arm_celt_map.c | 17 +++ celt/arm/celt_lpc_arm.h | 65 ++++++++ celt/arm/celt_lpc_neon_intr.c | 254 ++++++++++++++++++++++++++++++++ celt/celt_lpc.h | 5 + celt/tests/test_unit_dft.c | 1 + celt/tests/test_unit_mathops.c | 1 + celt/tests/test_unit_mdct.c | 1 + celt/tests/test_unit_optimization_lpc.c | 96 ++++++++++++ celt/tests/test_unit_rotation.c | 1 + celt_headers.mk | 1 + celt_sources.mk | 1 + tests/test_unit_optimi...

Opus 1.1.2. As experienced in previous release: """ ./test-driver: line 107: 25185 Illegal instruction "$@" > $log_file 2>&1 FAIL: celt/tests/test_unit_mathops """ -- Jes?s Cea Avi?n _/_/ _/_/_/ _/_/_/ jcea at jcea.es - http://www.jcea.es/ _/_/ _/_/ _/_/ _/_/ _/_/ Twitter: @jcea _/_/ _/_/ _/_/_/_/_/ jabber / xmpp:jcea at jabber.org _/_/ _/_/ _/_/...

...e.am | 12 ++ celt/arm/arm_celt_map.c | 15 ++- celt/arm/celt_neon_intr.c | 249 +++++++++++++++++++++++++++++++++++++++ celt/arm/pitch_arm.h | 13 +- celt/cpu_support.h | 3 +- celt/pitch.h | 6 +- celt/tests/test_unit_mathops.c | 6 +- celt/tests/test_unit_rotation.c | 6 +- celt_sources.mk | 3 + configure.ac | 83 +++++++++++-- 10 files changed, 377 insertions(+), 19 deletions(-) create mode 100644 celt/arm/celt_neon_intr.c diff --git a/Makefile.am b/Makefile.am index...

....am | 11 ++ celt/arm/arm_celt_map.c | 15 ++- celt/arm/celt_neon_intr.c | 242 +++++++++++++++++++++++++++++++++++++++ celt/arm/pitch_arm.h | 13 ++- celt/cpu_support.h | 3 +- celt/pitch.h | 6 +- celt/tests/test_unit_mathops.c | 10 +- celt/tests/test_unit_rotation.c | 9 +- celt_sources.mk | 3 + configure.ac | 77 +++++++++++-- 10 files changed, 370 insertions(+), 19 deletions(-) create mode 100644 celt/arm/celt_neon_intr.c diff --git a/Makefile.am b/Makefile.am index...

...e.am | 12 ++ celt/arm/arm_celt_map.c | 15 ++- celt/arm/celt_neon_intr.c | 256 +++++++++++++++++++++++++++++++++++++++ celt/arm/pitch_arm.h | 13 +- celt/cpu_support.h | 3 +- celt/pitch.h | 6 +- celt/tests/test_unit_mathops.c | 9 +- celt/tests/test_unit_rotation.c | 9 +- celt_sources.mk | 3 + configure.ac | 83 +++++++++++-- 10 files changed, 390 insertions(+), 19 deletions(-) create mode 100644 celt/arm/celt_neon_intr.c diff --git a/Makefile.am b/Makefile.am index...

...| 4 +- celt/arch.h | 4 +- celt/arm/arm_celt_map.c | 15 +++++++- celt/arm/celt_neon_intr.c | 81 +++++++++++++++++++++++++++++++++++++++ celt/arm/pitch_arm.h | 15 +++++++- celt/pitch.h | 17 ++++++-- celt/tests/test_unit_mathops.c | 2 +- celt/tests/test_unit_rotation.c | 2 +- celt_sources.mk | 3 ++ configure.ac | 56 ++++++++++++++++++++++----- silk/SigProc_FIX.h | 4 +- silk/macros.h | 4 +- 13 files changed, 205 insertions(+), 25 dele...

Hi all, This is Linfeng Zhang from Google. I'll work on ARM NEON optimization in the next few months. I'm submitting 2 patches in the following couple of emails, which have the new created celt_fir_neon(). I revised celt_fir_c() to not pass in argument "mem" in Patch 1. If there are concerns to this change, please let me know. Many thanks to your comments. Linfeng Zhang