search for: test_unit_dft

Signed-off-by: Viswanath Puttagunta <viswanath.puttagunta at linaro.org> --- celt/tests/test_unit_dft.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/celt/tests/test_unit_dft.c b/celt/tests/test_unit_dft.c index 5ea10fb..111c249 100644 --- a/celt/tests/test_unit_dft.c +++ b/celt/tests/test_unit_dft.c @@ -177,8 +177,14 @@ int main(int argc,char ** argv) test1d(36,1,arch);...

Signed-off-by: Viswanath Puttagunta <viswanath.puttagunta at linaro.org> --- celt/tests/test_unit_dft.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/celt/tests/test_unit_dft.c b/celt/tests/test_unit_dft.c index e17e26f..f08eb65 100644 --- a/celt/tests/test_unit_dft.c +++ b/celt/tests/test_unit_dft.c @@ -177,8 +177,14 @@ int main(int argc,char ** argv) test1d(36,1,arch);...

...ft mdct_forward/backward > etc) that are in my pipeline that depend on this patch series being > accepted. So, trying to make progress on this... On an armv7l board running Ubuntu, you've broken the build with just --enable-intrinsics (without the NE10 options): CC celt/tests/test_unit_dft.o In file included from ../celt/tests/test_unit_dft.c:47:0: ../celt/kiss_fft.c: In function 'opus_fft_free': ../celt/kiss_fft.c:507:51: warning: unused parameter 'arch' [-Wunused-parameter] void opus_fft_free(const kiss_fft_state *cfg, int arch)...

--- celt/tests/test_unit_dft.c | 3 +-- celt/tests/test_unit_mathops.c | 3 +-- celt/tests/test_unit_mdct.c | 3 +-- celt/tests/test_unit_rotation.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/celt/tests/test_unit_dft.c b/celt/tests/test_unit_dft.c index bcee440..484dc57 100644 --- a/celt/...

--- celt/tests/test_unit_dft.c | 3 +-- celt/tests/test_unit_mathops.c | 3 +-- celt/tests/test_unit_mdct.c | 3 +-- celt/tests/test_unit_rotation.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/celt/tests/test_unit_dft.c b/celt/tests/test_unit_dft.c index bcee440..484dc57 100644 --- a/celt/...

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics. --- silk/fixed/main_FIX.h | 11 +++++++++++ silk/x86/x86_silk_map.c | 2 ++ 2 files changed, 13 insertions(+) diff --git a/silk/fixed/main_FIX.h b/silk/fixed/main_FIX.h index ffeb4f3..375b5eb 100644 --- a/silk/fixed/main_FIX.h +++ b/silk/fixed/main_FIX.h @@ -97,6 +97,17 @@ void

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics. --- silk/fixed/main_FIX.h | 11 +++++++++++ silk/x86/x86_silk_map.c | 2 ++ 2 files changed, 13 insertions(+) diff --git a/silk/fixed/main_FIX.h b/silk/fixed/main_FIX.h index ffeb4f3..375b5eb 100644 --- a/silk/fixed/main_FIX.h +++ b/silk/fixed/main_FIX.h @@ -97,6 +97,17 @@ void

...> On an armv7l board running Ubuntu, you've broken the build with just > --enable-intrinsics (without the NE10 options): Yep, I should have checked with just this option to make sure I'm not causing regression. I will add to my test plan going forward. > > CC celt/tests/test_unit_dft.o > In file included from ../celt/tests/test_unit_dft.c:47:0: > ../celt/kiss_fft.c: In function 'opus_fft_free': > ../celt/kiss_fft.c:507:51: warning: unused parameter 'arch' > [-Wunused-parameter] > void opus_fft_free(const kiss_fft_state *cfg, int arch) >...

Hello Jean-Marc, Below are the results that show test_unit_dft passes, but test_unit_mdct fails (only for nfft=480, 960, 1920) Note: Tested on BeagleboneBlack(Cortex-A8) fixed point on branch [1] ./test_unit_dft nfft=32 inverse=0,snr = 88.394372 nfft=32 inverse=1,snr = 93.896470 nfft=128 inverse=0,snr = 89.185895 nfft=128 inverse=1,snr = 93.537021 nfft=256 in...

...Makefile.am | 4 +- celt/arm/arm_celt_map.c | 4 +- celt/arm/celt_ne10_fft.c | 2 + celt/arm/celt_ne10_mdct.c | 3 ++ celt/arm/pitch_arm.h | 2 +- celt/dump_modes/Makefile | 2 +- celt/pitch.h | 5 +-- celt/tests/test_unit_dft.c | 3 +- celt/tests/test_unit_mathops.c | 7 ++-- celt/tests/test_unit_mdct.c | 4 +- celt/tests/test_unit_rotation.c | 5 ++- configure.ac | 93 +++++++++++++++++++---------------------- 12 files changed, 67 insertions(+), 67 deletions(-) diff --git a/Makefile.am...

...ly this change to the MDCT test and run it again. See if more > (all) sizes pass. Given the results, I strongly suspect an overflow. > > Jean-Marc > > On 08/05/15 01:21 PM, Viswanath Puttagunta wrote: >> Hello Jean-Marc, >> >> Below are the results that show test_unit_dft passes, but >> test_unit_mdct fails (only for nfft=480, 960, 1920) >> Note: Tested on BeagleboneBlack(Cortex-A8) fixed point on branch [1] >> >> ./test_unit_dft >> nfft=32 inverse=0,snr = 88.394372 >> nfft=32 inverse=1,snr = 93.896470 >> nfft=128 inverse=0,...

...Makefile.am | 39 ++++- celt/arm/arm_celt_map.c | 17 +++ celt/arm/celt_lpc_arm.h | 65 ++++++++ celt/arm/celt_lpc_neon_intr.c | 254 ++++++++++++++++++++++++++++++++ celt/celt_lpc.h | 5 + celt/tests/test_unit_dft.c | 1 + celt/tests/test_unit_mathops.c | 1 + celt/tests/test_unit_mdct.c | 1 + celt/tests/test_unit_optimization_lpc.c | 96 ++++++++++++ celt/tests/test_unit_rotation.c | 1 + celt_headers.mk | 1 + celt_sources.mk...

Hello Jean-Marc, **Resending.. not sure why subject got removed earlier** Below are the results that show test_unit_dft passes, but test_unit_mdct fails (only for nfft=480, 960, 1920) Note: Tested on BeagleboneBlack(Cortex-A8) fixed point on branch [1] ./test_unit_dft nfft=32 inverse=0,snr = 88.394372 nfft=32 inverse=1,snr = 93.896470 nfft=128 inverse=0,snr = 89.185895 nfft=128 inverse=1,snr = 93.537021 nfft=256 in...

Hi, Can you apply this change to the MDCT test and run it again. See if more (all) sizes pass. Given the results, I strongly suspect an overflow. Jean-Marc On 08/05/15 01:21 PM, Viswanath Puttagunta wrote: > Hello Jean-Marc, > > Below are the results that show test_unit_dft passes, but > test_unit_mdct fails (only for nfft=480, 960, 1920) > Note: Tested on BeagleboneBlack(Cortex-A8) fixed point on branch [1] > > ./test_unit_dft > nfft=32 inverse=0,snr = 88.394372 > nfft=32 inverse=1,snr = 93.896470 > nfft=128 inverse=0,snr = 89.185895 > nfft=1...

...+ celt/arm/mdct_arm.h | 7 +++ celt/celt_decoder.c | 18 ++++---- celt/celt_encoder.c | 3 +- celt/kiss_fft.c | 4 +- celt/kiss_fft.h | 13 +++++- celt/mdct.c | 5 ++- celt/mdct.h | 22 ++++++++-- celt/tests/test_unit_dft.c | 2 +- celt/tests/test_unit_mdct.c | 2 +- 13 files changed, 214 insertions(+), 20 deletions(-) -- 1.9.1

Hi all, This is Linfeng Zhang from Google. I'll work on ARM NEON optimization in the next few months. I'm submitting 2 patches in the following couple of emails, which have the new created celt_fir_neon(). I revised celt_fir_c() to not pass in argument "mem" in Patch 1. If there are concerns to this change, please let me know. Many thanks to your comments. Linfeng Zhang

...ddition to what was posted on [1], this patch series mainly >> integrates Fixed point FFT implementations in NE10 library into opus. >> You can view my opus wip code at [2]. > > > Thanks, and I apologize for being slow here. > >> - This was surprising to me because test_unit_dft passes for all >> nfft including 60, 120, 240, 480. May be there are some data >> corner cases that need further investigation. > > > Yes, that seems concerning. I'd like to at least understand the cause of the failures. "Audio is clearly audible" is n...

...+ celt/arm/mdct_arm.h | 7 +++ celt/celt_decoder.c | 18 ++++---- celt/celt_encoder.c | 3 +- celt/kiss_fft.c | 4 +- celt/kiss_fft.h | 13 +++++- celt/mdct.c | 5 ++- celt/mdct.h | 22 ++++++++-- celt/tests/test_unit_dft.c | 2 +- celt/tests/test_unit_mdct.c | 2 +- 13 files changed, 214 insertions(+), 20 deletions(-) diff --git a/celt/arm/arm_celt_map.c b/celt/arm/arm_celt_map.c index 3b49f90..f132fe1 100644 --- a/celt/arm/arm_celt_map.c +++ b/celt/arm/arm_celt_map.c @@ -79,6 +79,15 @@ void (*const OPUS_FFT[...

...+ celt/arm/mdct_arm.h | 7 +++ celt/celt_decoder.c | 18 ++++---- celt/celt_encoder.c | 3 +- celt/kiss_fft.c | 4 +- celt/kiss_fft.h | 13 +++++- celt/mdct.c | 5 ++- celt/mdct.h | 22 ++++++++-- celt/tests/test_unit_dft.c | 2 +- celt/tests/test_unit_mdct.c | 2 +- 13 files changed, 214 insertions(+), 20 deletions(-) diff --git a/celt/arm/arm_celt_map.c b/celt/arm/arm_celt_map.c index 3b49f90..f132fe1 100644 --- a/celt/arm/arm_celt_map.c +++ b/celt/arm/arm_celt_map.c @@ -79,6 +79,15 @@ void (*const OPUS_FFT[...

...eport is that some source files in libopus are missing copyright headers. This breaks license check script that we use in chromium to validate licenses for third-party dependencies. Specifically the following files don't have copyright header: ./src/opus_compare.c ./src/mlp_data.c ./celt/tests/test_unit_dft.c ./celt/tests/test_unit_mathops.c ./celt/tests/test_unit_entropy.c ./celt/tests/test_unit_types.c ./celt/tests/test_unit_rotation.c ./celt/tests/test_unit_laplace.c ./celt/tests/test_unit_mdct.c ./celt/tests/test_unit_cwrs32.c ./autogen.sh ./win32/config.h ./tests/run_vectors.sh ./doc/build_draft....