search for: test_opus_projection

Displaying 7 results from an estimated 7 matches for "test_opus_projection".

2017 Jun 07
2
Initial implementation of ch.mapping 253/3
...tions/style/etc. > > > > Looking forward to your feedback, > > > > Cheers, > > Drew > > > Hi Drew, > > I ran into some issues with this new test. > > Building the test for floating point produces a clang compiler warning: > > CC tests/test_opus_projection.o > tests/test_opus_projection.c:137:9: warning: using floating point > absolute value function > 'fabs' when argument is of integer type [-Wabsolute-value] > if (ABS16(a[i] - b[i]) > tolerance) > ^ > ./celt/arch.h:194:26: note: expanded from macro ...
2017 May 30
2
Initial implementation of ch.mapping 253/3
Hello all, Attached is the initial proposed implementation for ch.mapping 253/3, based on the IETF proposal: https://tools.ietf.org/html/draft-ietf-codec-ambisonics-03 A brief overview of the patch, as it is slightly lengthy: After discussion with Jean-Marc, we determined that ch.253/3 will need the demixing matrix as part of the encoder/decoder struct stack and thus will require a new
2017 Jun 12
1
Initial implementation of ch.mapping 253/3
...;> > Cheers, >>> > Drew >>> >>> >>> Hi Drew, >>> >>> I ran into some issues with this new test. >>> >>> Building the test for floating point produces a clang compiler warning: >>> >>> CC tests/test_opus_projection.o >>> tests/test_opus_projection.c:137:9: warning: using floating point >>> absolute value function >>> 'fabs' when argument is of integer type [-Wabsolute-value] >>> if (ABS16(a[i] - b[i]) > tolerance) >>> ^ >>> ./c...
2017 Jun 07
0
Initial implementation of ch.mapping 253/3
...recommendations regarding the patch, > including naming conventions/style/etc. > > Looking forward to your feedback, > > Cheers, > Drew Hi Drew, I ran into some issues with this new test. Building the test for floating point produces a clang compiler warning: CC tests/test_opus_projection.o tests/test_opus_projection.c:137:9: warning: using floating point absolute value function 'fabs' when argument is of integer type [-Wabsolute-value] if (ABS16(a[i] - b[i]) > tolerance) ^ ./celt/arch.h:194:26: note: expanded from macro 'ABS16' #define ABS16(x)...
2017 Jun 12
0
Initial implementation of ch.mapping 253/3
...ward to your feedback, >> > >> > Cheers, >> > Drew >> >> >> Hi Drew, >> >> I ran into some issues with this new test. >> >> Building the test for floating point produces a clang compiler warning: >> >> CC tests/test_opus_projection.o >> tests/test_opus_projection.c:137:9: warning: using floating point >> absolute value function >> 'fabs' when argument is of integer type [-Wabsolute-value] >> if (ABS16(a[i] - b[i]) > tolerance) >> ^ >> ./celt/arch.h:194:26: note:...
2017 Nov 21
0
[PATCH] Support for Channel Mapping 253.
...ction_encoder.c line 65 checks for "order_plus_one < 1 || order_plus_one > 15". I don't see a more restrictive check, and if there is one somewhere it doesn't prevent opus_projection_ambisonics_encoder_init() from accessing uninitialized memory. This can be seen by running test_opus_projection under valgrind: ==22926== Use of uninitialised value of size 8 ==22926== at 0x1000E61D0: opus_projection_ambisonics_encoder_init (opus_projection_encoder.c:197) ==22926== by 0x1000E642C: opus_projection_ambisonics_encoder_create (opus_projection_encoder.c:247) ==22926== by 0x1000014C1: te...
2017 Nov 21
4
[PATCH] Support for Channel Mapping 253.
Hi Mark, Attached are corrections based on your comments. I will extend these to the patch I recently submitted to fix memory issues once that is resolved as well. Cheers, Drew On Sat, Nov 18, 2017 at 5:48 PM Mark Harris <mark.hsj at gmail.com> wrote: > Hi Drew, > > Some additional comments on your mapping family 253 changes: > > 1) mapping_matrix_get_data: The computed