search for: test_layers_plugin_zero

...int32_t, uint64_t, int)’ {aka ‘int (*)(void *, unsigned int, long unsigned int, int)’} from incompatible pointer type ‘int (*)(void *, uint32_t, uint64_t, uint32_t)’ {aka ‘int (*)(void *, unsigned int, long unsigned int, unsigned int)’} [-Wincompatible-pointer-types] .zero = test_layers_plugin_zero, ^~~~~~~~~~~~~~~~~~~~~~~ test-layers-plugin.c:203:24: note: (near initialization for ‘plugin.zero’) make[2]: *** [Makefile:1847: test_layers_plugin_la-test-layers-plugin.lo] Error 1 Nir

I'm still working my way through the filters before this series will be complete, but this is enough of a start to at least get some feedback on the idea of implementing another NBD protocol extension. Eric Blake (9): server: Internal hooks for implementing NBD_CMD_CACHE plugins: Add .cache callback file, split: Implement .cache with posix_fadvise nbd: Implement NBD_CMD_CACHE

This has already been pushed upstream. I am simply posting these here so we have a reference in the mailing list in case we find bugs later (as I'm sure we will - it's a complex patch series). Great thanks to Eric Blake for tireless review on this one. It also seems to have identified a few minor bugs in qemu along the way. Rich.

Since v1: - rework .can_cache to be tri-state, with default of no advertisement (ripple effect through other patches) - add a lot more patches in order to round out filter support And in the meantime, Rich pushed NBD_CMD_CACHE support into libnbd, so in theory we now have a way to test cache commands through the entire stack. Eric Blake (24): server: Internal hooks for implementing

It's easy to use the sh script to demonstrate that nbdkit is inefficiently calling into .get_size, .can_fua, and friends more than necessary. We've also commented on the list in the past that it would be nice to ensure that when filters call into next_ops, they are not violating constraints (as we've have to fix several bugs in the past where we did not have such checking to protect