search for: test_connection_ok

...ig.h> > > +#include <sys/stat.h> > #include <stdio.h> > #include <stdlib.h> > #include <stdarg.h> There's an informal ordering for header files, and putting <sys/stat.h> at the very top isn't in that tradition! > @@ -654,7 +655,11 @@ test_connection_ok (gpointer user_data) > static void > configure_network_button_clicked (GtkWidget *w, gpointer data) > { > - ignore_value (system ("nm-connection-editor &")); > + struct stat statbuf; > + if (stat ("/sbin/yast2", &statbuf) >= 0) > + ignore...

...ions(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index e720002..b50cadf 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -51,6 +51,7 @@ #include <config.h> +#include <sys/stat.h> #include <stdio.h> #include <stdlib.h> #include <stdarg.h> @@ -654,7 +655,11 @@ test_connection_ok (gpointer user_data) static void configure_network_button_clicked (GtkWidget *w, gpointer data) { - ignore_value (system ("nm-connection-editor &")); + struct stat statbuf; + if (stat ("/sbin/yast2", &statbuf) >= 0) + ignore_value (system ("yast2 lan &am...

...Manager isn't provided on SLES. As yast2 lan is available on all openSUSE / SLE distro, use it instead. --- p2v/gui.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index e720002..f8605a3 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -654,7 +654,10 @@ test_connection_ok (gpointer user_data) static void configure_network_button_clicked (GtkWidget *w, gpointer data) { - ignore_value (system ("nm-connection-editor &")); + if (access ("/sbin/yast2", X_OK) >= 0) + ignore_value (system ("yast2 lan &")); + else + ignor...

... and a small initial patch which makes it easier to test virt-p2v without having to start up a virtual machine. There is still a bug in Gtk 3 where the GtkTextView on the final (running) dialog ignores gtk_widget_set_size_request and so the window appears just a single pixel high. Rich.

This is basically the same as what I posted earlier today. The main difference is I split out the GDK thread sychronization (removal of) changes from the other Gtk 2/3 changes, which should make it a bit easier to review. Gtk 3 is still not quite perfect. Apart from the problem with the GtkTextView noted before, there are also vertical alignment and padding problems with labels in GtkGrid

Diff to v2: * remove leftover variable declaration in gui.c Cédric Bosdonnat (4): p2v: use yast2 lan on SUSE distros rather than NM p2v: fix dependencies for SLES / openSUSE p2v: add virt-p2v-make-kiwi to generate kiwi config p2v: add -x option to nm-online .gitignore | 3 + configure.ac | 2 + p2v/Makefile.am | 31 +++++-

Hi there, Here are a few patches to get virt-p2v working on openSUSE and SLES. Note that I intentionnaly use icewm and yast2 lan for SLES and openSUSE since SLES doesn't ship metacity and all of NetworkManager pieces. Cédric Bosdonnat (4): p2v: use yast2 lan on SUSE distros rather than NM p2v: fix dependencies for SLES / openSUSE p2v: add virt-p2v-make-kiwi to generate kiwi config

Diff to v1: * Use access rather than stat in gui.c * Remove now uneeded and missplaced include for stat.h Cédric Bosdonnat (4): p2v: use yast2 lan on SUSE distros rather than NM p2v: fix dependencies for SLES / openSUSE p2v: add virt-p2v-make-kiwi to generate kiwi config p2v: add -x option to nm-online .gitignore | 3 + configure.ac | 2 +

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am