search for: temp_dir_name

...index 2e64862..353b04b 100644 --- a/mllib/mkdtemp.ml +++ b/mllib/mkdtemp.ml @@ -16,4 +16,9 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. *) +open Common_utils + external mkdtemp : string -> string = "virt_builder_mkdtemp" + +let temp_dir ?(base_dir = Filename.temp_dir_name) prefix suffix = + mkdtemp (base_dir // (prefix ^ "XXXXXX" ^ suffix)) diff --git a/mllib/mkdtemp.mli b/mllib/mkdtemp.mli index 674e6f2..9abb10c 100644 --- a/mllib/mkdtemp.mli +++ b/mllib/mkdtemp.mli @@ -18,3 +18,10 @@ val mkdtemp : string -> string (** [mkdtemp pattern] Tiny wrapp...

...builder/sigchecker.ml > +++ b/builder/sigchecker.ml > @@ -54,7 +54,7 @@ let import_keyfile ~gpg ~gpghome ~verbose keyfile = > > let rec create ~verbose ~gpg ~gpgkey ~check_signature = > (* Create a temporary directory for gnupg. *) > - let tmpdir = Mkdtemp.mkdtemp (Filename.temp_dir_name // "vb.gpghome.XXXXXX") in > + let tmpdir = Mkdtemp.temp_dir "vb.gpghome." "" in > rmdir_on_exit tmpdir; > (* Make sure we have no check_signature=true with no actual key. *) > let check_signature, gpgkey = > diff --git a/sysprep/sysprep_operat...

Hi, is there any guide for CPU microcode updates on CentOS6, Xen 4.10, kernel 4.9 ? Thanks Karel

...top of my head. > > You can add ucode=scan to the xen command line, add a file /path/to/microcode_file as the last item in your boot list, and generate that microcode > file using something like: > > iucode_tool --write-earlyfw "${OUT_BLOB_FILE}" \ > "${TEMP_DIR_NAME}/intel-ucode" \ > "${TEMP_DIR_NAME}/intel-ucode-with-caveats" > > Where the last two items have been extracted from the intel microcode tarball. > > --Sarah > _______________________________________________ > CentOS-virt mailing list > CentOS-virt...

...? I'm not sure off the top of my head. You can add ucode=scan to the xen command line, add a file /path/to/microcode_file as the last item in your boot list, and generate that microcode file using something like: iucode_tool --write-earlyfw "${OUT_BLOB_FILE}" \ "${TEMP_DIR_NAME}/intel-ucode" \ "${TEMP_DIR_NAME}/intel-ucode-with-caveats" Where the last two items have been extracted from the intel microcode tarball. --Sarah

...t external free_space : string -> int64 = "guestfs_int_mllib_statvfs_free_space" diff --git a/mllib/unix_utils.mli b/mllib/unix_utils.mli index 0a4c1b3..4795cb3 100644 --- a/mllib/unix_utils.mli +++ b/mllib/unix_utils.mli @@ -88,6 +88,11 @@ module Mkdtemp : sig [Filename.temp_dir_name] is used. *) end +module Realpath : sig + val realpath : string -> string + (** [realpath(3)] returns the canonicalized absolute pathname. *) +end + module StatVFS : sig val free_space : string -> int64 (** [free_space path] returns the free space available on the -- 2.9.3

I was planning to use this function to harden the code in v2v/input_ova.ml against malicious OVA files. However I didn't complete that work. Hate to see a good commit go to waste ... Rich.

The first patch is just some simple refactoring. See the second patch for a description of the new virt-sparsify --tmp option. I tested this using a loopback device as my temporary block device, and it seems to work fine for me. Federico .. this needs a BZ :-) Rich.

Much similar to unlink_on_exit, but recursively cleaning directories. --- mllib/common_utils.ml | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml index 3943417..f49ede6 100644 --- a/mllib/common_utils.ml +++ b/mllib/common_utils.ml @@ -386,6 +386,35 @@ let unlink_on_exit = registered_handlers := true )

Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1354507 Main explanation is in patch #3. Rich.

...t; fingerprint : string; > check_signature : bool; > + gpghome : string; > + mutable key_imported : bool; > } > > let create ~debug ~gpg ~fingerprint ~check_signature = > + (* Create a temporary directory for gnupg. *) > + let tmpdir = Mkdtemp.mkdtemp (Filename.temp_dir_name // "vb.gpghome.XXXXXX") in > + rmdir_on_exit tmpdir; > + (* Run gpg once, so it can setup its own home directory, failing > + * if it cannot. > + *) > + let cmd = sprintf "%s --homedir %s --list-keys%s" > + gpg tmpdir (if debug then "" else...

...e check should rather be: | RHEL (ver, _) when ver >= 6 -> (Same note above.) > +and copy_preseed_to_temporary source = > + (* d-i only works if the file is literally called "/preseed.cfg" *) > + let d = "/tmp" // random8 () ^ ".tmp" in Filename.temp_dir_name instead of /tmp here. > +and make_location os arch = > + match os, arch with > + | CentOS (major, _), Aarch64 -> > + (* XXX This always points to the latest CentOS, so > + * effectively the minor number is always ignored. > + *) > + sprintf "http://...

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.

...mmon/mlutils/unix_utils.ml index 8ac36836c..b135bcaee 100644 --- a/common/mlutils/unix_utils.ml +++ b/common/mlutils/unix_utils.ml @@ -52,8 +52,8 @@ end module Mkdtemp = struct external mkdtemp : string -> string = "guestfs_int_mllib_mkdtemp" - let temp_dir ?(base_dir = Filename.temp_dir_name) prefix suffix = - mkdtemp (Filename.concat base_dir (prefix ^ "XXXXXX" ^ suffix)) + let temp_dir ?(base_dir = Filename.temp_dir_name) prefix = + mkdtemp (Filename.concat base_dir (prefix ^ "XXXXXX")) end module Realpath = struct diff --git a/common/mlutils/unix_utils...

Hi, attached there is a serie of patches that completes the work on making virt-builder use .conf files, shipped in XDG directories, to configure all the available sources of indexes used. This also removes the hardcoded default location, replaced now with a configuration file (which may be not used at all). Thanks, Pino Toscano (8): builder: allow "no key" as key in Sigchecker

...nes_split" >:: test_string_lines_split; ] diff --git a/sparsify/copying.ml b/sparsify/copying.ml index 80d7c9d..ef196f6 100644 --- a/sparsify/copying.ml +++ b/sparsify/copying.ml @@ -75,7 +75,7 @@ let run indisk outdisk check_tmpdir compress convert | None -> Directory Filename.temp_dir_name (* $TMPDIR or /tmp *) | Some dir when is_directory dir -> Directory dir | Some dev when is_block_device dev -> Block_device dev - | Some file when string_prefix file "prebuilt:" -> + | Some file when String.is_prefix file "prebuilt:" -> let fil...

Hide/prevent the use of bad string functions like String.lowercase. These are replaced by safe functions that won't break UTF-8 strings. Other miscellaneous refactoring. Rich.

Create a new directory (builder/template). Integrate all of the scripts into a single program, so that templates are generated more consistently. This also changes how the index file is generated. The script now generates the index file fragment and saves it under version control, and then generates the final index file by concatenating these. (Previously the index was written by hand which was

See this bug for background information: https://bugzilla.redhat.com/show_bug.cgi?id=1350465 Thanks: Tomáš Golembiovský --- v2v/virt-v2v.pod | 38 ++++++++++++++++++++++++++------------ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e68d75cf8..0943bf305 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -1909,18 +1909,32 @@ that