search for: tejun

On Thu, Nov 20, 2014 at 06:26:24PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 20, 2014 at 06:25:43PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > > > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > > > ... > > > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > > { > > > > struct virtio_balloon *vb = vdev->priv; > &...

On Thu, Nov 20, 2014 at 06:26:24PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 20, 2014 at 06:25:43PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > > > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > > > ... > > > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > > { > > > > struct virtio_balloon *vb = vdev->priv; > &...

...{ int mirror; ... mirror = (int)(unsigned long)bio->bi_bdev; ... } Ewweeeeeeeeeeeeeeeeeehh........ No wonder this thing crashes. Chris, can''t the original bio carry bbio in bi_private and let end_bio_extent_readpage() free the bbio instead of abusing bi_bdev like this? -- tejun

On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > ... > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > { > > struct virtio_balloon *vb = vdev->priv; > > > > - kthread_stop(vb->thread); &gt...

On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > ... > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > { > > struct virtio_balloon *vb = vdev->priv; > > > > - kthread_stop(vb->thread); &gt...

Hello, On Mon, Apr 13, 2020 at 04:18:57PM -0400, Lyude Paul wrote: > Hi Tejun! Sorry to bother you, but have you had a chance to look at any of > this yet? Would like to continue moving this forward Sorry, wasn't following this thread. Have you looked at kthread_worker? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/kthread.h#...

FYI, it is likely that ocfs2 will not work on 3.7-rcN until the following one-line patch is merged, as the code in ramster that provoked it is directly leveraged from ocfs2 o2net. > From: Tejun Heo [mailto:tj at kernel.org] > Sent: Thursday, October 18, 2012 5:39 PM > To: Dan Magenheimer > Cc: linux-kernel at vger.kernel.org; Konrad Wilk > Subject: [PATCH] workqueue: cancel_delayed_work() should return %NULL if work item is idle > > From e65120fcfc1cb9697655d29ecd798245...

...ish in certain > > number of iterations and just keep trying indefinitely. > > > > Thanks. > > Right, so eventually we'll stop requeueuing and it will succeed? Yeah, sure, it's a silly reason to use a separate workqueue tho. Don't do it that way. Thanks. -- tejun

...ish in certain > > number of iterations and just keep trying indefinitely. > > > > Thanks. > > Right, so eventually we'll stop requeueuing and it will succeed? Yeah, sure, it's a silly reason to use a separate workqueue tho. Don't do it that way. Thanks. -- tejun

On Thu, Nov 20, 2014 at 05:55:58PM +0100, Petr Mladek wrote: > On Thu 2014-11-20 11:29:35, Tejun Heo wrote: > > On Thu, Nov 20, 2014 at 06:26:24PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 20, 2014 at 06:25:43PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > > > > > On Thu, Nov 20, 2014 at...

On Thu, Nov 20, 2014 at 05:55:58PM +0100, Petr Mladek wrote: > On Thu 2014-11-20 11:29:35, Tejun Heo wrote: > > On Thu, Nov 20, 2014 at 06:26:24PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 20, 2014 at 06:25:43PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > > > > > On Thu, Nov 20, 2014 at...

On Sat, Jan 02, 2016 at 06:43:16AM -0500, Tejun Heo wrote: > Hello, > > On Fri, Jan 01, 2016 at 12:18:17PM +0200, Michael S. Tsirkin wrote: > > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin > > > suggested using a system one. Tejun Heo confirmed that the system > > > workqueue has a p...

On Sat, Jan 02, 2016 at 06:43:16AM -0500, Tejun Heo wrote: > Hello, > > On Fri, Jan 01, 2016 at 12:18:17PM +0200, Michael S. Tsirkin wrote: > > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin > > > suggested using a system one. Tejun Heo confirmed that the system > > > workqueue has a p...

...that area. > > My understanding is this: > > bitmap_endwrite -> calls sysfs_notify_dirent_safe under spinlock > -> calls kernfs_notify which takes a mutex. > > So I am guessing it is this commit: > > commit d911d98748018f7c8facc035ba39c30f5cce6f9c > Author: Tejun Heo <tj at kernel.org> > Date: Wed Apr 9 11:07:31 2014 -0400 > > kernfs: make kernfs_notify() trigger inotify events too > > Tejun, what do you think? > > Josh, Brian, could you try reverting that commit to see if it helps? That definitely be a bug. If you need...

...that area. > > My understanding is this: > > bitmap_endwrite -> calls sysfs_notify_dirent_safe under spinlock > -> calls kernfs_notify which takes a mutex. > > So I am guessing it is this commit: > > commit d911d98748018f7c8facc035ba39c30f5cce6f9c > Author: Tejun Heo <tj at kernel.org> > Date: Wed Apr 9 11:07:31 2014 -0400 > > kernfs: make kernfs_notify() trigger inotify events too > > Tejun, what do you think? > > Josh, Brian, could you try reverting that commit to see if it helps? That definitely be a bug. If you need...

...work is queued instead of waking the kthread. > > fill_balloon() and leak_balloon() have a limit for the amount of modified > pages. The work re-queues itself when necessary. > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin > suggested using a system one. Tejun Heo confirmed that the system > workqueue has a pretty high concurrency level (256) by default. > Therefore we need not be afraid of too long blocking. Right but fill has a 1/5 second sleep on failure - *that* is problematic for a system queue. There's also a race introduced on remove,...

...work is queued instead of waking the kthread. > > fill_balloon() and leak_balloon() have a limit for the amount of modified > pages. The work re-queues itself when necessary. > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin > suggested using a system one. Tejun Heo confirmed that the system > workqueue has a pretty high concurrency level (256) by default. > Therefore we need not be afraid of too long blocking. Right but fill has a 1/5 second sleep on failure - *that* is problematic for a system queue. There's also a race introduced on remove,...

On Sun, Jun 29, 2014 at 11:26:37AM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 27, 2014 at 07:57:38AM -0400, Josh Boyer wrote: > > Hi All, > > > > We've had a report[1] of the virt_blk driver causing a lot of spew > > because it's calling a sleeping function from an invalid context. The > > backtrace is below. This is with kernel

On Sun, Jun 29, 2014 at 11:26:37AM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 27, 2014 at 07:57:38AM -0400, Josh Boyer wrote: > > Hi All, > > > > We've had a report[1] of the virt_blk driver causing a lot of spew > > because it's calling a sleeping function from an invalid context. The > > backtrace is below. This is with kernel

On Sun, Jun 29, 2014 at 02:55:36PM -0600, Jens Axboe wrote: > > commit d911d98748018f7c8facc035ba39c30f5cce6f9c > > Author: Tejun Heo <tj at kernel.org> > > Date: Wed Apr 9 11:07:31 2014 -0400 > > > > kernfs: make kernfs_notify() trigger inotify events too > > > > Tejun, what do you think? > > > > Josh, Brian, could you try reverting that commit to see if it helps? >...