Displaying 2 results from an estimated 2 matches for "tcl_findexecut".
2018 Jul 01
2
[PATCH nbdkit] Add Tcl plugin, for writing plugins in Tcl.
...h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+#include <errno.h>
+#include <assert.h>
+
+#include <tcl.h>
+
+#include <nbdkit-plugin.h>
+
+static Tcl_Interp *interp;
+static const char *script;
+
+static void
+tcl_load (void)
+{
+ //Tcl_FindExecutable ("nbdkit");
+ interp = Tcl_CreateInterp ();
+ if (Tcl_Init (interp) != TCL_OK) {
+ nbdkit_error ("cannot initialize Tcl interpreter: %s",
+ Tcl_GetStringResult (interp));
+ exit (EXIT_FAILURE);
+ }
+}
+
+static void
+tcl_unload (void)
+{
+ if (inte...
2018 Jul 06
0
Re: [PATCH nbdkit] Add Tcl plugin, for writing plugins in Tcl.
...elp>
> +
> +These are not yet supported.
If you don't want to support can_zero/can_fua yet, should you document
them here?
> +++ b/plugins/tcl/tcl.c
> +static Tcl_Interp *interp;
> +static const char *script;
> +
> +static void
> +tcl_load (void)
> +{
> + //Tcl_FindExecutable ("nbdkit");
Is this comment intentional?
Otherwise LGTM
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org