search for: tatulea

On 2023-05-04 a.m.9:50, Dragos Tatulea wrote: > External email: Use caution opening links or attachments > > > The referenced patch calls set_vq_affinity without checking if the op is > valid. This patch adds the check. > > Fixes: 3dad56823b53 ("virtio-vdpa: Support interrupt affinity spreading mechanism&quo...

On Thu, 2023-05-04 at 13:08 -0400, Feng Liu wrote: > > > On 2023-05-04 a.m.9:50, Dragos Tatulea wrote: > > External email: Use caution opening links or attachments > > > > > > The referenced patch calls set_vq_affinity without checking if the op is > > valid. This patch adds the check. > > > > Fixes: 3dad56823b53 ("virtio-vdpa: Support interru...

On Tue, 2023-08-01 at 11:59 +0800, Jason Wang wrote: > On Mon, Jul 31, 2023 at 5:08?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Mon, Jul 31, 2023 at 07:15:31AM +0000, Dragos Tatulea wrote: > > > On Thu, 2023-07-27 at 12:28 -0400, Michael S. Tsirkin wrote: > > > > On Thu, Jul 27, 2023 at 04:02:16PM +0000, Dragos Tatulea wrote: > > > > > On Wed, 2023-07-26 at 15:26 -0400, Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 26,...

The referenced patch calls set_vq_affinity without checking if the op is valid. This patch adds the check. Fixes: 3dad56823b53 ("virtio-vdpa: Support interrupt affinity spreading mechanism") Reviewed-by: Gal Pressman <gal at nvidia.com> Signed-off-by: Dragos Tatulea <dtatulea at nvidia.com> --- drivers/virtio/virtio_vdpa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index eb6aee8c06b2..989e2d7184ce 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virtio_...

On Mon, Jul 31, 2023 at 07:15:31AM +0000, Dragos Tatulea wrote: > On Thu, 2023-07-27 at 12:28 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 27, 2023 at 04:02:16PM +0000, Dragos Tatulea wrote: > > > On Wed, 2023-07-26 at 15:26 -0400, Michael S. Tsirkin wrote: > > > > On Wed, Jul 26, 2023 at 10:07:38PM +0300, Dragos Tatulea...

On Mon, Jul 31, 2023 at 5:08?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Jul 31, 2023 at 07:15:31AM +0000, Dragos Tatulea wrote: > > On Thu, 2023-07-27 at 12:28 -0400, Michael S. Tsirkin wrote: > > > On Thu, Jul 27, 2023 at 04:02:16PM +0000, Dragos Tatulea wrote: > > > > On Wed, 2023-07-26 at 15:26 -0400, Michael S. Tsirkin wrote: > > > > > On Wed, Jul 26, 2023 at 10:07:38PM +...

On Thu, 2023-07-27 at 12:28 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 27, 2023 at 04:02:16PM +0000, Dragos Tatulea wrote: > > On Wed, 2023-07-26 at 15:26 -0400, Michael S. Tsirkin wrote: > > > On Wed, Jul 26, 2023 at 10:07:38PM +0300, Dragos Tatulea wrote: > > > > The ndev was accessed on shutdown without a check if it actually exists. > > > > This triggered the crash past...

On Thu, Jul 27, 2023 at 04:02:16PM +0000, Dragos Tatulea wrote: > On Wed, 2023-07-26 at 15:26 -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 26, 2023 at 10:07:38PM +0300, Dragos Tatulea wrote: > > > The ndev was accessed on shutdown without a check if it actually exists. > > > This triggered the crash pasted below. This patch...

On Thu, May 04, 2023 at 01:08:54PM -0400, Feng Liu wrote: > > > On 2023-05-04 a.m.9:50, Dragos Tatulea wrote: > > External email: Use caution opening links or attachments > > > > > > The referenced patch calls set_vq_affinity without checking if the op is > > valid. This patch adds the check. > > > > Fixes: 3dad56823b53 ("virtio-vdpa: Support interru...

On Tue, 2023-05-23 at 04:18 -0400, Michael S. Tsirkin wrote: > On Tue, May 23, 2023 at 07:16:58AM +0000, Dragos Tatulea wrote: > > Hi, > > > > I am looking for the stable branch for vdpa fixes in the vhost tree [1]. > > There > > are 3 branches that seem identical: linux-next, test and vhost. linux-next > > seems > > to be -next branch. Which one would be the stable branch?...

...andling CVQs in a different ASID [0]. The first patch is the actual fix. The next 2 patches are fixing a possible issue that I found while implementing patch 1. The patches are ordered like this for clarity. [0] https://lore.kernel.org/lkml/20230112142218.725622-1-eperezma at redhat.com/ Dragos Tatulea (1): vdpa/mlx5: Fix mr->initialized semantics Eugenio P?rez (1): vdpa/mlx5: Delete control vq iotlb in destroy_mr only when necessary drivers/vdpa/mlx5/core/mlx5_vdpa.h | 2 + drivers/vdpa/mlx5/core/mr.c | 97 +++++++++++++++++++++--------- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4...

...andling CVQs in a different ASID [0]. The first patch is the actual fix. The next 2 patches are fixing a possible issue that I found while implementing patch 1. The patches are ordered like this for clarity. [0] https://lore.kernel.org/lkml/20230112142218.725622-1-eperezma at redhat.com/ Dragos Tatulea (1): vdpa/mlx5: Fix mr->initialized semantics Eugenio P?rez (1): vdpa/mlx5: Delete control vq iotlb in destroy_mr only when necessary drivers/vdpa/mlx5/core/mlx5_vdpa.h | 2 + drivers/vdpa/mlx5/core/mr.c | 97 +++++++++++++++++++++--------- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4...

...000000000000000 R11: 0000000000000206 R12: 0000000000000000 R13: 00007fffc7bddf10 R14: 0000000000000000 R15: 00007fffc7bde2b8 </TASK> CR2: 0000000000000300 ---[ end trace 0000000000000000 ]--- Fixes: bc9a2b3e686e ("vdpa/mlx5: Support interrupt bypassing") Signed-off-by: Dragos Tatulea <dtatulea at nvidia.com> --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 9138ef2fb2c8..e2e7ebd71798 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/dri...

...pu utilization of > guest VM. > > Additionally, address all the VQs when updating the global configuration, > as now the individual VQs configuration can diverge from the global > configuration. > > Signed-off-by: Gavin Li <gavinl at nvidia.com> > Reviewed-by: Dragos Tatulea <dtatulea at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > Acked-by: Michael S. Tsirkin <mst at redhat.com> FTR, this patch is significantly different from the version previously acked/reviewed, I'm unsure if all the reviewers are ok with the new one. [....

Hi, I am looking for the stable branch for vdpa fixes in the vhost tree [1]. There are 3 branches that seem identical: linux-next, test and vhost. linux-next seems to be -next branch. Which one would be the stable branch? [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git Thanks, Dragos

On Tue, May 23, 2023 at 07:16:58AM +0000, Dragos Tatulea wrote: > Hi, > > I am looking for the stable branch for vdpa fixes in the vhost tree [1]. There > are 3 branches that seem identical: linux-next, test and vhost. linux-next seems > to be -next branch. Which one would be the stable branch? > > [1] https://git.kernel.org/pub/sc...

...t; > > > Additionally, address all the VQs when updating the global configuration, > > as now the individual VQs configuration can diverge from the global > > configuration. > > > > Signed-off-by: Gavin Li <gavinl at nvidia.com> > > Reviewed-by: Dragos Tatulea <dtatulea at nvidia.com> > > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > > Acked-by: Michael S. Tsirkin <mst at redhat.com> > > FTR, this patch is significantly different from the version previously > acked/reviewed, I'm unsure if all the reviewers are...

...cpu utilization of > guest VM. > > Additionally, address all the VQs when updating the global configuration, > as now the individual VQs configuration can diverge from the global > configuration. > > Signed-off-by: Gavin Li <gavinl at nvidia.com> > Reviewed-by: Dragos Tatulea <dtatulea at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > Acked-by: Michael S. Tsirkin <mst at redhat.com> > Reviewed-by: Heng Qi <hengqi at linux.alibaba.com> Acked-by: Jason Wang <jasowang at redhat.com> Thanks

? 2023/7/25 21:07, Gavin Li ??: > Enable per queue interrupt coalesce feature bit in driver and validate its > dependency with control queue. > > Signed-off-by: Gavin Li <gavinl at nvidia.com> > Reviewed-by: Dragos Tatulea <dtatulea at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > Acked-by: Michael S. Tsirkin <mst at redhat.com> > Reviewed-by: Heng Qi <hengqi at linux.alibaba.com> Acked-by: Jason Wang <jasowang at redhat.com> Thanks

...rementioned umem parameters at the latest point possible before the VQs of the device are created. v2: - Allocate output with kmalloc to reduce stack frame size. - Removed stable from cc. Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Signed-off-by: Dragos Tatulea <dtatulea at nvidia.com> --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 63 ++++++++++++++++++++++++++----- drivers/vdpa/mlx5/net/mlx5_vnet.h | 9 +++++ 2 files changed, 63 insertions(+), 9 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 40a03...