search for: targetshouldbedirectory

http://bugzilla.mindrot.org/show_bug.cgi?id=1091 Summary: targetshouldbedirectory not set for remote wildcards Product: Portable OpenSSH Version: 3.8.1p1 Platform: All OS/Version: Linux Status: NEW Keywords: low-hanging-fruit Severity: normal Priority: P3 Component: scp AssignedTo:...

http://bugzilla.mindrot.org/show_bug.cgi?id=1091 ------- Comment #1 from djm at mindrot.org 2006-04-18 15:07 ------- We have this "half right" now, in that scp hosta:foo hosta:bar /tmp/abc will check that /tmp/abc is a directory, but there is no way to know a priori that : scp hosta:* /tmp/abc will yield multiple files. I suppose we could modify sink() to raise an error on the

...+/* This is the program to execute for the remote scp. ("scp" or -e) */ +char *scp_remote_program = _PATH_SCP_REMOTE_PROGRAM; + /* This is used to store the pid of ssh_program */ pid_t do_cmd_pid = -1; @@ -198,8 +201,8 @@ int errs, remin, remout; int pflag, iamremote, iamrecursive, targetshouldbedirectory; -#define CMDNEEDS 64 -char cmd[CMDNEEDS]; /* must hold "rcp -r -p -d\0" */ +char *rscpcmd; /* must hold scp_remote_program + "-r -p -d\0" */ + int response(void); void rsource(char *, struct stat *); @@ -212,12 +215,13 @@ int main(int ar...

...d_pid = -1; /* Command to be executed on remote system using "ssh". */ ! (void) snprintf(cmd, sizeof cmd, "scp%s%s%s%s", verbose_mode ? " -v" : "", iamrecursive ? " -r" : "", pflag ? " -p" : "", targetshouldbedirectory ? " -d" : ""); (void) signal(SIGPIPE, lostconn); --- 379,388 ---- remin = remout = -1; do_cmd_pid = -1; /* Command to be executed on remote system using "ssh". */ ! (void) snprintf(cmd, sizeof cmd, "scp%s%s%s%s%s", verbose_mode ? "...

...following them and +copying their targets. .It Fl p Preserves modification times, access times, and modes from the Index: scp.c --- scp.c.prev +++ scp.c Fri Aug 18 04:14:40 2000 @@ -253,5 +253,5 @@ struct passwd *pwd; uid_t userid; int errs, remin, remout; -int pflag, iamremote, iamrecursive, targetshouldbedirectory; +int linkflag, pflag, iamremote, iamrecursive, targetshouldbedirectory; #define CMDNEEDS 64 @@ -280,5 +280,5 @@ main(argc, argv) memset(sshoptions,0,sizeof(sshoptions)); sshoptionsend = sshoptions; - while ((ch = getopt(argc, argv, "dfprtvBCc:i:P:o:S:q46")) != EOF) + while ((ch =...

...ation. Any comments, questions, or suggestions are welcome. --- ../canonical-openssh5.6/scp.c 2010-07-01 23:37:33.000000000 -0400 +++ scp.c 2010-11-19 17:17:26.000000000 -0500 @@ -302,6 +302,7 @@ struct passwd *pwd; uid_t userid; int errs, remin, remout; int pflag, iamremote, iamrecursive, targetshouldbedirectory; +double fd_offset, fd_inset; #define CMDNEEDS 64 char cmd[CMDNEEDS]; /* must hold "rcp -r -p -d\0" */ @@ -324,6 +325,9 @@ main(int argc, char **argv) extern char *optarg; extern int optind; + fd_inset = 0; + fd_offset = 0; + /* Ensure that fds 0, 1 and 2 are open or direc...

...ble verbose mode. */ int verbose_mode = 0; +/* This disables resume mode for default */ +int resume_mode = 0; + /* This is set to zero if the progressmeter is not desired. */ int showprogress = 1; @@ -202,6 +224,7 @@ uid_t userid; int errs, remin, remout; int pflag, iamremote, iamrecursive, targetshouldbedirectory; +off_t rate_limit = 0; #define CMDNEEDS 64 char cmd[CMDNEEDS]; /* must hold "rcp -r -p -d\0" */ @@ -223,7 +246,10 @@ char *targ; extern char *optarg; extern int optind; - + int factor, i; /* For rate limit */ + const char factors[] = "kMMGGG"; + char *c; + __p...

Hello, I would like to request an update of the progress regarding fixes for the recently disclosed SCP vulnerability (CVE-2018-20685, CVE-2019-6111, CVE-2019-6109, CVE-2019-6110) It has been stated that CVE-2018-20685 has been patched in november but there are currently no information available on the progress of patches regarding the other CVEs. Will there be a patched release any time soon?

...ut = -1; /* Command to be executed on remote system using "ssh". */ ! (void) snprintf(cmd, sizeof cmd, "scp%s%s%s%s", verbose_mode ? " -v" : "", iamrecursive ? " -r" : "", pflag ? " -p" : "", ! targetshouldbedirectory ? " -d" : ""); (void) signal(SIGPIPE, lostconn); if ((targ = colon(argv[argc - 1]))) /* Dest is remote host. */ ! toremote(targ, argc, argv); else { ! tolocal(argc, argv); /* Dest is local host. */ if (targetshouldbedirectory) verifydir(argv[argc - 1...

...OS/Version: All Status: NEW Severity: normal Priority: P2 Component: scp AssignedTo: unassigned-bugs at mindrot.org ReportedBy: cjwatson at debian.org Created attachment 1846 --> https://bugzilla.mindrot.org/attachment.cgi?id=1846 set targetshouldbedirectory if there are two file arguments and argv[1] ends with a slash Sami Haahtinen reported the following bug as https://bugs.launchpad.net/bugs/18757: It appears that scp gets confused if one tries to copy a file in to a missing directory: % pwd /tmp/test % touch foo % ls foo % scp foo...

Hi, When implementing forced-commands using authorized-keys, I realized that scp (when run at the server end) arguments -d, -f and -t are not documented on the man page. scp.c: ... /* Server options. */ case 'd': targetshouldbedirectory = 1; break; case 'f': /* "from" */ iamremote = 1; fflag = 1; break; case 't': /* "to" */ iam...

...rns width of the terminal (for progress meter calculations). */ int getttywidth(void); + int do_cmd(char *host, char *remuser, char *cmd, int *fdin, int *fdout, int argc); /* Struct for addargs */ @@ -206,9 +207,11 @@ uid_t userid; int errs, remin, remout; int pflag, iamremote, iamrecursive, targetshouldbedirectory; +int eraseflag; +char *tmpfn = ""; -#define CMDNEEDS 64 -char cmd[CMDNEEDS]; /* must hold "rcp -r -p -d\0" */ +char *cmd; +int cmdlen; int response(void); void rsource(char *, struct stat *); @@ -236,7 +239,7 @@ addargs(&args, "-oFallBackToRsh no"); ffla...

Dear openssh people, Here's something to try: $ echo a >a $ echo b >b $ echo c >c $ $ scp a b c $ $ echo $? 1 $ cat a b c a b b Ouch! Also, for comparison: $ cp a b c cp: copying multiple files, but last argument `c' is not a directory Try `cp --help' for more information. $ rcp a b c rcp: c: Not a directory. $ Note that the cp behavior is specified in SuSv2.

...c, argv, "dfprtvBCc:i:P:q46S:")) != EOF) switch (ch) { /* User-visible flags. */ case '4': @@ -265,6 +268,9 @@ case 'r': iamrecursive = 1; break; + case 'S': + ssh_program = optarg; + break; /* Server options. */ case 'd': targetshouldbedirectory = 1; @@ -388,7 +394,7 @@ if (*src == 0) src = "."; host = strchr(argv[i], '@'); - len = strlen(SSH_PROGRAM) + strlen(argv[i]) + + len = strlen(ssh_program) + strlen(argv[i]) + strlen(src) + (tuser ? strlen(tuser) : 0) + strlen(thost) + strlen(targ) + CMD...

...eHostName as the destination */ toremote(targ, argc, argv); /* TODO make dest remote server2 */ } else if ((targ = colon(argv[argc - 1]))) /* Dest is remote host. */ toremote(targ, argc, argv); else { tolocal(argc, argv); /* Dest is local host. */ if (targetshouldbedirectory) verifydir(argv[argc - 1]); } -- ----)(----- Luis M System Administrator Kiskeyix.org "We think basically you watch television to turn your brain off, and you work on your computer when you want to turn your brain on" -- Steve Jobs in an interview for MacWorld Magazine 2004-Feb...

...ch) { /* User-visible flags. */ case '4': IPv4 = 1; break; --- 276,302 ---- extern int optind; fflag = tflag = 0; ! while ((ch = getopt(argc, argv, "bdfprtvBCc:i:P:qQS4612")) != EOF) switch (ch) { + /* Server options. */ + case 'd': + targetshouldbedirectory = 1; + break; + case 'f': /* "from" */ + iamremote = 1; + fflag = 1; + break; + case 't': /* "to" */ + iamremote = 1; + tflag = 1; + break; /* User-visible flags. */ + case '1': + protocol = 1; + break; + case '2...

...1.184 +++ scp.c 17 Jan 2016 09:07:52 -0000 @@ -83,6 +83,7 @@ #include <dirent.h> #include <errno.h> #include <fcntl.h> +#include <locale.h> #include <pwd.h> #include <signal.h> #include <stdarg.h> @@ -501,6 +502,8 @@ main(int argc, char **argv) targetshouldbedirectory ? " -d" : ""); (void) signal(SIGPIPE, lostconn); + + (void) setlocale(LC_CTYPE, ""); if ((targ = colon(argv[argc - 1]))) /* Dest is remote host. */ toremote(targ, argc, argv); ----- End forwarded message -----

...id packet_put_int(u_int value); diff -bur openssh-3.7.1p2.orig/scp.c openssh-3.7.1p2/scp.c --- openssh-3.7.1p2.orig/scp.c Fri Aug 22 01:34:41 2003 +++ openssh-3.7.1p2/scp.c Tue Oct 7 08:22:02 2003 @@ -201,6 +201,9 @@ uid_t userid; int errs, remin, remout; int pflag, iamremote, iamrecursive, targetshouldbedirectory; +#ifdef CHARSET_EBCDIC +int binary=0; +#endif #define CMDNEEDS 64 char cmd[CMDNEEDS]; /* must hold "rcp -r -p -d\0" */ @@ -231,7 +234,11 @@ addargs(&args, "-oClearAllForwardings yes"); fflag = tflag = 0; - while ((ch = getopt(argc, argv, "dfl:prtvBCc:i:P:q12...