search for: targetnode

...d to be checked during legalization > and during isel by the tblgen patterns), Right. > this is done only once now (during legalization). Maybe. We still have the old operators like unpck and shup, so couldn't those still trigger? Shouldn't we remove them if we're using this TargetNode method? Is it very expensive to check masks, in the grand scheme of things? > Although we still match the node itself through tblgen patterns, the > tablegen patterns are a lot more clear now, and we were able to remove > lots of confusing code. That's more to do with the way the pa...

> In the experience I just had, it is quite error-prone to have multiple > tblgen patterns to match these things.  The way things were before, > there was a clean separation between checking/enforcing node legality > and doing the final code selection, with isel being automatic through > tblgen.  That was nice.  The current setup mixes the two and seems to > result in more code

> Maybe.  We still have the old operators like unpck and shup, so couldn't > those still trigger?  Shouldn't we remove them if we're using this > TargetNode method? > > Is it very expensive to check masks, in the grand scheme of things? Probably not, in the old scheme the masks could be checked more than once during legalization and also more than once in the tablegen file (since the same mask is used in several patterns). But even if it's n...