search for: target_name

This is why I shouldn't program before lunchtime ... v2 & v3 omitted gettext (‘f_()’) annotations around the warning and error strings. Fixed in this version. My cover letter for v2 still applies here. Rich.

...uest tools source directory %s" dir; - let cmd = sprintf "cd %s && find -L -type f" (quote dir) in - let paths = external_command cmd in - List.iter ( - fun path -> - if filter path inspect then ( - let source = dir // path in - let target_name = String.lowercase_ascii (Filename.basename path) in - let target = destdir // target_name in - debug "windows: copying guest tools bits: 'host:%s' -> '%s'" - source target; - - g#write target (read_whole_file source); -...

This is my version of this patch which I think improves it in a number of ways. Firstly instead of having the bare boolean parameter ‘ok_if_missing’ we pass in the function we want to call along the directory missing path. This change then allows us to print a more useful error or warning message given the context of the call, and the new message is actionable too, so the user knows what has to

Sorry, there was a small mistake in v2 of the patch. The difference between v2 & v3 is below. All my other comments in the cover letter of v2 also apply here. Rich. --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -293,8 +293,7 @@ and copy_drivers g inspect driverdir = [] <> copy_from_virtio_win g inspect "/" driverdir virtio_iso_path_matches_guest_os

...; # always set to 'x' class(ans) <- "table" ans } table1D() also fixes some issues with base::table() that can be exposed by running the tests below. test_table <- function(FUN_NAME) { FUN <- match.fun(FUN_NAME) .make_target <- function(target_names, target_data) { ans <- array(target_data) dimnames(ans) <- list(as.character(target_names)) names(dimnames(ans)) <- "x" class(ans) <- "table" ans } .check_identical <- function(target, current, varname,...

...iverdir // > - String.lowercase_ascii (Filename.basename path) in > - debug "copying virtio driver bits: 'host:%s' -> '%s'" > + if filter path inspect then ( > + let source = dir // path in > + let target_name = String.lowercase_ascii (Filename.basename path) in > + let target = destdir // target_name in > + debug "windows: copying guest tools bits: 'host:%s' -> '%s'" > source target; > > g#write target (read_whol...

...let target = driverdir // - String.lowercase_ascii (Filename.basename path) in - debug "copying virtio driver bits: 'host:%s' -> '%s'" + if filter path inspect then ( + let source = dir // path in + let target_name = String.lowercase_ascii (Filename.basename path) in + let target = destdir // target_name in + debug "windows: copying guest tools bits: 'host:%s' -> '%s'" source target; g#write target (read_whole_file source); -...

...let target = driverdir // - String.lowercase_ascii (Filename.basename path) in - debug "copying virtio driver bits: 'host:%s' -> '%s'" + if filter path inspect then ( + let source = dir // path in + let target_name = String.lowercase_ascii (Filename.basename path) in + let target = destdir // target_name in + debug "windows: copying guest tools bits: 'host:%s' -> '%s'" source target; g#write target (read_whole_file source); -...

...let target = driverdir // - String.lowercase_ascii (Filename.basename path) in - debug "copying virtio driver bits: 'host:%s' -> '%s'" + if filter path inspect then ( + let source = dir // path in + let target_name = String.lowercase_ascii (Filename.basename path) in + let target = destdir // target_name in + debug "copying guest tool bits: 'host:%s' -> '%s'" source target; g#write target (read_whole_file source); - ret := t...

changes in v5: - simplified expression in copy_drivers - new commit fixing path constructions - indentation fixes changes in v4: - fix call to install_local changes in v2: - moved copy_drivers above copy_files - renamed copy_files to copy_from_virtio_win - renamed install to install_local - use rpm instead of yum This installs packages with QEMU Guest Agent when converting Linux machine. The

This installs packages with QEMU Guest Agent when converting Linux machine. The packages should be available on guest tools ISO. The patches work "as-is" but probably deserve some more attention: - it is "abusing" Winows_virtio code but renaming/refactoring everything to remove "windows" from the name and use "guest tools" seems like a lot of unnecesary

...s to support this flag as well. (that could be another reason why you don’t see the failure on Linux) 1 if(NOT LLVM_NO_DEAD_STRIP) 2 if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin") 3 # ld64's implementation of -dead_strip breaks tools that use plugins. 4 set_property(TARGET ${target_name} APPEND_STRING PROPERTY 5 LINK_FLAGS " -Wl,-dead_strip") 6 elseif(${CMAKE_SYSTEM_NAME} MATCHES "SunOS") 7 set_property(TARGET ${target_name} APPEND_STRING PROPERTY 8 LINK_FLAGS " -Wl,-z -Wl,discard-unused=sections") 9 else...

changes in v2: - moved copy_drivers above copy_files - renamed copy_files to copy_from_virtio_win - renamed install to install_local - use rpm instead of yum This installs packages with QEMU Guest Agent when converting Linux machine. The packages should be available on guest tools ISO. The patches work "as-is" but probably deserve some more attention: - it is "abusing"

...ason why you don’t see the failure on Linux) >> >> 1 *if*(NOT LLVM_NO_DEAD_STRIP) >> 2 *if*(${CMAKE_SYSTEM_NAME} MATCHES "Darwin") >> 3 # ld64's implementation of -dead_strip breaks tools that use >> plugins. >> 4 set_property(TARGET ${target_name} APPEND_STRING PROPERTY >> 5 LINK_FLAGS " -Wl,-dead_strip") >> 6 *elseif*(${CMAKE_SYSTEM_NAME} MATCHES "SunOS") >> 7 set_property(TARGET ${target_name} APPEND_STRING PROPERTY >> 8 LINK_FLAGS " -Wl,-z -Wl,di...

I need to build libLLVM (individual static libraries are fine at the moment) using mingw-w64 cross compilers, i686-w64-mingw32-gcc and (separately) x86_64-w64-mingw32-gcc. I'd like this to work from both Linux and Cygwin build environments. With autotools, this worked fine: ../configure --host=i686-w64-mingw32 and that's it (with mingw32-gcc-c++ installed on Fedora 23, also works fine on

changes in v3: - fix call to install_local changes in v2: - moved copy_drivers above copy_files - renamed copy_files to copy_from_virtio_win - renamed install to install_local - use rpm instead of yum This installs packages with QEMU Guest Agent when converting Linux machine. The packages should be available on guest tools ISO. The patches work "as-is" but probably deserve some more

...>> >> >> 1 *if*(NOT LLVM_NO_DEAD_STRIP) >> >> 2 *if*(${CMAKE_SYSTEM_NAME} MATCHES "Darwin") >> >> 3 # ld64's implementation of -dead_strip breaks tools that use >> >> plugins. >> >> 4 set_property(TARGET ${target_name} APPEND_STRING PROPERTY >> >> 5 LINK_FLAGS " -Wl,-dead_strip") >> >> 6 *elseif*(${CMAKE_SYSTEM_NAME} MATCHES "SunOS") >> >> 7 set_property(TARGET ${target_name} APPEND_STRING PROPERTY >> >> 8...

...My current workaround is to simply unset these environment variables before running the native configure step: --- a/cmake/modules/CrossCompile.cmake +++ b/cmake/modules/CrossCompile.cmake @@ -45,6 +45,9 @@ function(llvm_create_cross_target_internal target_name toolchain buildtype) # Propagate LLVM_EXTERNAL_CLANG_SOURCE_DIR so that clang-tblgen can be built set(external_clang_dir "-DLLVM_EXTERNAL_CLANG_SOURCE_DIR=${LLVM_EXTERNAL_CLANG_SOURCE_DIR}") endif() + unset(ENV{ASM})...

...ibosinfo.location in + let dir = + match uri.Xml.uri_path with + | Some p -> p + | None -> assert false in + List.filter_map ( + fun f -> + let source = dir // f in + if not (Sys.file_exists source) then + None + else ( + let target_name = String.lowercase_ascii (Filename.basename f) in + let target = destdir ^ "/" ^ target_name in + debug "windows: copying guest tools bits: 'host:%s' -> '%s'" + source target; + + g#copy_in source destdir; + S...

changes in v4: - fix call to install_local changes in v2: - moved copy_drivers above copy_files - renamed copy_files to copy_from_virtio_win - renamed install to install_local - use rpm instead of yum This installs packages with QEMU Guest Agent when converting Linux machine. The packages should be available on guest tools ISO. The patches work "as-is" but probably deserve some more