search for: target_msc

Hi all, the following patch fixes a race-condition in the nouveau ddx which caused frequent x-server crashes for at least 1 user under some loads when OpenGL triple-buffering is enabled, which it is by default on XOrg 1.12 and later. As a side effect, it provides a small optimization for the common case of bufferswap at next vblank. The other way to avoid the race + possible crash is to set

Hi, here a set of patches against the nouveau-ddx. This is an extended and revised set, based on Francisco Jerez feedback from autumn last year. [1/9] Makes pageflipping work again on X-Server 1.12rc. It apparently stopped working somewhere around Xorg 1.11+. [2/9] Implements handling of pageflip completion events from the kernel. Francisco Jerez argument against including it was that the

Two "updated" patches, according to Michel Daenzers review. See separate e-mail for details. 01/10: Replaces original 01/09 -- Same code, updated commit message. 10/10: Just for demonstration, not for application to ddx.

...oving another window in front. When I revert the commit it behaves normally. Changing can_sync_to_vblank(draw) to 0 in nouveau_dri2_schedule_swap also fixes it. The nouveau kernel driver currently doesn't fill in a frame number, so MSC will always be zero for now, and this makes mplayer choose target_msc = 0 as 'swap at next interval', which appears to be broken by the commit. The following patch fixes frame numbers in the nouveau kernel module, but it only decreases the likelyhood of occuring, it still happens when seeking, for example. ~Maarten --- diff --git a/drivers/gpu/drm/nouveau/...

...      present: Fix Async swap logic Daniel Martin (3):       modesetting: Handle failures in setting a CRTC to a DRM mode properly       modesetting: Free output_ids in drmmode_set_mode_major()       modesetting: Remove XF86_CRTC_VERSION checks Jammy Zhou (1):       present: Execute right away if target_msc equals current_msc Julien Cristau (1):       Xext: fix build with --disable-xace Martin Peres (1):       os: make sure the clientsWritable fd_set is initialized before use Michel Dänzer (1):       DRI2: Sync radeonsi_pci_ids.h from Mesa git tag: xorg-server-1.18.0 http://xorg.freedesktop.org/a...

...      present: Fix Async swap logic Daniel Martin (3):       modesetting: Handle failures in setting a CRTC to a DRM mode properly       modesetting: Free output_ids in drmmode_set_mode_major()       modesetting: Remove XF86_CRTC_VERSION checks Jammy Zhou (1):       present: Execute right away if target_msc equals current_msc Julien Cristau (1):       Xext: fix build with --disable-xace Martin Peres (1):       os: make sure the clientsWritable fd_set is initialized before use Michel Dänzer (1):       DRI2: Sync radeonsi_pci_ids.h from Mesa git tag: xorg-server-1.18.0 http://xorg.freedesktop.org/a...

...le.pScreen); xf86CrtcPtr crtc = rrcrtc->devPrivate; - if (!scrn->vtSema || !crtc->enabled) + if (!scrn->vtSema || !drmmode_crtc_on(crtc)) return FALSE; return TRUE; @@ -199,7 +199,7 @@ nouveau_present_flip_exec(ScrnInfoPtr scrn, uint64_t event_id, int sync, flip->msc = target_msc; for (i = 0; i < config->num_crtc; i++) { - if (config->crtc[i]->enabled) + if (drmmode_crtc_on(config->crtc[i])) last = i; } @@ -208,7 +208,7 @@ nouveau_present_flip_exec(ScrnInfoPtr scrn, uint64_t event_id, int sync, int crtc = drmmode_crtc(config->c...

...allback config on VT enter in case full desiredMode fails sna/dri: Only special case 'divisor && msc-passed' for immediate flipping sna/dri: Disable name exchanges for SwapBuffers sna/dri: Query current msc before use sna/dri: Fix handling of current_msc > target_msc sna/gen4: Use the single-threaded SF w/a for spans as well sna/gen3+: Use nearest for unscaled videos sna/gen2: STIPPLE requires an argument sna: Pin some batches to avoid CS incoherence on 830/845 sna: Fix the error path in kgem_init_pinned_batches() to use the right...

...i: Prefer to use the BLT ring for vsync'ed copies on IVB+ sna: Clean up WAIT_FOR_EVENT on gen2/3 sna/dri: Stop feeding I915_TILING_Y to mesa i915c sna/dri: Only reject DRI2 buffers that are too small for the request blit sna/dri: Don't contribute missed frames to the target_msc sna: Experiment with a threaded renderer for fallback compositing sna: Refactor to use a common fbComposite fallback sna/dri: Compensate clipExtents for drawable offset sna: Use threads for simple mask generation sna: Tidy construction of data for threaded composite...

...get_vblank_timestamp = drm_crtc_vblank_helper_get_vblank_timestamp, }; static enum drm_connector_status @@ -6361,7 +6363,7 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state, * clients using the GLX_OML_sync_control extension or * DRI3/Present extension with defined target_msc. */ - last_flip_vblank = amdgpu_get_vblank_counter_kms(dm->ddev, acrtc_attach->crtc_id); + last_flip_vblank = amdgpu_get_vblank_counter_kms(pcrtc); } else { /* For variable refresh rate mode only: @@ -6390,7 +6392,7 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_s...

...get_vblank_timestamp = drm_crtc_vblank_helper_get_vblank_timestamp, }; static enum drm_connector_status @@ -6478,7 +6480,7 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state, * clients using the GLX_OML_sync_control extension or * DRI3/Present extension with defined target_msc. */ - last_flip_vblank = amdgpu_get_vblank_counter_kms(dm->ddev, acrtc_attach->crtc_id); + last_flip_vblank = amdgpu_get_vblank_counter_kms(pcrtc); } else { /* For variable refresh rate mode only: @@ -6507,7 +6509,7 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_s...

VBLANK handlers in struct drm_driver are deprecated. Only legacy, non-KMS drivers are supposed to used them. DRM drivers with kernel modesetting are supposed to use VBLANK callbacks of the CRTC infrastructure. This patchset converts all DRM drivers to CRTC VBLANK callbacks and cleans up struct drm_driver. The remaining VBLANK callbacks in struct drm_driver are only used by legacy drivers. Patch

VBLANK handlers in struct drm_driver are deprecated. Only legacy, non-KMS drivers are supposed to used them. DRM drivers with kernel modesetting are supposed to use VBLANK callbacks of the CRTC infrastructure. This patchset converts all DRM drivers to CRTC VBLANK callbacks and cleans up struct drm_driver. The remaining VBLANK callbacks in struct drm_driver are only used by legacy drivers. Patch

VBLANK handlers in struct drm_driver are deprecated. Only legacy, non-KMS drivers are supposed to used them. DRM drivers with kernel modesetting are supposed to use VBLANK callbacks of the CRTC infrastructure. This patchset converts all DRM drivers to CRTC VBLANK callbacks and cleans up struct drm_driver. The remaining VBLANK callbacks in struct drm_driver are only used by legacy drivers.