search for: target_formats

This changes the infrastructure to allow the target_file to be a QEMU URI. Rich.

Factor out copying the overlays to final disk images into a separate function. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/v2v.ml | 227 +++++++++++++++++++++++++++++++------------------------------ 1 file changed, 114 insertions(+), 113 deletions(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index afffde2..703038c 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -110,121 +110,9 @@ let

We previously implicitly supported writing to block devices instead of local files, but there were several problems: * Block devices could be deleted, especially if virt-v2v failed during a conversion. * Block devices could be overwritten by a file with the same name, although I believe this is just an observed consequence of the previous point, or at least I was not able to reproduce this

When using oVirt >= 4.3, we can enable the NBD based backend in imageio by specifying that we transfer raw data when creating a transfer. With the NBD backend, we can specify qcow2 disk format. I think we need a way to expose the capabilities of the output to the user. For example, can we use qcow2 format. Issues: - I hacked qemu-img convert command line to always use -O raw instead of

...will also not > work. *) > > + [ "-n"; "-f"; "qcow2"; "-O"; "raw" ] @ > > This is going to break all the other output modes. > > You probably want to define a new method output#override_output_format > (see v2v.ml:get_target_formats and types.mli). > Maybe outpu#tranfer_format? Return output_format by default, rhv_output will override it to return raw? > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat > http://people.redhat.com/~rjones > Read my programming and virtualization blog: http://r...

All the current output modes use the default, It's just that I have a patch that uses this, so there might be someone in the future who wants to use this and if not, then at least you can tell me if this is wrong or not. Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- v2v/types.ml | 15 +++++++++++++++ v2v/types.mli | 8 +++++++- v2v/v2v.ml | 17 +++-------------- 3

Commit 4699c7b6e126e07c95b67fb95df58aed87a680dd converted the null output to use the null-co qemu driver with a JSON URL syntax -- especially the latter is only available in newer versions of qemu. Even if this output mode is mostly for testing, check at runtime whether the null-co + JSON way is possible, falling back to the creation of thrown-away temporary files as before. ---

On Tue, Sep 01, 2020 at 08:55:38PM +0300, Nir Soffer wrote: ... > > Note this commit intentionally does not prevent you from writing qcow2 > > to a block device. RHV uses this so it is a thing that people do. ... > > +Note that you must create block devices of the correct size, and you > > +need to use I<-of raw> since other output formats would not normally >

On Tue, Sep 1, 2020 at 4:56 PM Richard W.M. Jones <rjones@redhat.com> wrote: > > We previously implicitly supported writing to block devices instead of > local files, but there were several problems: > > * Block devices could be deleted, especially if virt-v2v failed during > a conversion. > > * Block devices could be overwritten by a file with the same name, >

This patch series lifts the previous restriction that virt-v2v would refuse to convert a guest to Glance that had more than one disk. The first patch is just better documentation for the Glance output mode. The second patch contains the change (best viewed with 'git diff -w' since it is mostly a whitespace change). virt-v2v -o glance will now create multiple disks called: - guestname

The glance client v1.0.0 defaults to the Image v2 API: this means that an image can be referenced only by its UUID, and not anymore by the name as well (which does not need to be unique). This caused our glance invocation to set the properties for the newly created image to fail, since we are using the name as identifier. Instead of first creating the image and then setting all the properties

...not} create) the target file. The [(string * overlay list)] parameter is a list of the (format, overlay) for each target disk. If diff --git a/v2v/v2v.ml b/v2v/v2v.ml index dc1dedd7..9fd63442 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -173,7 +173,8 @@ let rec main () = let target_formats = get_target_formats cmdline output overlays in let target_files = output#prepare_targets source.s_name - (List.combine target_formats overlays) in + (List.combine target_formats overlays) + guestcaps in List.map ( fun (target...

Instead of writing to a temporary file and deleting it, use the null block driver in qemu to throw it away. --- v2v/output_null.ml | 47 +++++++++++++++++++++++++++++++++-------------- v2v/virt-v2v.pod | 4 ---- 2 files changed, 33 insertions(+), 18 deletions(-) diff --git a/v2v/output_null.ml b/v2v/output_null.ml index d01f45654..4d06aa0de 100644 --- a/v2v/output_null.ml +++

On Tue, Sep 01, 2020 at 07:37:42PM +0100, Richard W.M. Jones wrote: > On Tue, Sep 01, 2020 at 08:55:38PM +0300, Nir Soffer wrote: > ... > > > Note this commit intentionally does not prevent you from writing qcow2 > > > to a block device. RHV uses this so it is a thing that people do. > ... > > > +Note that you must create block devices of the correct size, and

This is analogous to --print-source, except that it prints the overlay and target disk information. The output looks like below. Note there is one overlay and one target section per disk. Overlay and Target information (--print-target option): overlay file: /home/rjones/d/libguestfs/tmp/v2vovlc687fe.qcow2 overlay device name: sda overlay virtual disk size: 6442450944

Besides, it doesn't need guestfs handle open so move this step earlier in the process. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/v2v.ml | 77 ++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 155eb83..4257b8d 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -58,6 +58,7

This adds --print-target. In addition, v2 provides a machine-readable version (in JSON format). All of the record -> JSON boilerplate in this patch could be eliminated if we moved the baseline to OCaml 4.02. Rich.

...e disk format. commpressed format will also not work. *) > + [ "-n"; "-f"; "qcow2"; "-O"; "raw" ] @ This is going to break all the other output modes. You probably want to define a new method output#override_output_format (see v2v.ml:get_target_formats and types.mli). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported....

...gt; > > + [ "-n"; "-f"; "qcow2"; "-O"; "raw" ] @ > > > > This is going to break all the other output modes. > > > > You probably want to define a new method output#override_output_format > > (see v2v.ml:get_target_formats and types.mli). > > > > Maybe outpu#tranfer_format? > Return output_format by default, rhv_output will override it to return raw? Isn't that essentially what #override_output_format virtual method does already? Rich. -- Richard Jones, Virtualization Group, Red Hat http://peo...

On Tue, Sep 1, 2020 at 9:42 PM Richard W.M. Jones <rjones@redhat.com> wrote: > > On Tue, Sep 01, 2020 at 07:37:42PM +0100, Richard W.M. Jones wrote: > > On Tue, Sep 01, 2020 at 08:55:38PM +0300, Nir Soffer wrote: > > ... > > > > Note this commit intentionally does not prevent you from writing qcow2 > > > > to a block device. RHV uses this so it is a