search for: target_fil

This changes the infrastructure to allow the target_file to be a QEMU URI. Rich.

...quot;, the actual resulting file still remains at 0600 ?!? #!/bin/bash # Usage: imapsieve_copy <email> <spam|ham> MSG_USER="$1" MSG_TYPE="$2" RUN_UUID=$(cat /proc/sys/kernel/random/uuid) BASE_DIR="/foo/bar" TARGET_DIR="${BASE_DIR}/${MSG_TYPE}" TARGET_FILE="${TARGET_DIR}/${RUN_UUID}" cat > "${TARGET_FILE}" < /dev/stdin && pigz -9 "${TARGET_FILE}"

...target_buses); - let delete_target_on_exit = ref true in - let targets = if not do_copy then targets - else ( - (* Copy the source to the output. *) - at_exit (fun () -> - if !delete_target_on_exit then ( - List.iter ( - fun t -> try unlink t.target_file with _ -> () - ) targets - ) - ); - let nr_disks = List.length targets in - mapi ( - fun i t -> - message (f_"Copying disk %d/%d to %s (%s)") - (i+1) nr_disks t.target_file t.target_format; - if verbose () then prin...

...put_pool - method supported_firmware = [ TargetBIOS; TargetUEFI ] - method prepare_targets source targets = (* Get the capabilities from libvirt. *) let xml = Libvirt_utils.capabilities ?conn:oc () in @@ -140,6 +138,8 @@ class output_libvirt oc output_pool = object { t with target_file = target_file } ) targets + method supported_firmware = [ TargetBIOS; TargetUEFI ] + method check_target_firmware guestcaps target_firmware = match target_firmware with | TargetBIOS -> () diff --git a/v2v/output_local.ml b/v2v/output_local.ml index 9ba1d6f..9c105ef 100644 -...

...@@ -51,19 +81,27 @@ object method supported_firmware = [ TargetBIOS; TargetUEFI ] method prepare_targets source targets = - let json_params = [ - "file.driver", JSON.String "null-co"; - "file.size", JSON.String "1E"; - ] in - let target_file = TargetURI ("json:" ^ JSON.string_of_doc json_params) in + if qemu_supports_null_co_device () then ( + let json_params = [ + "file.driver", JSON.String "null-co"; + "file.size", JSON.String "1E"; + ] in + let target...

...- let t = Mkdtemp.temp_dir ~base_dir "null." in - rmdir_on_exit t; - t in object inherit output @@ -44,13 +51,25 @@ object method supported_firmware = [ TargetBIOS; TargetUEFI ] method prepare_targets source targets = - List.map ( - fun t -> - let target_file = tmpdir // t.target_overlay.ov_sd in - { t with target_file = target_file } - ) targets + let json_params = [ + "file.driver", JSON.String "null-co"; + "file.size", JSON.String "1E"; + ] in + let target_file = "json:"...

...ypes.ml +++ b/v2v/types.ml @@ -521,6 +521,21 @@ class virtual output = object method override_output_format (_ : overlay) = (None : string option) method virtual prepare_targets : source -> (string * overlay) list -> target_buses -> guestcaps -> inspect -> target_firmware -> target_file list method disk_create = (open_guestfs ())#disk_create + method disk_copy target compressed = + let filename = + match target.target_file with + | TargetFile filename -> qemu_input_filename filename + | TargetURI uri -> uri in + let cmd = + [ "qemu-img&quo...

...#39;raw' or 'qcow2'.\n\nUse the '-of <format>' option to select a different output format for the converted guest.\n\nOther output formats are not supported at the moment, although might be considered in future."); - - (* output#prepare_targets will fill in the target_file field. - * estimate_target_size will fill in the target_estimated_size field. - * actual_target_size will fill in the target_actual_size field. - *) - { target_file = ""; target_format = format; - target_estimated_size = None; - target_act...

This patch series lifts the previous restriction that virt-v2v would refuse to convert a guest to Glance that had more than one disk. The first patch is just better documentation for the Glance output mode. The second patch contains the change (best viewed with 'git diff -w' since it is mostly a whitespace change). virt-v2v -o glance will now create multiple disks called: - guestname

This is just a bit of preparatory refactoring ... Rich.

...ass virtual output = object method check_target_firmware (_ : guestcaps) (_ : target_firmware) = () method override_output_format (_ : overlay) = (None : string option) method transfer_format t = t.target_format - method virtual prepare_targets : string -> (string * overlay) list -> target_file list + method virtual prepare_targets : string -> (string * overlay) list -> guestcaps -> target_file list method disk_create = (open_guestfs ())#disk_create method disk_copied (_ : target) (_ : int) (_ : int) = () method virtual create_metadata : source -> target list ->...

...else sprintf "%s-disk%d" source.s_name (i+1) in - let cmd = [ "glance"; "image-create"; "--name"; name; - "--disk-format=" ^ target_format; - "--container-format=bare"; "--file"; target_file ] in - if run_command cmd <> 0 then - error (f_"glance: image upload to glance failed, see earlier errors"); - (* Set the properties (ie. metadata). *) let min_ram = source.s_memory /^ 1024L /^ 1024L in let properties = [ @@ -114,26 +108,1...

...gt; > #!/bin/bash > > # Usage: imapsieve_copy <email> <spam|ham> > > MSG_USER="$1" > MSG_TYPE="$2" > > RUN_UUID=$(cat /proc/sys/kernel/random/uuid) > BASE_DIR="/foo/bar" > TARGET_DIR="${BASE_DIR}/${MSG_TYPE}" > TARGET_FILE="${TARGET_DIR}/${RUN_UUID}" > > cat > "${TARGET_FILE}" < /dev/stdin && pigz -9 "${TARGET_FILE}" You can run umask 0222 to change it. Aki

This adds --print-target. In addition, v2 provides a machine-readable version (in JSON format). All of the record -> JSON boilerplate in this patch could be eliminated if we moved the baseline to OCaml 4.02. Rich.

.... Use the cmake_policy [ 1495s] command to set the policy and suppress this warning. [ 1495s] [ 1495s] The LOCATION property should not be read from target "TargetInfo". Use the [ 1495s] target name directly with add_custom_command, or use the generator [ 1495s] expression $<TARGET_FILE>, as appropriate. [ 1495s] [ 1495s] Call Stack (most recent call first): [ 1495s] projects/dragonegg/CMakeLists.txt:87 (add_backend_header) [ 1495s] This warning is for project developers. Use -Wno-dev to suppress it. [ 1495s] [ 1495s] -- Target architecture is X86 [ 1495s] CMake Warning (...

This patch series adds stable bus and slot numbers for removable drives (CDs and floppies) when the guest is converted using virt-v2v or virt-p2v. Previously we were a bit random about this. After this patch series, the bus and slot numbers and preserved if at all possible. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1238053 Rich.

...printf "\ -ov_overlay_file = %s -ov_sd = %s -ov_virtual_size = %Ld -ov_source = %s + sprintf " overlay file: %s + overlay device name: %s +overlay virtual disk size: %Ld + overlay source qemu URI: %s " ov.ov_overlay_file ov.ov_sd @@ -304,12 +303,9 @@ and target_file = | TargetURI of string let string_of_target t = - sprintf "\ -target_file = %s -target_format = %s -target_estimated_size = %s -target_overlay = %s -target_overlay.ov_source = %s + sprintf " target file: %s + target format: %s +target estimated size: %s "...

...rtxml option When using the I<-i libvirtxml> option, you have to supply some diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 73edff2c4..a70310891 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -683,7 +683,10 @@ and copy_targets cmdline targets input output = fun t -> match t.target_file with | TargetURI _ -> () - | TargetFile s -> try unlink s with _ -> () + | TargetFile filename -> + if not (is_block_device filename) then ( + try unlink filename with _ -> () + ) ) targets ) ); @@ -71...

...top. > CMakeFiles/Makefile2:199: recipe for target 'CMakeFiles/test-suite.dir/all' failed > And the referenced line of the generated makefile is: > test-suite-stamps/test-suite-force-rebuild: /home/das-local/llvm-release-3.8/release/branches_release_38/llvm.src/$<TARGET_FILE:clang> > it looks like cmake isn't fully expanding its generator expressions. > > Looking at my logs, it looks like the test-suite used to configure in 3.6.2 but didn't build as part of test-release.sh and then 3.7.0 stopped since we had switched to cmake and there was no CMake...

Add an optional parameter to disable this behaviour, so the Curl module in v2v won't print user-sensible data (like passwords). --- builder/checksums.ml | 1 - builder/downloader.ml | 1 - builder/sigchecker.ml | 1 - mllib/common_utils.ml | 4 +++- mllib/common_utils.mli | 7 +++++-- v2v/curl.ml | 2 +- 6 files changed, 9 insertions(+), 7 deletions(-) diff --git