Displaying 5 results from an estimated 5 matches for "tablegeni".
Did you mean:
tablegen
2012 Jun 24
2
[LLVMdev] Complex load patterns and token factors
...Gen won't know it needs the chain.
Tim,
Correct, the instruction has no pattern of its own.
>
> There's a big comment just above the test about how the current
> situation is rather broken. I'm currently inclined to add a check for
> mayLoad and mayStore at that point in TableGeni (see patch), but was
> waiting until I could give tests and justification on the list before
> submitting it.
Thanks for sending this! As far as a long-term solution, would it be
better to update TableGen with this logic instead of putting this in
ISel? Also, we should probably include hasUn...
2012 Jun 23
0
[LLVMdev] Complex load patterns and token factors
...in.
So if your QVLFDXb instruction doesn't set the Pattern(s?) field,
TableGen won't know it needs the chain.
There's a big comment just above the test about how the current
situation is rather broken. I'm currently inclined to add a check for
mayLoad and mayStore at that point in TableGeni (see patch), but was
waiting until I could give tests and justification on the list before
submitting it.
Tim.
-------------- next part --------------
diff --git a/utils/TableGen/DAGISelMatcherGen.cpp b/utils/TableGen/DAGISelMatcherGen.cpp
index 2ac7b87..4acd209 100644
--- a/utils/TableGen/DAGISel...
2012 Jun 24
0
[LLVMdev] Complex load patterns and token factors
...> Tim,
>
> Correct, the instruction has no pattern of its own.
>
> >
> > There's a big comment just above the test about how the current
> > situation is rather broken. I'm currently inclined to add a check
> > for mayLoad and mayStore at that point in TableGeni (see patch),
> > but was waiting until I could give tests and justification on the
> > list before submitting it.
>
> Thanks for sending this!
Please ignore this statement:
> As far as a long-term solution, would it be
> better to update TableGen with this logic instead of...
2012 Jun 23
2
[LLVMdev] Complex load patterns and token factors
Working on a target I added this pattern:
def : Pat<(v4i64 (load xoaddr:$src)),
(QVFCTIDb (QVLFDXb xoaddr:$src))>;
which represents an actual load followed by a necessary conversion
operation. The problem is that when this matches any TokenFactor that
was attached to the load node gets attached, not to the inner load
instruction, but the outer conversion operation. This is
2012 Jun 24
2
[LLVMdev] Complex load patterns and token factors
...ect, the instruction has no pattern of its own.
> >
> > >
> > > There's a big comment just above the test about how the current
> > > situation is rather broken. I'm currently inclined to add a check
> > > for mayLoad and mayStore at that point in TableGeni (see patch),
> > > but was waiting until I could give tests and justification on the
> > > list before submitting it.
> >
> > Thanks for sending this!
>
> Please ignore this statement:
> > As far as a long-term solution, would it be
> > better to up...