search for: t_ops

...????? size_t max_to_send) >> ????????????????????????????????????????????? ^ >> I'd call it `pkt_len`, `max_to_send` is confusing IMHO. I didn't >> initially if it was the number of buffers or bytes. >> >>> +{ >>> +??? const struct virtio_transport *t_ops; >>> +??? struct iov_iter *iov_iter; >>> + >>> +??? if (!info->msg) >>> +??????? return false; >>> + >>> +??? iov_iter = &info->msg->msg_iter; >>> + >>> +??? if (iov_iter->iov_offset) >>> +??????? retur...

...check for the same potential issue and a returned error in the virtio_transport_send_pkt_info() function to avoid crashing the kernel. Stefano Garzarella (2): vsock/virtio: fix null-pointer dereference in virtio_transport_recv_listen() vsock/virtio: add WARN_ON check on virtio_transport_get_ops() net/vmw_vsock/virtio_transport_common.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) -- 2.23.0

...6564192e7f20..3fdf1433ec28 100644 >>> --- a/net/vmw_vsock/virtio_transport_common.c >>> +++ b/net/vmw_vsock/virtio_transport_common.c >>> @@ -196,7 +196,8 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk, >>> ????const struct virtio_transport *t_ops; >>> ????struct virtio_vsock_sock *vvs; >>> ????u32 pkt_len = info->pkt_len; >>> -??? struct sk_buff *skb; >>> +??? u32 rest_len; >>> +??? int ret; >>> >>> ????info->type = virtio_transport_get_type(sk_vsock(vsk)); >>> &g...

...ck/virtio_transport_common.c >index 6564192e7f20..e0b2c6ecbe22 100644 >--- a/net/vmw_vsock/virtio_transport_common.c >+++ b/net/vmw_vsock/virtio_transport_common.c >@@ -196,7 +196,8 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk, > const struct virtio_transport *t_ops; > struct virtio_vsock_sock *vvs; > u32 pkt_len = info->pkt_len; >- struct sk_buff *skb; >+ u32 rest_len; >+ int ret; > > info->type = virtio_transport_get_type(sk_vsock(vsk)); > >@@ -216,10 +217,6 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *v...

...ck/virtio_transport_common.c >index 6564192e7f20..a300f25749ea 100644 >--- a/net/vmw_vsock/virtio_transport_common.c >+++ b/net/vmw_vsock/virtio_transport_common.c >@@ -196,7 +196,8 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk, > const struct virtio_transport *t_ops; > struct virtio_vsock_sock *vvs; > u32 pkt_len = info->pkt_len; >- struct sk_buff *skb; >+ u32 rest_len; >+ int ret; > > info->type = virtio_transport_get_type(sk_vsock(vsk)); > >@@ -216,10 +217,6 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *v...

Commit-ID: 4061dd0658545bd7ea6a677663e31be9ee7f57cb Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=4061dd0658545bd7ea6a677663e31be9ee7f57cb Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Sun, 28 Sep 2014 18:40:18 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Fri, 25 Jan 2019 02:57:21 +0000 [klibc] [BUILTIN] Correctly

Commit-ID: b72377e6b73676c43bd0cff5eb202694a9c2b4ea Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=b72377e6b73676c43bd0cff5eb202694a9c2b4ea Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Sun, 28 Sep 2014 18:40:18 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 28 Mar 2020 21:42:54 +0000 [klibc] dash: [BUILTIN]

...44 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -236,6 +236,7 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk, } virtio_transport_inc_tx_pkt(vvs, skb); + skb_set_owner_w(skb, sk_vsock(vsk)); return t_ops->send_pkt(skb); }