search for: sysroot_realpath

...esting enough, realpath has been unconditionally used already, so I will pull the plug to the conditional usage in some other parts, then. > Is it possible to make this change more generic so in future it could > be applied to other functions? > > - Would it make sense to have a 'sysroot_realpath' library function to > replace 'sysroot_path' in certain functions? Good idea. Do you have also an idea which daemon functions, other than scrub-files and realpath itself, might need such handling? -- Pino Toscano

Resolve the given path within the chroot, so scrub can be invoked outside the chroot on an already-resolved path. Given that realpath is used, its availability is checked manually, since scrub-file already depends on the "scrub" feature. Slightly ugly, but on the other hand realpath is generally available nowadays, so the check should not be failing. Add few tests in scrub-file for this

...| 4 +-- 12 files changed, 107 insertions(+), 21 deletions(-) diff --git a/daemon/daemon.h b/daemon/daemon.h index a40dc3834..02ae34a6f 100644 --- a/daemon/daemon.h +++ b/daemon/daemon.h @@ -62,6 +62,7 @@ extern dev_t root_device; extern char *sysroot_path (const char *path); extern char *sysroot_realpath (const char *path); extern int is_root_device (const char *device); +extern int is_device_parameter (const char *device); extern int xwrite (int sock, const void *buf, size_t len) __attribute__((__warn_unused_result__)); extern int xread (int sock, void *buf, size_t len) diff --git a/daemon/d...

https://bugzilla.redhat.com/show_bug.cgi?id=1477623 The first two patches are cleanups. The third patch changes the way that we handle Device and Dev_or_Path parameters so that a parameter marked as such can really only contain a block device name (and not, for instance, a chardev). Using a chardev here caused hangs in the API. The next two patches fix API usage to conform to this new stricter

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’