search for: syslinux_memory_map

...*hdr, +static size_t calc_cmdline_offset(const struct syslinux_memmap *mmap, + const struct linux_header *hdr, size_t cmdline_size, addr_t base, addr_t start) { - if (hdr->version < 0x0202 || !(hdr->loadflags & 0x01)) { - struct syslinux_memmap *mmap; - - mmap = syslinux_memory_map(); - if (mmap && !syslinux_memmap_highest(mmap, SMT_FREE, &start, - cmdline_size, 0xa0000, 16)) { - syslinux_free_memmap(mmap); - return start - base; - } + size_t max_offset; - if (mmap && !syslinux_memmap_highest(mmap, SMT_TERMINAL, &start, -...

...or messages, will result in the same behavior. Gert Hulselmans $ diff -u com32/modules/chain.c.old com32/modules/chain.c.new --- com32/modules/chain.c.old 2009-08-17 01:06:11.887394937 +0200 +++ com32/modules/chain.c.new 2009-08-17 01:11:33.656402727 +0200 @@ -446,7 +446,7 @@ mmap = syslinux_memory_map(); if (!mmap) { - error("Cannot read system memory map"); + error("Cannot read system memory map\n"); return; } @@ -547,11 +547,11 @@ return; too_big: - error("Loader file too large"); + error("Loader file too large\n");...

"H. Peter Anvin" <hpa at zytor.com> on Tue, 2013/12/03 20:26: > On 10/24/2013 01:09 AM, Christian Hesse wrote: > >>> > >>> version 6.02-pre5 works, 6.02-pre6 does not. > >> > >> Struggled with git bisect, but finally succeeded: > >> > >> 8f470e7bfe75f6401f6c5432988c620b863ad274 is the first bad commit > >>

...t; > Gert Hulselmans > > > $ diff -u com32/modules/chain.c.old com32/modules/chain.c.new > > --- com32/modules/chain.c.old 2009-08-17 01:06:11.887394937 +0200 > +++ com32/modules/chain.c.new 2009-08-17 01:11:33.656402727 +0200 > @@ -446,7 +446,7 @@ > mmap = syslinux_memory_map(); > > if (!mmap) { > - error("Cannot read system memory map"); > + error("Cannot read system memory map\n"); > return; > } > > @@ -547,11 +547,11 @@ > return; > > too_big: > - error("Loader file too large&...

On 07/29/2013 06:28 AM, Matt Fleming wrote: > On Fri, 26 Jul, at 09:49:28AM, H. Peter Anvin wrote: >> Hmm... this might constrain the heap excessively if the SMT_TERMINAL >> cutoff is at the wrong place (because there will be just enough SMT_FREE >> to fit.) I'm wondering if we shouldn't use the highest of these two >> regions. > > Could you give an

...ze) > + size_t cmdline_size, addr_t base, > + addr_t start) > { > - if (hdr->version < 0x0202 || !(hdr->loadflags & 0x01)) > + if (hdr->version < 0x0202 || !(hdr->loadflags & 0x01)) { > + struct syslinux_memmap *mmap; > + > + mmap = syslinux_memory_map(); > + if (mmap && !syslinux_memmap_highest(mmap, SMT_FREE, &start, > + cmdline_size, 0xa0000, 16)) { > + syslinux_free_memmap(mmap); > + return start - base; > + } > + > + if (mmap && !syslinux_memmap_highest(mmap, SMT_TERMINAL, &start,...

This is a bit updated set of chain.c32 changes that simplifies a few things (and in partiter part), fixes few minor issues and adds a few new features. Details are in the following commits, below is the summary and pull details at the end. Shao - any chance to peek over them ? Most of those are relatively simple changes and well tested, though of course something might have slipped my attention.