search for: syslinux_memmap_find

A Toshiba CB35 Chromebook running Google's stock SeaBIOS reboots after selecting a relocatable kernel from extlinux 6.03. This is a regression caused by commit 8f470e7b movebits: Add syslinux_memmap_find() which factors syslinux_memmap_find() out of bios_boot_linux(). Prior to the refactoring, prot_mode_size was passed as the length in the first call to syslinux_memmap_type(). After the refactoring, hdr.init_size was passed. Now, with commit ef81a3ad, one or the other is passed according to wh...

> A Toshiba CB35 Chromebook running Google's stock SeaBIOS reboots after > selecting a relocatable kernel from extlinux 6.03. > > This is a regression caused by commit 8f470e7b > movebits: Add syslinux_memmap_find() > > which factors syslinux_memmap_find() out of bios_boot_linux(). Prior to > the refactoring, prot_mode_size was passed as the length in the first call > to syslinux_memmap_type(). After the refactoring, hdr.init_size was > passed. Now, with commit ef81a3ad, one or the other i...

...th git bisect, but finally succeeded: > > 8f470e7bfe75f6401f6c5432988c620b863ad274 is the first bad commit > commit 8f470e7bfe75f6401f6c5432988c620b863ad274 > Author: Matt Fleming <matt.fleming at intel.com> > Date: Tue Jul 16 15:15:54 2013 +0100 > > movebits: Add syslinux_memmap_find() > > Refactor the code for finding a suitable location for kernel > protected-mode and real-mode data. It's complicated enough that it > deserves to be separated into its own function. > > Signed-off-by: Matt Fleming <matt.fleming at intel.com>...

...t;> 8f470e7bfe75f6401f6c5432988c620b863ad274 is the first bad commit > >> commit 8f470e7bfe75f6401f6c5432988c620b863ad274 Author: Matt > >> Fleming <matt.fleming at intel.com> Date: Tue Jul 16 15:15:54 2013 > >> +0100 > >> > >> movebits: Add syslinux_memmap_find() > >> > >> Refactor the code for finding a suitable location for kernel > >> protected-mode and real-mode data. It's complicated enough that > >> it deserves to be separated into its own function. > >> > >> Signed-off-by: Matt Fleming &l...

Correct base's type to match its initialization from prot_mode_base and passage to syslinux_memmap_find(). Tested with extlinux. Signed-off-by: Scot Doyle <lkml14 at scotdoyle.com> --- com32/lib/syslinux/load_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/com32/lib/syslinux/load_linux.c b/com32/lib/syslinux/load_linux.c index 06ae2a9..ac73729 100644 --- a/com3...

...relocatable, just worry if it fits (it + * might not even be a Linux image, after all, and for !LOAD_HIGH + * we end up decompressing into a different location anyway), but + * if it is, make sure everything fits. + */ base = prot_mode_base; if (prot_mode_size && - syslinux_memmap_find(amap, &base, hdr.init_size, + syslinux_memmap_find(amap, &base, + hdr.relocatable_kernel ? + hdr.init_size : prot_mode_size, hdr.relocatable_kernel, hdr.kernel_alignment, - prot_mode_base, (addr_t)-1, - prot_mode_base, (addr_t)-1)) { + prot_mode_b...

Gene Cumm <gene.cumm at gmail.com> on Tue, 2013/10/22 06:35: > On Tue, Oct 22, 2013 at 5:41 AM, Christian Hesse <list at eworm.de> wrote: > > Hello everybody, > > > > iPXE builds an ISO image by default. (The build system has to be updated > > for new paths and to integrate ldlinux.c32, but that's not my problem.) > > > > With the binary

..., 6.02-pre6 does not. Struggled with git bisect, but finally succeeded: 8f470e7bfe75f6401f6c5432988c620b863ad274 is the first bad commit commit 8f470e7bfe75f6401f6c5432988c620b863ad274 Author: Matt Fleming <matt.fleming at intel.com> Date: Tue Jul 16 15:15:54 2013 +0100 movebits: Add syslinux_memmap_find() Refactor the code for finding a suitable location for kernel protected-mode and real-mode data. It's complicated enough that it deserves to be separated into its own function. Signed-off-by: Matt Fleming <matt.fleming at intel.com> :040000 040000 a7f3dc3f6ac34...

...d: > > > > 8f470e7bfe75f6401f6c5432988c620b863ad274 is the first bad commit > > commit 8f470e7bfe75f6401f6c5432988c620b863ad274 > > Author: Matt Fleming <matt.fleming at intel.com> > > Date: Tue Jul 16 15:15:54 2013 +0100 > > > > movebits: Add syslinux_memmap_find() > > > > Refactor the code for finding a suitable location for kernel > > protected-mode and real-mode data. It's complicated enough that it > > deserves to be separated into its own function. > > > > Signed-off-by: Matt Fleming &lt...

...y succeeded: >> >> 8f470e7bfe75f6401f6c5432988c620b863ad274 is the first bad commit >> commit 8f470e7bfe75f6401f6c5432988c620b863ad274 Author: Matt >> Fleming <matt.fleming at intel.com> Date: Tue Jul 16 15:15:54 2013 >> +0100 >> >> movebits: Add syslinux_memmap_find() >> >> Refactor the code for finding a suitable location for kernel >> protected-mode and real-mode data. It's complicated enough that >> it deserves to be separated into its own function. >> >> Signed-off-by: Matt Fleming <matt.fleming at intel.com&gt...

...a9..5cecef4 100644 --- a/com32/lib/syslinux/load_linux.c +++ b/com32/lib/syslinux/load_linux.c @@ -323,6 +323,7 @@ int bios_boot_linux(void *kernel_buf, size_t kernel_size, } whdr->code32_start += base - prot_mode_base; + prot_mode_base = base; /* Real mode code */ if (syslinux_memmap_find(amap, &real_mode_base, -- 2.3.0-rc2