search for: sys_un

On 4 November 2015 at 12:37, Pino Toscano <ptoscano@redhat.com> wrote: [...] > NACK, these OS-specific blocks are hard to maintain, and it makes no > sense to enclose POSIX headers in them. > > Can you please try the attached patch? I see Rich already pushed your > patch, but IMHO that should be reverted and this one should go... Happy to. However, these same header files

...es not provide SOCK_NONBLOCK, so either a) fix that in gnulib b) use the "nonblocking" gnulib module, using set_nonblocking_flag() instead of SOCK_NONBLOCK Also, sys/un.h is POSIX [1], so it can be included unconditionally. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_un.h.html Thanks, -- Pino Toscano

Hello, I'm attempting to create a Homebrew formula to get libguestfs to compile on Mac OS X. I've managed to achieve success with several monkey patches, but since Homebrew's policy is to contact maintainers about proper fixes in upstream, I would like to ask if there are any plans to fix these issues. I'm afraid I don't know C well enough to propose decent solutions myself.