search for: sys_lsetxattr

https://bugzilla.samba.org/show_bug.cgi?id=7110 Summary: Symlink fake-super data is silently lost when sys_lsetxattr fails with EPERM Product: rsync Version: 3.1.0 Platform: All OS/Version: All Status: NEW Severity: major Priority: P3 Component: core AssignedTo: wayned at samba.org ReportedBy: matt at mattmccutchen.ne...

...um > sys_llistxattr(Src/60-bsd-flags/.file-with-flags.CqNyUX, 0x2800400, > 1024); > fsreffrompath(Src/60-bsd-flags/.file-with-flags.CqNyUX, 0xbfffcc00); > PWD=/Volumes/Dst/80-rsync-test > name=.file-with-flags.CqNyUX > list lenght=21, list content: > com.apple.FinderInfo > sys_lsetxattr(Src/60-bsd-flags/.file-with-flags.CqNyUX, > com.apple.FinderInfo, 32); > value= > fsreffrompath(Src/60-bsd-flags/.file-with-flags.CqNyUX, 0xbfffca80); > PWD=/Volumes/Dst/80-rsync-test > name=.file-with-flags.CqNyUX > set modtime of Src/60-bsd-flags/.file-with-flags.CqNyUX to &...

...st are set The error seems to come from: source file generator.c in function recv_generator (line 1489) https://github.com/WayneD/rsync/blob/v3.2.7/generator.c#L1489 The error seems to be either: recv_generator (in generator.c) calling copy_xattrs when it should not or copy_xattrs (in xattrs.c) / sys_lsetxattr (in lib/sysxattrs.c) not checking the dry-run flag similarly to the functions in syscall.c do -- You are receiving this mail because: You are the QA Contact for the bug.

...sxattrs.c:85: for each function it appears in.) lib/sysxattrs.c: In function `sys_fgetxattr': lib/sysxattrs.c:90: warning: implicit declaration of function `extattr_get_fd' lib/sysxattrs.c:90: `EXTATTR_NAMESPACE_USER' undeclared (first use in this function) lib/sysxattrs.c: In function `sys_lsetxattr': lib/sysxattrs.c:95: warning: implicit declaration of function `extattr_set_link' lib/sysxattrs.c:95: `EXTATTR_NAMESPACE_USER' undeclared (first use in this function) lib/sysxattrs.c: In function `sys_lremovexattr': lib/sysxattrs.c:100: warning: implicit declaration of function `ex...

...the problem is more general. I think that -X beavhiour should be: - for every user preserve permissions - for root preserve permission and ownerships diff --git a/lib/sysxattrs.c b/lib/sysxattrs.c index d55ee0c..c9a38cd 100644 --- a/lib/sysxattrs.c +++ b/lib/sysxattrs.c @@ -191,7 +191,7 @@ int sys_lsetxattr(const char *path, const char *name, const { int attrfd; size_t bufpos; - mode_t mode = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP; + mode_t mode = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH; if ((attrfd = attropen(path, name, O_CREAT|O_TRUNC|O_WRONLY, mode)) &...

...attrfd=openat(filedes,name,O_RDONLY); + if (attrfd<0) { + errno = ENOATTR; + return -1; + } + + + for(bufpos=0;bufpos<size;) { + r=read(attrfd,value+bufpos,512); + if (r==0) break; + + if(r<0) { + return -errno; + } + bufpos+=r; + } + + +close(attrfd); +return (bufpos); + +} + +int sys_lsetxattr(const char *path, const char *name, const void *value, size_t size) +{ + int attrfd; + size_t bufpos,w; + + STRUCT_STAT fst; + + mode_t mode = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP; + + do_lstat(path,&fst); + + if(S_ISLNK(fst.st_mode)) { + errno=EPERM; + return(-1); + } + + attrfd = attropen...

This is a PoC patch for NFSv4/ZFS ACLs. The objective of the patch is that rsync --acls support NFSv4/ZFS ACLs without requiring a new command line option NFSv4 ACLs can't be represented using POSIX draft ACLs, if an NFSv4 ACL is present a separate POSIX draft ACL will not be present and there are new APIs to access NFSv4 ACLs. So we need to distinguish between NFSv4 ACLs and POSIX ACLs in

The security.evm extended attribute is fully owned by the Linux kernel and cannot be directly written from userspace. Therefore, we can always skip it. --- xattrs.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/xattrs.c b/xattrs.c index b105392..3b72e61 100644 --- a/xattrs.c +++ b/xattrs.c @@ -255,6 +255,9 @@ static int rsync_xal_get(const char *fname,

...rs.c 2008-01-28 22:31:11.000000000 -0600 @@ -128,7 +128,7 @@ } if (list_len >= 0) return list_len; - if (errno == ENOTSUP) + if (errno == ENOTSUP || errno == EPERM) return 0; if (errno == ERANGE) { list_len = sys_llistxattr(fname, NULL, 0); @@ -766,6 +766,8 @@ } if (sys_lsetxattr(fname, name, rxas[i].datum, rxas[i].datum_len) < 0) { + if (errno == EPERM) + return 0; rsyserr(FERROR_XFER, errno, "rsync_xal_set: lsetxattr(\"%s\",\"%s\") failed", fname, name); I plan to submit that, I just haven't had a spare moment....