search for: sync_fs

...e took the `wait' out of ext3_write_super(). And that worked OK too, because the VFS would later write back all the dirty data for us. But then an unrelated optimisation to the truncate path caused that to not work any more, and we were exposed. This patch adds a new super_block operation `sync_fs', whose mandate is to "sync the filesystem" for data-integrity purposes. ie: it is a synchronous writeout, whereas write_super is an asynchronous flush. It is a minimal fix. Really all the `sync' code in the VFS needs a rethink. It is _very_ ext2-centric, and needs to be redes...

There are three patches at http://www.zip.com.au/~akpm/linux/patches/2.4/2.4.20/ sync_fs.patch: Fix the ext3 data=journal data-loss-on-unmount bug sync_fs-fix.patch: Fix sync_fs.patch to not deadlock the fs when running `mount -o remount' against a heavily loaded filesystem. ext3-use-after-free.patch Fix a use-after-free bug which can cause memory corruption if the filesyste...

Greetings all, I have a question regarding the fsync data corruption bug that was introduced in 2.4.20 when using data=journal. I have patched the 2.4.20 kernel with the 3 sync patches available from zip.com.au, and I am wondering if with these patches the "bug" still exists: sync_fs.patch sync_fs-fix.patch sync_fs-fix-2.patch In addition the following two patches have also been applied: ext3-use-after-free.patch ext3-scheduling-storm.patch Also, from what I understand 'data=journal' would be beneficial in cases where data is being written to and read from disks...

Using kernel 2.4.20 with the following patches ext3-scheduling-storm.patch ext3-use-after-free.patch sync_fs-fix-2.patch sync_fs-fix.patch sync_fs.patch Note: this problem started happening before applying the patches I have a small partition for / since I don't have much there. Filesystem 1k-blocks Used Available Use% Mounted on /dev/sda6 303344 98934 188749...

Hello Andrew, I patched 2.4.20 with your patch found out on http://lwn.net/Articles/17447/ and I have a big problem with: once server is booted on 2.4.20 with your patch, when I want to reboot with /sbin/reboot, server makes a Segmentation fault and it crashs. I tested it on 50-60 servers and it is the same problem. I tested kernel 2.4.20 without your patch: no problem. # uname -a Linux XXXXXX

Hi Chris- Here''s a simpler version of the patch that drops the unrelated sync_fs stuff. thanks- sage The ''flushoncommit'' mount option forces any data dirtied by a write in a prior transaction to commit as part of the current commit. This makes the committed state a fully consistent view of the file system from the application''s perspective (i.e.,...

...--- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -462,7 +462,6 @@ static struct super_operations btrfs_super_ops = { .delete_inode = btrfs_delete_inode, .put_inode = btrfs_put_inode, .put_super = btrfs_put_super, - .read_inode = btrfs_read_locked_inode, .write_super = btrfs_write_super, .sync_fs = btrfs_sync_fs, .write_inode = btrfs_write_inode,

...per.c (revision 1426) +++ src/super.c (working copy) @@ -196,9 +196,7 @@ static struct super_operations ocfs_sops = { .statfs = ocfs_statfs, - .put_inode = ocfs_put_inode, .clear_inode = ocfs_clear_inode, - //put_inode = force_delete, .delete_inode = ocfs_delete_inode, .sync_fs = ocfs_sync_fs, .write_super = ocfs_write_super, Index: src/inode.c =================================================================== --- src/inode.c (revision 1426) +++ src/inode.c (working copy) @@ -521,26 +521,6 @@ return status; } -/* - * ocfs_put_inode() - * - */ -void ocfs_put_inode...

...aged(have next->next = next). And the invalidate_list will enter dead loop and cause very high cpu. So the only chance that we can solve this problem is flush dentry put in step 2 of generic_shutdown_super, that is sync_filesystem. And this patch is just adding dentry put flush process in ocfs2_sync_fs. Jan, Will dentry put in sync_fs have potential dead lock with quota lock? If yes, maybe we have to revert that commit which cause this umount problem and find other ways instead. Cc: Jan Kara <jack at suse.cz> Cc: Joel Becker <joel.becker at oracle.com> Cc: Mark Fasheh <mfasheh a...

...epage ends up accessing the inode after the page lock has been dropped (and hence at a point where it is possible for the inode to have been reclaimed.) Tested minimally (it builds and boots.) It makes ext3_journal_stop take an sb, not an inode, as its final parameter. It also sets sb->s_need_sync_fs, not sb->s_dirt, as setting s_dirt was only ever a workaround for the lack of a proper sync-fs mechanism. Btw, we clear s_need_sync_fs in sync_filesystems(). Don't we also need to do the same in fsync_super()? --Stephen

.../* We should only ever be called once! */ + BUG_ON(already_inited); + already_inited = true; + inode_init_once(&the_inode.inode); + return &the_inode.inode; +} + +/* Noop implementation of destroy_inode. */ +static void balloon_destroy_inode(struct inode *inode) +{ +} + +static int balloon_sync_fs(struct super_block *sb, int wait) +{ + return filemap_write_and_wait(the_inode.inode.i_mapping); +} + +static const struct super_operations balloonfs_ops = { + .alloc_inode = balloon_alloc_inode, + .destroy_inode = balloon_destroy_inode, + .sync_fs = balloon_sync_fs, +}; + +static const struct dent...

.../* We should only ever be called once! */ + BUG_ON(already_inited); + already_inited = true; + inode_init_once(&the_inode.inode); + return &the_inode.inode; +} + +/* Noop implementation of destroy_inode. */ +static void balloon_destroy_inode(struct inode *inode) +{ +} + +static int balloon_sync_fs(struct super_block *sb, int wait) +{ + return filemap_write_and_wait(the_inode.inode.i_mapping); +} + +static const struct super_operations balloonfs_ops = { + .alloc_inode = balloon_alloc_inode, + .destroy_inode = balloon_destroy_inode, + .sync_fs = balloon_sync_fs, +}; + +static const struct dent...

...e); > >> + return &the_inode.inode; > >> +} > >> + > >> +/* Noop implementation of destroy_inode. */ > >> +static void balloon_destroy_inode(struct inode *inode) > >> +{ > >> +} > >> + > >> +static int balloon_sync_fs(struct super_block *sb, int wait) > >> +{ > >> + return filemap_write_and_wait(the_inode.inode.i_mapping); > >> +} > >> + > >> +static const struct super_operations balloonfs_ops = { > >> + .alloc_inode = balloon_alloc_inode, > &gt...

...e); > >> + return &the_inode.inode; > >> +} > >> + > >> +/* Noop implementation of destroy_inode. */ > >> +static void balloon_destroy_inode(struct inode *inode) > >> +{ > >> +} > >> + > >> +static int balloon_sync_fs(struct super_block *sb, int wait) > >> +{ > >> + return filemap_write_and_wait(the_inode.inode.i_mapping); > >> +} > >> + > >> +static const struct super_operations balloonfs_ops = { > >> + .alloc_inode = balloon_alloc_inode, > &gt...

...n continues. The snapshot approach is nice because it provides rollback. If something goes wrong, we can cleanly go back to the most recent consistent commit. The performance is also very similar to what I was doing before (using the ''flushoncommit'' mount option and tiggering a sync_fs to flush data). The only difference is the old snapshots stick around for a bit longer before I delete them and the references get dropped. The first patch introduces a generic btrfs_commit_transaction_async() helper, which starts btrfs_commit_transaction asynchronously and returns either when th...

Please review the list of patches being applied to the ocfs2 1.4 tree. All patches list the mainline commit hash. Thanks Sunil

Hi, This is the second batch of Ocfs2 patches intended for the merge window. The 1st batch were sent out previously: http://lkml.org/lkml/2008/12/19/280 The bulk of this set is comprised of Jan Kara's patches to add quota support to Ocfs2. Many of the quota patches are to generic code, which I carried to make merging of the Ocfs2 support easier. All of the non-ocfs2 patches should have

Hi, The following patches comprise the bulk of Ocfs2 updates for the 2.6.30 merge window. Aside from larger, more involved fixes, we're adding the following features, which I will describe in the order their patches are mailed. Sunil's exported some more state to our debugfs files, and consolidated some other aspects of our debugfs infrastructure. This will further aid us in debugging