search for: switchtodatasection

..., however: ================================================================== --- SparcAsmPrinter.cpp (revision 720) +++ SparcAsmPrinter.cpp (working copy) @@ -263,7 +263,7 @@ // FALL THROUGH case GlobalValue::InternalLinkage: if (C->isNullValue()) - SwitchToDataSection(".bss", I); + SwitchToDataSection("\t.section\t\".bss\"", I); else SwitchToDataSection(".data", I); break; My question is: What is the "right" way to do this? I looked at the Mips code generator a l...

Chris Lattner wrote: > This is probably a difference between the sun and GNU assemblers. > There is no current sparc maintainer, so feel free to change it if one > way works better for you. Hi Chris, Here's the fix: Index: SparcRegisterInfo.cpp =================================================================== --- SparcRegisterInfo.cpp (revision 700) +++

On Jul 31, 2008, at 9:57 AM, Dale Johannesen wrote: > > On Jul 31, 2008, at 4:52 AMPDT, Richard Pennington wrote: > >> Any code that I generate for the Sparc fails at assembly time using a >> gas assembler built for the Sparc. >> >> I get code like the following from the code generator: >> >> save -96, %o6, %o6 >> >> and get a syntax

...out-of-line jump tables, you emit a ".text" directive to switch back to the text section. If the current section is not ".text", however, this will break. I believe you ought to use SwitchToTextSection instead. Earlier in that same method, I think you should also use SwitchToDataSection and EmitAlignment. But, again, rather than tweaking this code, I would prefer to find a way to use the existing LLVM code for this. Why did you change the default value for JumpTableDataSection? Jump tables really should not go into .data. That is a security hole. They should be read-o...

Evan: Sorry for the late follow up, I was out of town last week. Enclosed please find the updated patch including all your suggestions and a dejagnus test. Robert On Thu, Jun 11, 2009 at 2:27 PM, Evan Cheng <evan.cheng at apple.com> wrote: > > On Jun 8, 2009, at 2:42 PM, robert muth wrote: > > > On Sun, Jun 7, 2009 at 11:53 PM, Evan Cheng <evan.cheng at apple.com>

...jump tables, you emit > a ".text" directive to switch back to the text section. If the current > section is not ".text", however, this will break. I believe you ought to > use SwitchToTextSection instead. Earlier in that same method, I think you > should also use SwitchToDataSection and EmitAlignment. But, again, rather > than tweaking this code, I would prefer to find a way to use the existing > LLVM code for this. > I changed all of these as per your request. > > Why did you change the default value for JumpTableDataSection? Jump tables > really should...