search for: switcheroo

While working on a vga_switcheroo handler for Apple's Macbook Pros I stumbled upon a few bugs regarding the usage of nouveau with other switcheroo handlers and module unloading, here are my fixes for them. Andreas Heider (3): drm/nouveau: Initialize has_optimus drm/nouveau: Check dsm on switcheroo unregister drm/nouveau...

...M +0200, Thomas Zimmermann wrote: > Hi > > Am 12.08.24 um 12:18 schrieb Daniel Vetter: > > On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: > > > On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: > > > > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from > > > > their lastclose callbacks. Call it from drm_lastclose(), so that the > > > > driver functions can finally be removed. Only PCI devices with enabled > > > > switcheroo do the delayed switching. The call has no effect on other...

Hi Am 12.08.24 um 12:18 schrieb Daniel Vetter: > On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: >> On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: >>> Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from >>> their lastclose callbacks. Call it from drm_lastclose(), so that the >>> driver functions can finally be removed. Only PCI devices with enabled >>> switcheroo do the delayed switching. The call has no effect on other >>> hardware...

On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: > On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: > > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from > > their lastclose callbacks. Call it from drm_lastclose(), so that the > > driver functions can finally be removed. Only PCI devices with enabled > > switcheroo do the delayed switching. The call has no effect on other > > hardware. > >...

On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from > their lastclose callbacks. Call it from drm_lastclose(), so that the > driver functions can finally be removed. Only PCI devices with enabled > switcheroo do the delayed switching. The call has no effect on other > hardware. > > v2: > - move cha...

...age-not-present fault. 3.11 works just nice. It looks like I should add some debug, as there aren't event enqueuing/dequeueing debug flags, or as you suggest? http://quora.org/2013/dmesg.txt http://quora.org/2013/config (same as the Ubuntu mainline config) # echo OFF >/sys/kernel/debug/vgaswitcheroo/switch hda-intel 0000:01:00.1: Disabling via VGA-switcheroo hda-intel 0000:01:00.1: Cannot lock devices! VGA switcheroo: switched nouveau off nouveau [ DRM] suspending display... general protection fault: 0000 [#1] SMP Modules linked in: dm_crypt(F) parport_pc(F) snd_hda_codec_hdmi(F) ppdev(F) lib8...

https://bugs.freedesktop.org/show_bug.cgi?id=69180 Priority: medium Bug ID: 69180 Assignee: nouveau at lists.freedesktop.org Summary: Delays when using nouveau and switcheroo QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: a0vhv at t-online.de Hardware: x86 (IA32) Status: NEW Version: unspecified Component: Driver/nouveau...

After switcherooing to integrated and starting X, when X fails to start and causes a console switch, we get hit with a hanger (below). Fix by checking if we're already in D3. BUG: soft lockup - CPU#0 stuck for 22s! [Xorg:1703] [<ffffffffa037c538>] nv04_timer_read+0x28/0x70 [nouveau] [<ffffffffa037bf...

Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from their lastclose callbacks. Call it from drm_lastclose(), so that the driver functions can finally be removed. Only PCI devices with enabled switcheroo do the delayed switching. The call has no effect on other hardware. v2: - move change to drm_lastclose() (Sima) - upd...

https://bugs.freedesktop.org/show_bug.cgi?id=70895 Priority: medium Bug ID: 70895 Assignee: nouveau at lists.freedesktop.org Summary: BUG: soft lockup - CPU#0 stuck for 22s! [Xorg:1292] after disable descrete card with switcheroo QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: All Reporter: mszpak at wp.pl Hardware: Other Status: NEW Version: unspecified Component: Driver/nouveau Produc...

...changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c index ee637f1fe03d..ab4e11dc0b8a 100644 --- a/drivers/gpu/drm/nouveau/nouveau_vga.c +++ b/drivers/gpu/drm/nouveau/nouveau_vga.c @@ -58,8 +58,9 @@ static void nouveau_switcheroo_reprobe(struct pci_dev *pdev) { struct nouveau_drm *drm = pci_get_drvdata(pdev); + struct drm_device *dev = drm->dev; - drm_fb_helper_output_poll_changed(drm->dev); + drm_client_dev_hotplug(dev); } static bool -- 2.46.0

...n(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c > index ee637f1fe03d..ab4e11dc0b8a 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_vga.c > +++ b/drivers/gpu/drm/nouveau/nouveau_vga.c > @@ -58,8 +58,9 @@ static void > nouveau_switcheroo_reprobe(struct pci_dev *pdev) > { > struct nouveau_drm *drm = pci_get_drvdata(pdev); > + struct drm_device *dev = drm->dev; > > - drm_fb_helper_output_poll_changed(drm->dev); > + drm_client_dev_hotplug(dev); > } > > static bool

...rivers/gpu/drm/nouveau/nouveau_vga.c >> b/drivers/gpu/drm/nouveau/nouveau_vga.c >> index ee637f1fe03d..ab4e11dc0b8a 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_vga.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_vga.c >> @@ -58,8 +58,9 @@ static void >> ? nouveau_switcheroo_reprobe(struct pci_dev *pdev) >> ? { >> ????? struct nouveau_drm *drm = pci_get_drvdata(pdev); >> +??? struct drm_device *dev = drm->dev; >> ? -??? drm_fb_helper_output_poll_changed(drm->dev); >> +??? drm_client_dev_hotplug(dev); >> ? } >> ? ? static...

Op 24-07-13 09:13, Dave Airlie schreef: > After a full device powerdown via the optimus power switch, we seem > to lose the HDMI device completely on power on, this keep track of > whether we had a hdmi audio sub function device at power on, and > pokes a magic register to make it reappear after the optimus power > switch is thrown. > > This at least works on my NVC4 machine,

https://bugs.freedesktop.org/show_bug.cgi?id=61765 Priority: medium Bug ID: 61765 Assignee: nouveau at lists.freedesktop.org Summary: Regression: null pointer dereference on reboot after switcheroo use QA Contact: xorg-team at lists.x.org Severity: major Classification: Unclassified OS: Linux (All) Reporter: crrodriguez at opensuse.org Hardware: x86-64 (AMD64) Status: NEW Version: git Component: Driver/n...

..._optimus(void) { return nouveau_dsm_priv.optimus_detected; } -bool nouveau_is_v1_dsm(void) { - return nouveau_dsm_priv.dsm_detected; +bool nouveau_has_mux(void) { + return nouveau_dsm_priv.mux_detected; } #define NOUVEAU_DSM_HAS_MUX 0x1 #define NOUVEAU_DSM_HAS_OPT 0x2 #ifdef CONFIG_VGA_SWITCHEROO -static const char nouveau_dsm_muid[] = { +static const char nouveau_mux_dsm_muid[] = { 0xA0, 0xA0, 0x95, 0x9D, 0x60, 0x00, 0x48, 0x4D, 0xB3, 0x4D, 0x7E, 0x5F, 0xEA, 0x12, 0x9F, 0xD4, }; @@ -128,7 +128,7 @@ static int nouveau_check_optimus_dsm(acpi_handle handle) return result & 1 &&...

Does what it says on the label, a lot of these calls are already handled somewhere else and don't appear to be here for a legitimate reason anymore. Lyude Paul (3): drm/nouveau: Remove useless poll_enable() call in switcheroo_set_state() drm/nouveau: Remove useless poll_disable() call in switcheroo_set_state() drm/nouveau: Remove useless poll_enable() call in drm_load() drivers/gpu/drm/nouveau/nouveau_drm.c | 4 +--- drivers/gpu/drm/nouveau/nouveau_vga.c | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-)...

...44 --- a/drivers/gpu/drm/nouveau/nouveau_acpi.c +++ b/drivers/gpu/drm/nouveau/nouveau_acpi.c @@ -326,7 +326,7 @@ static bool nouveau_dsm_detect(void) nouveau_dsm_priv.dhandle = dhandle; acpi_get_name(nouveau_dsm_priv.dhandle, ACPI_FULL_PATHNAME, &buffer); - printk(KERN_INFO "VGA switcheroo: detected Optimus DSM method %s handle\n", + pr_info("VGA switcheroo: detected Optimus DSM method %s handle\n", acpi_method_name); if (has_power_resources) pr_info("nouveau: detected PR support, will not use DSM\n"); @@ -338,7 +338,7 @@ static bool nouveau_dsm_d...

Next version of https://patchwork.freedesktop.org/series/48131/ Only changes are new A-Bs and R-Bs Lyude Paul (3): drm/nouveau: Remove useless poll_enable() call in switcheroo_set_state() drm/nouveau: Remove useless poll_disable() call in switcheroo_set_state() drm/nouveau: Remove useless poll_enable() call in drm_load() drivers/gpu/drm/nouveau/nouveau_drm.c | 4 +--- drivers/gpu/drm/nouveau/nouveau_vga.c | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-)...

...ouveau_drm(dev); + struct nouveau_device *device = nv_device(drm->device); + uint32_t val; + + if (!drm->hdmi_device) + return; + + /* write magic value into magic place */ + val = nv_rd32(device, 0x88488); + val |= (1 << 25); + nv_wr32(device, 0x88488, val); +} + +static void nouveau_switcheroo_set_state(struct pci_dev *pdev, enum vga_switcheroo_state state) { @@ -37,6 +53,7 @@ nouveau_switcheroo_set_state(struct pci_dev *pdev, dev->switch_power_state = DRM_SWITCH_POWER_CHANGING; nouveau_pmops_resume(&pdev->dev); drm_kms_helper_poll_enable(dev); + nouveau_ree...