search for: swfdec_urldecode_on

...eing passed in the value of a variable and other things. Pages which where broken included the flash at the upper right corner of http://www.kanal5.se and the presentation of houses for sale at http://www.svenskfast.se. Solution: use swfdec_as_object_decode and kill off swfdec_movie_set_variables, swfdec_urldecode_one_string, swfdec_urldecode_one and the flawed testcase in test/various/urlencode.c. --- Since the segfault where just fixed in git, I've now tested this patch which works perfectly as far as I can see. diffstat: b/libswfdec/swfdec_loader.c | 106 ---------------------------------...

...of a variable and other things. Pages which where broken included the flash at the upper right corner of http://www.kanal5.se and the presentation of houses for sale at http://www.svenskfast.se. Solution: use swfdec_as_object_decode and kill off swfdec_movie_set_variables, swfdec_urldecode_one_string, swfdec_urldecode_one and the flawed testcase in test/various/urlencode.c. diff --git a/libswfdec/swfdec_loader.c b/libswfdec/swfdec_loader.c index 7595c4e..f2c16f6 100644 --- a/libswfdec/swfdec_loader.c +++ b/libswfdec/swfdec_loader.c @@ -608,54 +608,6 @@ swfdec_urlencode_append_strin...

...== '\0') { + ERROR ("string only contains %u properties, but should contain %u", i, test->n_props); + break; + } + if (i > 0) { + if (*s != '&') { + ERROR ("properties not delimited by &"); + } + s++; + } + if (!swfdec_urldecode_one (s, &name, &value, &s)) { + ERROR ("could not decode property %u", i); + continue; + } + if (!g_str_equal (name, test->names[i])) { + ERROR ("names don't match: is %s, should be %s", name, test->names[i]); + } + if (!g_str_equal...

libswfdec/swfdec_movie.c | 3 +++ 1 files changed, 3 insertions(+) New commits: diff-tree 774031e0bb34710e971ab143aac62300907486d3 (from a6c380467a9cb20fd2d151d74603f1de5637cabf) Author: Benjamin Otte <otte at gnome.org> Date: Wed Jun 13 16:34:43 2007 +0200 fix matrix calculation - 3 lines got lost in the reorg diff --git a/libswfdec/swfdec_movie.c b/libswfdec/swfdec_movie.c

...(SWFDEC_IS_SCRIPTABLE (script)); - g_return_if_fail (variables != NULL); - - SWFDEC_DEBUG ("setting variables on %p: %s", script, variables); - object = swfdec_scriptable_get_object (script); - while (TRUE) { - char *name, *value; - JSString *string; - jsval val; - - if (!swfdec_urldecode_one (variables, &name, &value, &variables)) { - SWFDEC_WARNING ("variables invalid at \"%s\"", variables); - break; - } - if (*variables != '\0' && *variables != '&') { - SWFDEC_WARNING ("variables not delimited with...

...pt, const char *variables) +{ + JSObject *object; + + g_return_if_fail (SWFDEC_IS_SCRIPTABLE (script)); + g_return_if_fail (variables != NULL); + + object = swfdec_scriptable_get_object (script); + while (*variables) { + char *name, *value; + JSString *string; + jsval val; + + if (!swfdec_urldecode_one (variables, &name, &value, &variables)) { + SWFDEC_WARNING ("variables invalid at \"%s\"", variables); + break; + } + if (*variables != '&' && *variables != '\0') { + SWFDEC_WARNING ("variables not delimited with...

...void swfdec_loader_set_target (SwfdecLoader * loader, SwfdecLoaderTarget * target); void swfdec_loader_set_data_type (SwfdecLoader * loader, SwfdecLoaderDataType type); -void swfdec_loader_error_locked (SwfdecLoader * loader, - const char * error); gboolean swfdec_urldecode_one (const char * string, char ** name, diff --git a/libswfdec/swfdec_loadertarget.c b/libswfdec/swfdec_loadertarget.c index f702f99..aa939b7 100644 --- a/libswfdec/swfdec_loadertarget.c +++ b/libswfdec/swfdec_loadertarget.c @@ -83,8 +83,7 @@ swfdec_loader_target_parse (SwfdecLoader g_r...

...SwfdecLoader * swfdec_loader_load (Swf void swfdec_loader_parse (SwfdecLoader * loader); void swfdec_loader_set_target (SwfdecLoader * loader, SwfdecLoaderTarget * target); +void swfdec_loader_error_locked (SwfdecLoader * loader, + const char * error); gboolean swfdec_urldecode_one (const char * string, char ** name, diff --git a/libswfdec/swfdec_loadertarget.c b/libswfdec/swfdec_loadertarget.c index 218a156..8fd629d 100644 --- a/libswfdec/swfdec_loadertarget.c +++ b/libswfdec/swfdec_loadertarget.c @@ -22,6 +22,7 @@ #endif #include "swfdec_loadertarget.h...

...istener->n_entries + 16; mem = g_try_realloc (listener->entries, sizeof (SwfdecListenerEntry) * new_len); diff --git a/libswfdec/swfdec_loader.c b/libswfdec/swfdec_loader.c index 2416c61..aa41e59 100644 --- a/libswfdec/swfdec_loader.c +++ b/libswfdec/swfdec_loader.c @@ -694,7 +694,7 @@ swfdec_urldecode_one_string (const char * to the given @str **/ void -swfdec_string_append_urlencoded (GString *str, char *name, char *value) +swfdec_string_append_urlencoded (GString *str, const char *name, const char *value) { g_return_if_fail (str != NULL); g_return_if_fail (name != NULL); diff --git a...

...return_if_fail (SWFDEC_IS_MOVIE (movie)); + g_return_if_fail (variables != NULL); + + as = SWFDEC_AS_OBJECT (movie); + SWFDEC_DEBUG ("setting variables on %p: %s", movie, variables); + while (TRUE) { + char *name, *value; + const char *asname; + SwfdecAsValue val; + + if (!swfdec_urldecode_one (variables, &name, &value, &variables)) { + SWFDEC_WARNING ("variables invalid at \"%s\"", variables); + break; + } + if (*variables != '\0' && *variables != '&') { + SWFDEC_WARNING ("variables not delimited with...