search for: swfdec_fixm

...end - text->input->str); + p - text->input->str, end - p); paragraphs = g_array_append_val (paragraphs, paragraph); p = end; commit be21f00c2fb50f5e6dd6d120e035006644f6e643 Author: Pekka Lampila <pekka.lampila at iki.fi> Date: Mon Oct 29 20:21:58 2007 +0200 Add SWFDEC_FIXME about sound envelopes diff --git a/libswfdec/swfdec_sound.c b/libswfdec/swfdec_sound.c index 64e22a3..2f3dec0 100644 --- a/libswfdec/swfdec_sound.c +++ b/libswfdec/swfdec_sound.c @@ -351,6 +351,7 @@ swfdec_sound_parse_chunk (SwfdecSwfDecoder *s, SwfdecBits *b, int id) chunk->loop_count =...

...ope); - SWFDEC_LOG (" envelope = %u { %u, %u }", chunk->envelope[i].offset, (guint) chunk->envelope[i].volume[0], (guint) chunk->envelope[i].volume[1]); - /* FIXME: check that mono sound gets averaged and then do this here? */ - } - - if (n_envelopes > 0) { - SWFDEC_FIXME ("Support for sound envelopes missing"); - chunk->n_envelopes = envelopes->len; - chunk->envelope = (SwfdecSoundEnvelope *)g_array_free (envelopes, FALSE); } return chunk; commit de501b9c73e5ee6de3ea742a4f43e7d37935eec5 Author: Pekka Lampila <pekka.lampila at ik...

...char *ascii; - ascii = g_convert (s, -1, "LATIN1", "UTF8", NULL, NULL, NULL); + ascii = g_convert (s, -1, "LATIN1", "UTF-8", NULL, NULL, NULL); if (ascii == NULL) { /* This can happen if a Flash 5 movie gets loaded into a Flash 7 movie */ SWFDEC_FIXME ("Someone threw unconvertible text %s at Flash <= 5", s); @@ -1998,7 +1998,7 @@ swfdec_action_ascii_to_char_5 (SwfdecAsC s[0] = ((guint) swfdec_as_value_to_integer (cx, val)) % 256; s[1] = 0; - utf8 = g_convert (s, -1, "UTF8", "LATIN1", NULL, NULL, NULL);...

...C_SWF_DECODER (movie->swf->decoder)->version == 6) + return; + } else if (SWFDEC_IS_SPRITE (graphic) || + SWFDEC_IS_BUTTON (graphic) || + SWFDEC_IS_EDIT_TEXT (graphic)) { + SWFDEC_INFO ("can't replace with scriptable objects"); + return; + } else { + SWFDEC_FIXME ("Can we replace with %s objects?", G_OBJECT_TYPE_NAME (graphic)); + return; + } + swfdec_movie_invalidate (movie); + g_object_unref (gmovie->graphic); + gmovie->graphic = g_object_ref (graphic); + swfdec_movie_queue_update (movie, SWFDEC_MOVIE_INVALID_EXTENTS); +} + +stati...

...frame_push_block (frame, try_data->start + try_data->catch_size, + try_data->start + try_data->catch_size + try_data->finally_size, + swfdec_action_try_end_finally, error, g_free); + + cx->throwing = FALSE; + SWFDEC_AS_VALUE_SET_UNDEFINED (&cx->throw_value); } - SWFDEC_FIXME ("Throw action not implemented"); + swfdec_action_try_free_data (try_data); +} + +static void +swfdec_action_try_end_try (SwfdecAsFrame *frame, gpointer data) +{ + TryData *try_data = data; + SwfdecAsContext *cx; + + g_return_if_fail (SWFDEC_IS_AS_FRAME (frame)); + g_return_if_fail...

...); - } else if (tag->name_length == 1 && !g_strncasecmp (tag->name, "u", 1)) { - swfdec_as_object_set_variable (object, SWFDEC_AS_STR_underline, &val); - } else if (tag->name_length == 3 && !g_strncasecmp (tag->name, "img", 3)) { - SWFDEC_FIXME ("IMG tag support for TextField's HTML input missing"); + if (tag->format != NULL) { + object = SWFDEC_AS_OBJECT (tag->format); + SWFDEC_AS_VALUE_SET_BOOLEAN (&val, TRUE); + + if (tag->name_length == 2 && !g_strncasecmp (tag->name, "li&q...

...ext_field_movie_as.c @@ -604,10 +604,10 @@ swfdec_text_field_movie_set_embedFonts (SwfdecAsContext *cx, swfdec_as_value_to_number (cx, &argv[0]); - text->text->embed_fonts = value; - - if (text->text->embed_fonts) + if (!text->text->embed_fonts && value) SWFDEC_FIXME ("Using embed fonts in TextField not supported"); + + text->text->embed_fonts = value; } static void @@ -619,8 +619,7 @@ swfdec_text_field_movie_get_textColor (SwfdecAsContext *cx, SWFDEC_AS_CHECK (SWFDEC_TYPE_TEXT_FIELD_MOVIE, &text, ""); - swfdec_as_obj...

...ct, &other_rect)); + } else if (argc >= 2) { + SwfdecRect movie_rect; + double x, y; + + x = swfdec_as_value_to_number (cx, &argv[0]); + y = swfdec_as_value_to_number (cx, &argv[1]); + + if (argc >= 3) { + if (swfdec_as_value_to_boolean (cx, &argv[2])) { + SWFDEC_FIXME ("hitTest's shapeFlag parameter not supported"); + // just continue... + } + } + + swfdec_movie_update (movie); + movie_rect = movie->original_extents; + while (movie->parent) { + swfdec_rect_transform (&movie_rect, &movie_rect, &movie->matr...

...4 --- a/libswfdec/swfdec_text_field.c +++ b/libswfdec/swfdec_text_field.c @@ -337,6 +337,8 @@ tag_func_define_edit_text (SwfdecSwfDeco reserved = swfdec_bits_getbit (b); text->html = swfdec_bits_getbit (b); text->embed_fonts = swfdec_bits_getbit (b); + if (text->embed_fonts) + SWFDEC_FIXME ("Using embed fonts in TextField is not supported"); if (has_font) { SwfdecCharacter *font; diff --git a/libswfdec/swfdec_text_field_movie.c b/libswfdec/swfdec_text_field_movie.c index 2827961..21e9a79 100644 --- a/libswfdec/swfdec_text_field_movie.c +++ b/libswfdec/swfdec_text...

...cAsValue *retval) { guint flags[2]; /* flags and mask - array so we can pass it as data pointer */ SwfdecAsObject *obj; - if (object->context->version < 6) { - SWFDEC_WARNING ("ASSetPropFlags needs some limiteations for Flash 5"); + if (cx->version < 6) { + SWFDEC_FIXME ("ASSetPropFlags needs some limitations for Flash 5"); } if (!SWFDEC_AS_VALUE_IS_OBJECT (&argv[0])) return; obj = SWFDEC_AS_VALUE_GET_OBJECT (&argv[0]); - flags[0] = swfdec_as_value_to_integer (object->context, &argv[2]); + flags[0] = swfdec_as_value_to_int...

...amp;argv[0]) * SWFDEC_TWIPS_SCALE_FACTOR; + y = swfdec_as_value_to_number (cx, &argv[1]) * SWFDEC_TWIPS_SCALE_FACTOR; + shape = (argc >= 3 && swfdec_as_value_to_boolean (cx, &argv[2])); - if (argc >= 3) { - if (swfdec_as_value_to_boolean (cx, &argv[2])) { - SWFDEC_FIXME ("hitTest's shapeFlag parameter not supported"); - // just continue... - } - } + swfdec_movie_global_to_local (movie, &x, &y); - swfdec_movie_update (movie); - movie_rect = movie->original_extents; - while (movie->parent) { - swfdec_rect_trans...

...*sprite; + SwfdecMovie *movie; + + if (SWFDEC_AS_VALUE_IS_STRING (val)) { + const char *name = SWFDEC_AS_VALUE_GET_STRING (val); + + swfdec_as_context_eval (cx, NULL, name, val); + } + if (SWFDEC_AS_VALUE_IS_OBJECT (val)) { + sprite = SWFDEC_AS_VALUE_GET_OBJECT (val); + } else { + SWFDEC_FIXME ("unknown type in RemoveSprite"); + return; + } + if (!SWFDEC_IS_MOVIE (sprite)) { + SWFDEC_FIXME ("cannot remove non movieclip objects"); + return; + } + movie = SWFDEC_MOVIE (sprite); + if (swfdec_depth_classify (movie->depth) == SWFDEC_DEPTH_CLASS_DYNAMIC) {...

...function.c @@ -164,10 +164,10 @@ swfdec_as_function_call (SwfdecAsFunction *function, SwfdecAsObject *thisp, guin if (frame == NULL) return; if (thisp != NULL) { - swfdec_as_super_new (frame, thisp, FALSE); + swfdec_as_super_new (frame, thisp, thisp->prototype); } else { SWFDEC_FIXME ("does the super object really reference the function when thisp is NULL?"); - swfdec_as_super_new (frame, SWFDEC_AS_OBJECT (function), FALSE); + swfdec_as_super_new (frame, SWFDEC_AS_OBJECT (function), SWFDEC_AS_OBJECT (function)->prototype); } swfdec_as_frame_preload (fr...

...c_as_native_function_new (cx, native_funcs[i].name, - native_funcs[i].func, 0); - if (func) - SWFDEC_AS_VALUE_SET_OBJECT (rval, SWFDEC_AS_OBJECT (func)); + func = swfdec_get_asnative (cx, x, y); + if (func) { + SWFDEC_AS_VALUE_SET_OBJECT (rval, SWFDEC_AS_OBJECT (func)); + } else { + SWFDEC_FIXME ("ASnative for %u %u missing", x, y); + } +} + +SWFDEC_AS_NATIVE (4, 1, ASSetNativeAccessor) +void +ASSetNativeAccessor (SwfdecAsContext *cx, SwfdecAsObject *object, + guint argc, SwfdecAsValue *argv, SwfdecAsValue *rval) +{ + SwfdecAsFunction *get, *set; + SwfdecAsObject *target;...

...return FALSE; + } + /* a colon at the beginning may not be the only separator */ + if (path[0] == ':') { + if (strpbrk (path + 1, ".:/") == NULL) + return FALSE; + else + path++; + } + + movie = cx->frame->target; + if (!SWFDEC_IS_MOVIE (movie)) { + SWFDEC_FIXME ("target is not a movie"); + } else { + if (path[0] == '/') { + /* if path starts with a slash, start from the root movie */ + while (SWFDEC_MOVIE (movie)->parent) + movie = SWFDEC_AS_OBJECT (SWFDEC_MOVIE (movie)->parent); + path++; + was_slash = TRU...

...e6430a3 100644 --- a/libswfdec/swfdec_sprite_movie.c +++ b/libswfdec/swfdec_sprite_movie.c @@ -254,7 +254,7 @@ swfdec_sprite_movie_perform_place (Swfde graphic = swfdec_swf_decoder_get_character (SWFDEC_SWF_DECODER (mov->swf->decoder), id); if (!SWFDEC_IS_GRAPHIC (graphic)) { SWFDEC_FIXME ("character %u is not a graphic (does it even exist?), aborting", id); - return TRUE; + return FALSE; } cur = swfdec_movie_new (player, depth, mov, graphic, name); swfdec_movie_set_static_properties (cur, has_transform ? &transform : NULL, diff-tree 0ca7a97f...

...unescape_5 (SwfdecAsContext *cx, const char *msg) #define APPEND(chr) G_STMT_START{ \ g_byte_array_append (array, (guchar *) chr, 1); \ }G_STMT_END - array = g_byte_array_new (); in = s = g_convert (msg, -1, "LATIN1", "UTF-8", NULL, NULL, NULL); if (s == NULL) { SWFDEC_FIXME ("%s can not be converted to utf8 - is this Flash 5 or what?", msg); return NULL; } + array = g_byte_array_new (); while (*s != 0) { if (decoding) { decoding++; @@ -673,8 +673,10 @@ swfdec_as_string_unescape_5 (SwfdecAsContext *cx, const char *msg) s++; }...

...is, as the source is just used for explaining what the test does. The current tests don't all include source. If no source code is available, a test file explaining it or trace output that does the same is perfectly fine, too. - Does not test something that is not implemented. So when you get a SWFDEC_FIXME debug output, it's usually not worthwhile writing a test. > - Are testcases shared between swfdec and gnash? > No, Swfdec and Gnash have very different ideas on how to do a test suite. Gnash can run the Swfdec test suite. > - I mostly use the MPL-licensed Flex 3 SDK to compile my .a...

...wfdec/swfdec_as_array.c b/libswfdec/swfdec_as_array.c index 273b083..ff446d8 100644 --- a/libswfdec/swfdec_as_array.c +++ b/libswfdec/swfdec_as_array.c @@ -943,6 +943,11 @@ swfdec_as_array_sort (SwfdecAsContext *c ForeachSortData fdata; guint pos; + if (!SWFDEC_IS_AS_ARRAY (object)) { + SWFDEC_FIXME ("Array.sort should work on non-array objects too"); + return; + } + fdata.length = swfdec_as_array_get_length (object); fdata.order_size = MIN ((gint32)g_hash_table_size (object->properties) + 1, fdata.length + 1); diff --git a/libswfdec/swfdec_as_string.c b/libswfdec/...

...terpret.c index 619d004..b3cce36 100644 --- a/libswfdec/swfdec_as_interpret.c +++ b/libswfdec/swfdec_as_interpret.c @@ -2416,14 +2416,22 @@ swfdec_action_logical (SwfdecAsContext *cx, guint action, const guint8 *data, gu SwfdecAsValue *val; gboolean l, r; - if (cx->version <= 4) - SWFDEC_FIXME ("Or and And actions work incorrectly in version 4"); - - l = swfdec_as_value_to_boolean (cx, swfdec_as_stack_peek (cx, 1)); - val = swfdec_as_stack_peek (cx, 2); - r = swfdec_as_value_to_boolean (cx, val); + if (cx->version <= 4) { + l = (swfdec_as_value_to_number (cx, swfd...