search for: swab_extents

...he underlying plugin ever reports - * values not aligned to 2 bytes, it is complicated to adjust that correctly. - * In the short term, we punt by disabling extents. - */ +/* Extents. */ static int -swab_can_extents (struct nbdkit_next_ops *next_ops, void *nxdata, - void *handle) +swab_extents (struct nbdkit_next_ops *next_ops, void *nxdata, + void *handle, uint32_t count, uint64_t offset, uint32_t flags, + struct nbdkit_extents *extents, int *err) { - return 0; + if (!is_aligned (count, offset)) return -1; + return nbdkit_extents_aligned (next_ops, nxdata,...

...* values not aligned to 2 bytes, it is complicated to adjust that correctly. > - * In the short term, we punt by disabling extents. > - */ > +/* Extents. */ > static int > -swab_can_extents (struct nbdkit_next_ops *next_ops, void *nxdata, > - void *handle) > +swab_extents (struct nbdkit_next_ops *next_ops, void *nxdata, > + void *handle, uint32_t count, uint64_t offset, uint32_t flags, > + struct nbdkit_extents *extents, int *err) > { > - return 0; > + if (!is_aligned (count, offset)) return -1; > + return nbdkit_exten...

Ultimately, both the blocksize and swab filters want to return aligned extents to the client. I'm posting this as a snapshot of my work in progress on how I plan to get there (it's not quite working yet, but I'm done for today and wanted to at least document my ideas). I might also add a convenience function for nbdkit_extents_offset, since we have a number of filters that repeat the