search for: supermin_path

This is the libguestfs companion patch to: https://www.redhat.com/archives/libguestfs/2013-September/msg00045.html Rich.

..._old_style_appliance (guestfs_h *g, const char *path, void *data); static int contains_fixed_appliance (guestfs_h *g, const char *path, void *data); static int contains_supermin_appliance (guestfs_h *g, const char *path, void *data); -static int build_supermin_appliance (guestfs_h *g, const char *supermin_path, uid_t uid, char **kernel, char **initrd, char **appliance); +static int build_supermin_appliance (guestfs_h *g, const char *supermin_path, char **kernel, char **initrd, char **appliance); static int run_supermin_build (guestfs_h *g, const char *lockfile, const char *appliancedir, const char *supe...

.../appliance.c > index f12918573..06ee06f71 100644 > --- a/lib/appliance.c > +++ b/lib/appliance.c > @@ -137,16 +137,6 @@ build_appliance (guestfs_h *g, > CLEANUP_FREE char *path = NULL; > > /* Step (1). */ > - r = find_path (g, contains_supermin_appliance, NULL, &supermin_path); > - if (r == -1) > - return -1; > - > - if (r == 1) > - /* Step (2): build supermin appliance. */ > - return build_supermin_appliance (g, supermin_path, > - kernel, initrd, appliance); > - > - /* Step (3). */ > r = f...

Hi, this is a prototype of something I've around for some time. Basically it is about adding new appliances in addition to the main one currently used and kept up-to-date automatically: this way it is possible to create new appliances with extra packages, to be used in specific contexts (like virt-rescue, with more network/recovery tools) without filling the main appliance. It's still

...<sys/stat.h> #include <sys/select.h> +#include <sys/wait.h> #include <utime.h> #ifdef HAVE_SYS_TYPES_H @@ -49,6 +50,7 @@ static int contains_ordinary_appliance (guestfs_h *g, const char *path, void *da static char *calculate_supermin_checksum (guestfs_h *g, const char *supermin_path); static int check_for_cached_appliance (guestfs_h *g, const char *supermin_path, const char *checksum, char **kernel, char **initrd, char **appliance); static int build_supermin_appliance (guestfs_h *g, const char *supermin_path, const char *checksum, char **kernel, char **initrd, char **applian...

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

...se and use it. If the fixed appliance exists > >there, then it would never check /usr/lib64/guestfs. > > It's a bit wrong, the first step is search supermin.d in all specified > directories: > /* Step (1). */ > r = find_path (g, contains_supermin_appliance, NULL, &supermin_path); > if (r == -1) > return -1; > > if (r == 1) > /* Step (2): build supermin appliance. */ > return build_supermin_appliance (g, supermin_path, > kernel, initrd, appliance); OK, I see, that is indeed a bug. Can you suggest...

This preliminary patch series adds a libvirt backend to libguestfs. It's for review only because although it launches the guest OK, there are some missing features that need to be implemented. The meat of the patch is in part 4/4. To save you the trouble of interpreting libxml2 fragments, an example of the generated XML and the corresponding qemu command line are attached below. Note the

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and

...(g, "begin building supermin appliance"); /* Build the appliance if it needs to be built. */ - if (g->verbose) - guestfs_int_print_timestamped_message (g, "run supermin"); + debug (g, "run supermin"); if (run_supermin_build (g, lockfile, appliancedir, supermin_path) == -1) return -1; - if (g->verbose) - guestfs_int_print_timestamped_message (g, "finished building supermin appliance"); + debug (g, "finished building supermin appliance"); /* Return the appliance filenames. */ *kernel = safe_asprintf (g, "%s/kernel...

https://bugzilla.redhat.com/show_bug.cgi?id=769680

Various changes/fixes to use smaller stack frames. Rich.

...*g, const char *path, void *data) static int contains_supermin_appliance (guestfs_h *g, const char *path, void *data) { - return dir_contains_files (path, "supermin.d", NULL); + return dir_contains_files (g, path, "supermin.d", NULL); } /* Build supermin appliance from supermin_path to $TMPDIR/.guestfs-$UID. @@ -201,19 +201,12 @@ build_supermin_appliance (guestfs_h *g, char **appliance) { CLEANUP_FREE char *tmpdir = guestfs_get_cachedir (g); + CLEANUP_FREE char *cachedir = NULL, *lockfile = NULL, *appliancedir = NULL; struct stat statbuf; -...

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

Lots of changes since v2, too much to remember or summarize. Please ignore patch 11/11, it's just for my testing. Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2016-March/thread.html#00157 Not running the 'hwclock' command reduces boot times considerably. However I'm not sure if it is safe. See the question I posted on qemu-devel: http://thread.gmane.org/gmane.comp.emulators.qemu/402194 At the moment, about 50% of the time is consumed by SeaBIOS. Of this, about ⅓rd is SGABIOS