search for: sum_sqr_shift_fix

...Valin" <jmvalin at jmvalin.ca> wrote: >Hi Marcello, > >It turns out that the problem has a much simpler explanation. As far as >I can tell, it's actually a bug in silk_sum_sqr_shift() and this trivial >patch appears to fix the problem: >http://jmvalin.ca/misc_stuff/sum_sqr_shift_fix.patch > >It would still require some testing to check that the fix doesn't have >any bad side effect. Let me know how well the fix works for you. Again, >thanks for investigating this. > >Cheers, > > Jean-Marc > >On 13/06/14 12:28 PM, Marcello Caramma (mcaramma) wr...

Hi Marcello, It turns out that the problem has a much simpler explanation. As far as I can tell, it's actually a bug in silk_sum_sqr_shift() and this trivial patch appears to fix the problem: http://jmvalin.ca/misc_stuff/sum_sqr_shift_fix.patch It would still require some testing to check that the fix doesn't have any bad side effect. Let me know how well the fix works for you. Again, thanks for investigating this. Cheers, Jean-Marc On 13/06/14 12:28 PM, Marcello Caramma (mcaramma) wrote: > Hi Jean Marc, > > pleas...

Hi Jean Marc, please find attached the audio file (mono 16khz). I shortened it to about 10 seconds. I also add 2 patches that worked for me. Further info that might help: - The problem seems to be related to silk_burg_modified not reaching the maximum gain, so the actual filter order is 16 rather than 2 (which is what would be expected with a sine wave). - The problem seems to happen when

....ca> wrote: > >> Hi Marcello, >> >> It turns out that the problem has a much simpler explanation. As far as >> I can tell, it's actually a bug in silk_sum_sqr_shift() and this trivial >> patch appears to fix the problem: >> http://jmvalin.ca/misc_stuff/sum_sqr_shift_fix.patch >> >> It would still require some testing to check that the fix doesn't have >> any bad side effect. Let me know how well the fix works for you. Again, >> thanks for investigating this. >> >> Cheers, >> >> Jean-Marc >> >> On 13/...

...> Hi Marcello, > >> > >> It turns out that the problem has a much simpler explanation. As far as > >> I can tell, it's actually a bug in silk_sum_sqr_shift() and this trivial > >> patch appears to fix the problem: > >> http://jmvalin.ca/misc_stuff/sum_sqr_shift_fix.patch > >> > >> It would still require some testing to check that the fix doesn't have > >> any bad side effect. Let me know how well the fix works for you. Again, > >> thanks for investigating this. > >> > >> Cheers, > >> > >...