search for: subscription_manag

...add basic subscription-manager operations builder/Makefile.am | 1 + builder/virt-builder.pod | 47 ++++++++++++++++++ customize/Makefile.am | 2 + customize/customize_run.ml | 34 +++++++++++++ customize/password.ml | 8 +-- customize/subscription_manager.ml | 53 ++++++++++++++++++++ customize/subscription_manager.mli | 34 +++++++++++++ generator/customize.ml | 99 ++++++++++++++++++++++++++++++++++++-- mllib/common_utils.ml | 6 +++ mllib/common_utils.mli | 4 ++ po/POTFILES-ml | 1 +...

...sts using subscription-manager, so it is possible to e.g. install software on them. --- builder/Makefile.am | 1 + builder/virt-builder.pod | 47 ++++++++++++++++++ customize/Makefile.am | 2 + customize/customize_run.ml | 34 +++++++++++++ customize/subscription_manager.ml | 53 ++++++++++++++++++++ customize/subscription_manager.mli | 34 +++++++++++++ generator/customize.ml | 99 ++++++++++++++++++++++++++++++++++++-- po/POTFILES-ml | 1 + sysprep/Makefile.am | 1 + 9 files changed, 269 insertions(+), 3 deletio...

...builder/Makefile.am @@ -155,6 +155,7 @@ BOBJECTS = \ $(top_builddir)/customize/perl_edit.cmo \ $(top_builddir)/customize/crypt.cmo \ $(top_builddir)/customize/password.cmo \ + $(top_builddir)/customize/SELinux_relabel.cmo \ $(top_builddir)/customize/ssh_key.cmo \ $(top_builddir)/customize/subscription_manager.cmo \ $(top_builddir)/customize/customize_cmdline.cmo \ diff --git a/builder/virt-builder.pod b/builder/virt-builder.pod index 91c1114..29a67a9 100644 --- a/builder/virt-builder.pod +++ b/builder/virt-builder.pod @@ -1756,20 +1756,21 @@ two possible strategies it can use to ensure correct label...

...%s") (String.concat " " pkgs); let cmd = guest_install_command pkgs in - do_run ~display:cmd cmd + do_run ~display:cmd ~warn_failed_no_network:true cmd | `Link (target, links) -> List.iter ( @@ -300,11 +305,11 @@ exec >>%s 2>&1 | Subscription_manager.PoolAuto -> message (f_"Attaching to compatible subscriptions"); let cmd = "subscription-manager attach --auto" in - do_run ~display:cmd cmd + do_run ~display:cmd ~warn_failed_no_network:true cmd | Subscription_manager.PoolId id ->...

...ey all pass. But when running the individual test "base_test.rb", I obtain failures. Here is the output: euclid% rake -I "connections/native_sqlite3" base_test.rb /opt/local/bin/rake:17:Warning: require_gem is obsolete. Use gem instead. (in /Users/smtlaissezfaire/devel/rails/subscription_manager/vendor/rails/activerecord) rake aborted! Don''t know how to build task ''base_test.rb'' (See full trace by running task with --trace) euclid% ruby -I "connections/native_sqlite3" base_test.rb Using native SQLite3 Loaded suite base_test Started .........F...........

Simplifies the build a bit. This is on top of the previous SELinux relabelling patch set, although not related to it. Rich.

...| 2 +- builder/sigchecker.ml | 12 +- customize/customize_run.ml | 2 +- customize/hostname.ml | 2 +- customize/password.ml | 2 +- customize/ssh_key.ml | 2 +- customize/subscription_manager.ml | 4 +- dib/cmdline.ml | 4 +- dib/dib.ml | 12 +- dib/elements.ml | 2 +- dib/utils.ml | 8 +- generator/customize.ml | 10 +- get-kernel/get_k...

I got a little way into this. The two attached patches are preliminary work. My proposed split is: libguestfs.git common -> git submodule libguestfs-common.git generator/ lib/ all language bindings C based tools (eg. virt-df, virt-edit, guestfish) guestfs-tools.git common -> git submodule libguestfs-common.git

We can use the setfiles(8) command to relabel the guest filesystem, even though we don't have a policy loaded nor SELinux enabled in the appliance kernel. This also deprecates or removes the old and broken SELinux support. This patch isn't quite complete - I would like to add some tests to the new API. I'm posting here to garner early feedback. Rich.

Hide/prevent the use of bad string functions like String.lowercase. These are replaced by safe functions that won't break UTF-8 strings. Other miscellaneous refactoring. Rich.

v1 -> v2: - Add simple test of the setfiles API. - Use SELinux_relabel module in virt-v2v (instead of touch /.autorelabel). - Small fixes. Rich.

Miscellaneous refactoring, but the main one is to rename mllib/ as common/mltools/ Rich.

...ze/firstboot.ml | 1 + customize/hostname.ml | 1 + customize/password.ml | 3 +- customize/perl_edit.ml | 1 + customize/ssh_key.ml | 7 +- customize/subscription_manager.ml | 3 +- dib/Makefile.am | 10 +- dib/cmdline.ml | 3 +- dib/dib.ml | 3 +- dib/elements.ml | 3 +- dib/output_format.ml...

...-- common/options/options.c | 4 ++-- common/options/uri.c | 2 +- customize/customize_run.ml | 8 ++++---- customize/firstboot.ml | 4 ++-- customize/password.ml | 2 +- customize/ssh_key.ml | 2 +- customize/subscription_manager.ml | 4 ++-- customize/virt-customize.pod | 6 +++--- dib/cmdline.ml | 6 +++--- dib/dib.ml | 6 +++--- dib/output_format_docker.ml | 4 ++-- dib/output_format_vhd.ml | 2 +- dib/utils.ml...

...uot; Arg.String (\n"; > + pr " [ \"--%s\" ],\n" name; > + pr " Getopt.String (\n"; > + pr " s_\"%s\",\n" v; > pr " fun s ->\n"; > pr " let sel = Subscription_manager.parse_pool_selector s in\n"; > pr " ops := %s sel :: !ops\n" discrim; > pr " ),\n"; > - pr " s_\"%s\" ^ \" \" ^ s_\"%s\"\n" v shortdesc; > + pr " s_\"%s\"\n&...

..." name; - pr " Arg.String (\n"; + pr " [ \"--%s\" ],\n" name; + pr " Getopt.String (\n"; + pr " s_\"%s\",\n" v; pr " fun s ->\n"; pr " let sel = Subscription_manager.parse_pool_selector s in\n"; pr " ops := %s sel :: !ops\n" discrim; pr " ),\n"; - pr " s_\"%s\" ^ \" \" ^ s_\"%s\"\n" v shortdesc; + pr " s_\"%s\"\n" shortdesc;...

..." name; - pr " Arg.String (\n"; + pr " [ \"--%s\" ],\n" name; + pr " Getopt.String (\n"; + pr " s_\"%s\",\n" v; pr " fun s ->\n"; pr " let sel = Subscription_manager.parse_pool_selector s in\n"; pr " push_front (%s sel) ops\n" discrim; pr " ),\n"; - pr " s_\"%s\" ^ \" \" ^ s_\"%s\"\n" v shortdesc; + pr " s_\"%s\"\n" shortdesc;...

..." name; - pr " Arg.String (\n"; + pr " [ \"--%s\" ],\n" name; + pr " Getopt.String (\n"; + pr " s_\"%s\",\n" v; pr " fun s ->\n"; pr " let sel = Subscription_manager.parse_pool_selector s in\n"; pr " push_front (%s sel) ops\n" discrim; pr " ),\n"; - pr " s_\"%s\" ^ \" \" ^ s_\"%s\"\n" v shortdesc; + pr " s_\"%s\"\n" shortdesc;...

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -