Displaying 5 results from an estimated 5 matches for "structured_pread".
2019 May 28
2
Re: [libnbd PATCH 4/4] api: Add DF flag support for pread
...ag");
> + return -1;
> + }
I'm confused why you'd want to specify this flag to pread. From the
caller point of view they shouldn't care about whether the reply on
the wire is fragmented or not?
(I can understand why you'd need this flag if we implemented a
separate structured_pread call.)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, loggin...
2019 Jun 20
1
Re: [libnbd PATCH 6/8] states: Add nbd_pread_callback API
...c = "\
As I mentioned re the previous commit, I think the implicit errno is
problematic, and an explicit int parameter would be preferable. I
think I also have bikeshedding concerns about the name of this
function. Do you have any better suggestions, such as
'pread_structured', 'structured_pread', 'pread_discontinuous', ...?
Given that, the overall idea looks sound to me.
> +of C<buf> within the original buffer). The C<status> parameter is
> +one of
> +
> +=over 4
> +
> +=item C<LIBNBD_READ_DATA> = 1
> +
> +C<buf> was populated...
2019 May 28
0
Re: [libnbd PATCH 4/4] api: Add DF flag support for pread
...ensus would be that while we might add support for
passing the flag, we don't have to go out of our way to document it for
nbd_pread (or maybe even document that it is pointless), and instead,
focus on:
>
> (I can understand why you'd need this flag if we implemented a
> separate structured_pread call.)
...what exactly we want to support here. My observation is that right
now, libnbd does NOT validate server compliance on structured read (we
don't know if a server populated the entire buffer, or whether it sent
overlapping chunks). But having some sort of callback that gets invoked
on...
2019 May 28
6
[RFC libnbd PATCH 0/4] Add CMD_FLAG_DF support
RFC because this is an API break, but we haven't declared stable API
yet. If we like it, I'm working on using libnbd to implement the
nbdkit-nbd plugin; knowing whether it is API version 0.1 or 0.2 will
be useful. I also dabbled with allowing optional parameters in python,
although my OCaml is weak enough that there may be cleaner ways to
approach that.
Eric Blake (4):
api: Add flags
2019 Jun 18
17
[libnbd PATCH 0/8] Add nbd_pread_callback
I've mentioned this topic before (in fact, the idea of adding
NBD_CMD_FLAG_DF was first mentioned at [1]), but finally finished
enough of an implementation to feel confident in posting it.
I'd still like to add something under examples/ that uses the new API
to implement strict checking of a server's structured replies read
implementation (ensure that a server never sends data after