search for: strtolower

This series introduces a new generic function strtolower(), which converts strings to lowercase in-place, overwriting the original string. This kind of functionality is needed in several places in the kernel. Right now, everybody seems to be implementing their own copy of this function. So, we replace several custom "strtolower" implementations...

...(char *dst, const char *src, size_t len); >> char *strncpytolower(char *dst, const char *src, size_t len); >> char *strcpytoupper(char *dst, const char *src); >> char *strcpytolower(char *dst, const char *src); >> char *strtoupper(char *s); >> char *strtolower(char *s); > > I think there isn't much value in anything other > than strto<upper|lower>. > > Using str[n]cpy followed by strto<upper|lower> is > pretty obvious and rarely used anyway. First time around, folks were proposing the "copy" variants when I su...

On Fri, 01 Jul 2016, Markus Mayer <mmayer at broadcom.com> wrote: > Add a function called strtolower() to convert strings to lower case > in-place, overwriting the original string. > > This seems to be a recurring requirement in the kernel that is > currently being solved by several duplicated implementations doing the > same thing. > > Signed-off-by: Markus Mayer <mmayer a...

On Fri, Jul 01 2016, Markus Mayer <mmayer at broadcom.com> wrote: > Add a function called strtolower() to convert strings to lower case > in-place, overwriting the original string. > > This seems to be a recurring requirement in the kernel that is > currently being solved by several duplicated implementations doing the > same thing. > > Signed-off-by: Markus Mayer <mmayer a...

On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer <mmayer at broadcom.com> wrote: > Call strtolower() rather than walking the string explicitly to convert > it to lowercase. > > Signed-off-by: Markus Mayer <mmayer at broadcom.com> > --- > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drive...

Add a function called strtolower() to convert strings to lower case in-place, overwriting the original string. This seems to be a recurring requirement in the kernel that is currently being solved by several duplicated implementations doing the same thing. Signed-off-by: Markus Mayer <mmayer at broadcom.com> --- include/l...

On 1 July 2016 at 03:52, Jani Nikula <jani.nikula at linux.intel.com> wrote: > On Fri, 01 Jul 2016, Markus Mayer <mmayer at broadcom.com> wrote: >> Add a function called strtolower() to convert strings to lower case >> in-place, overwriting the original string. >> >> This seems to be a recurring requirement in the kernel that is >> currently being solved by several duplicated implementations doing the >> same thing. >> >> Signed-off-b...

On Fri, 01 Jul 2016, Markus Mayer <markus.mayer at broadcom.com> wrote: > On 1 July 2016 at 03:52, Jani Nikula <jani.nikula at linux.intel.com> wrote: >> On Fri, 01 Jul 2016, Markus Mayer <mmayer at broadcom.com> wrote: >>> Add a function called strtolower() to convert strings to lower case >>> in-place, overwriting the original string. >>> >>> This seems to be a recurring requirement in the kernel that is >>> currently being solved by several duplicated implementations doing the >>> same thing. >>&g...

On 1 July 2016 at 18:18, Alexandre Courbot <gnurou at gmail.com> wrote: > On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer <mmayer at broadcom.com> wrote: >> Call strtolower() rather than walking the string explicitly to convert >> it to lowercase. >> >> Signed-off-by: Markus Mayer <mmayer at broadcom.com> >> --- >> drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >...

Call strtolower() rather than walking the string explicitly to convert it to lowercase. Signed-off-by: Markus Mayer <mmayer at broadcom.com> --- drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware....

On Sun, Jul 3, 2016 at 12:21 AM, Markus Mayer <markus.mayer at broadcom.com> wrote: > On 1 July 2016 at 18:18, Alexandre Courbot <gnurou at gmail.com> wrote: >> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer <mmayer at broadcom.com> wrote: >>> Call strtolower() rather than walking the string explicitly to convert >>> it to lowercase. >>> >>> Signed-off-by: Markus Mayer <mmayer at broadcom.com> >>> --- >>> drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +------ >>> 1 file changed, 1 insertion...

...ize_t len); > > >     char *strncpytolower(char *dst, const char *src, size_t len); > > >     char *strcpytoupper(char *dst, const char *src); > > >     char *strcpytolower(char *dst, const char *src); > > >     char *strtoupper(char *s); > > >     char *strtolower(char *s); > > I think there isn't much value in anything other > > than strto. > > > > Using str[n]cpy followed by strto is > > pretty obvious and rarely used anyway. > First time around, folks were proposing the "copy" variants when I > submitted...

...these new functions: char *strncpytoupper(char *dst, const char *src, size_t len); char *strncpytolower(char *dst, const char *src, size_t len); char *strcpytoupper(char *dst, const char *src); char *strcpytolower(char *dst, const char *src); char *strtoupper(char *s); char *strtolower(char *s); They all return a pointer to the terminating '\0' in the destination string (for strtoupper() and strtolower() that is "s"). Several drivers are being modified to make use of the functions above. Another driver that also makes use of this functionality will be submitted...

...rc, size_t len); > >> void strlcpytolower(char *dst, const char *src, size_t len); > >> void strcpytoupper(char *dst, const char *src); > >> void strcpytolower(char *dst, const char *src); > >> void strtoupper(char *s); > >> void strtolower(char *s); > > > > > > You may want to read the article here: > > > > https://lwn.net/Articles/659214/ > > I'll read that. Thanks. It doesn't look like there is going to be the danger of "mass changes". So far, I have two ACKs (one where the s...

...osing these new functions: void strlcpytoupper(char *dst, const char *src, size_t len); void strlcpytolower(char *dst, const char *src, size_t len); void strcpytoupper(char *dst, const char *src); void strcpytolower(char *dst, const char *src); void strtoupper(char *s); void strtolower(char *s); Several drivers are being modified to make use of the functions above. Another driver that also makes use of this functionality will be submitted upstream shortly, which prompted this whole exercise. The changes made here have been compile-tested, but not tried out, due to lack of requi...

...; void strlcpytoupper(char *dst, const char *src, size_t len); > void strlcpytolower(char *dst, const char *src, size_t len); > void strcpytoupper(char *dst, const char *src); > void strcpytolower(char *dst, const char *src); > void strtoupper(char *s); > void strtolower(char *s); > > The "str[l]cpyto*" versions of the function take a destination string > and a source string as arguments. The "strlcpyto*" versions additionally > take a length argument like strlcpy() itself. Lastly, the strto* > functions take a single string argu...

...void strlcpytoupper(char *dst, const char *src, size_t len); > void strlcpytolower(char *dst, const char *src, size_t len); > void strcpytoupper(char *dst, const char *src); > void strcpytolower(char *dst, const char *src); > void strtoupper(char *s); > void strtolower(char *s); You may want to read the article here: https://lwn.net/Articles/659214/ and follow up some of the discussion threads on LKML about the best semantics to advertise for the strlcpy/strscpy variants. It might be helpful to return some kind of overflow/truncation error from your copy func...

...oposing these new functions: int strlcpytoupper(char *dst, const char *src, size_t len); int strlcpytolower(char *dst, const char *src, size_t len); void strcpytoupper(char *dst, const char *src); void strcpytolower(char *dst, const char *src); void strtoupper(char *s); void strtolower(char *s); Several drivers are being modified to make use of the functions above. Another driver that also makes use of this functionality will be submitted upstream shortly, which prompted this whole exercise. The changes made here have been compile-tested, but not tried out, due to lack of requi...

...oposing these new functions: int strlcpytoupper(char *dst, const char *src, size_t len); int strlcpytolower(char *dst, const char *src, size_t len); void strcpytoupper(char *dst, const char *src); void strcpytolower(char *dst, const char *src); void strtoupper(char *s); void strtolower(char *s); Several drivers are being modified to make use of the functions above. Another driver that also makes use of this functionality will be submitted upstream shortly, which prompted this whole exercise. The changes made here have been compile-tested, but not tried out, due to lack of requi...

...on. The new functions are void strlcpytoupper(char *dst, const char *src, size_t len); void strlcpytolower(char *dst, const char *src, size_t len); void strcpytoupper(char *dst, const char *src); void strcpytolower(char *dst, const char *src); void strtoupper(char *s); void strtolower(char *s); The "str[l]cpyto*" versions of the function take a destination string and a source string as arguments. The "strlcpyto*" versions additionally take a length argument like strlcpy() itself. Lastly, the strto* functions take a single string argument and modify the passe...