search for: stringextras

...atch (noinline) is known for many months now. I'm a casual llvm user, and don't know the proper channels to go through to submit a patch. Could someone tell me, where do I submit patches like this one below? Or maybe why I shouldn't try to do it. Sincerely,Sergiy Index: include/llvm/ADT/StringExtras.h===================================================================--- include/llvm/ADT/StringExtras.h (revision 179701)+++ include/llvm/ADT/StringExtras.h (working copy)@@ -84,7 +84,7 @@ return std::string(BufPtr, Buffer+11); } -static inline std::string utostr(uint64_t X, bool isNeg = false) {...

...why > I shouldn't try to do it. We're generally happy to apply patches to ensure LLVM compiles on relevant compilers. For ICEs it might help to know what the precise problem is & to have a bug filed on the compiler. > > Sincerely, > Sergiy > > Index: include/llvm/ADT/StringExtras.h > =================================================================== > --- include/llvm/ADT/StringExtras.h (revision 179701) > +++ include/llvm/ADT/StringExtras.h (working copy) > @@ -84,7 +84,7 @@ > return std::string(BufPtr, Buffer+11); > } > > -static inline std::s...

...We're generally happy to apply patches to ensure LLVM compiles on > relevant compilers. For ICEs it might help to know what the precise > problem is & to have a bug filed on the compiler. > > > > > Sincerely, > > Sergiy > > > > Index: include/llvm/ADT/StringExtras.h > > =================================================================== > > --- include/llvm/ADT/StringExtras.h (revision 179701) > > +++ include/llvm/ADT/StringExtras.h (working copy) > > @@ -84,7 +84,7 @@ > > return std::string(BufPtr, Buffer+11); > > } &...

...We're generally happy to apply patches to ensure LLVM compiles on > relevant compilers. For ICEs it might help to know what the precise > problem is & to have a bug filed on the compiler. > > > > > Sincerely, > > Sergiy > > > > Index: include/llvm/ADT/StringExtras.h > > =================================================================== > > --- include/llvm/ADT/StringExtras.h (revision 179701) > > +++ include/llvm/ADT/StringExtras.h (working copy) > > @@ -84,7 +84,7 @@ > > return std::string(BufPtr, Buffer+11); > > } >...

...const*, unsigned long)': /home/proger/dev/llvm/tools/clang/lib/Frontend/DocumentXML.cpp:107: warning: sprintf() is often misused, please use snprintf() I've done some conversions from sprintf to snprintf, please commit those. -------------- next part -------------- Index: include/llvm/ADT/StringExtras.h =================================================================== --- include/llvm/ADT/StringExtras.h (revision 117247) +++ include/llvm/ADT/StringExtras.h (working copy) @@ -102,7 +102,7 @@ static inline std::string ftostr(double V) { char Buffer[200]; - sprintf(Buffer, "%20.6e&quo...

...ssy details that need to be dealt with. There's thousands of uses of take_front / drop_front, etc that have to be converted. Then there's some methods that aren't in string_view at all, like consume_integer(), consume_front(), etc that would have to be raised up to global functions in StringExtras. All of this can certainly be done, but it's going to be a *ton* of churn and hours spent to get it all STL-ified. > > Do you consider this a blocker for doing such a split? Would it make sense to do it incrementally where we first just move StringRef et all wholesale, and then increme...

....cpp =================================================================== --- utils/TableGen/Record.cpp (revision 58037) +++ utils/TableGen/Record.cpp (working copy) @@ -15,6 +15,7 @@ #include "llvm/Support/DataTypes.h" #include "llvm/Support/Streams.h" #include "llvm/ADT/StringExtras.h" +#include "llvm/Config/config.h" #include <ios> using namespace llvm; Index: win32/config.h =================================================================== --- win32/config.h (revision 58037) +++ win32/config.h (working copy) @@ -27,3 +27,4 @@ #define stricmp _stric...

...one where we're adding things > that are *known* to be added to c++ future. How strictly do we want to > enforce this? There are lots of things have equally broad utility, but > aren't necessarily known to be added to c++ in the future. > > For example, all of MathExtras and StringExtras, many member functions of > StringRef that are not in string_view, etc. can we still have these in the > top level compatibility library? > > We could still aim for interfaces that 1-to-1 match STL, but it would nice > if we could have some equally low level extras to enhance these c...

...Extras.h" #include "llvm/ADT/SetVector.h" #include "llvm/ADT/SmallPtrSet.h" #include "llvm/ADT/SmallSet.h" #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/SparseBitVector.h" #include "llvm/ADT/Statistic.h" #include "llvm/ADT/StringExtras.h" #include "llvm/ADT/StringMap.h" #include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringSet.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/ADT/TinyPtrVector.h" #include "llvm/ADT/Twine.h" Is this something worth putting ef...

...gt;> that are *known* to be added to c++ future. How strictly do we want to >>> enforce this? There are lots of things have equally broad utility, but >>> aren't necessarily known to be added to c++ in the future. >>> >>> For example, all of MathExtras and StringExtras, many member functions >>> of StringRef that are not in string_view, etc. can we still have these in >>> the top level compatibility library? >>> >>> We could still aim for interfaces that 1-to-1 match STL, but it would >>> nice if we could have some equ...

...dded to c++ future. How strictly do we want >>>>> to enforce this? There are lots of things have equally broad utility, but >>>>> aren't necessarily known to be added to c++ in the future. >>>>> >>>>> For example, all of MathExtras and StringExtras, many member functions >>>>> of StringRef that are not in string_view, etc. can we still have these in >>>>> the top level compatibility library? >>>>> >>>>> We could still aim for interfaces that 1-to-1 match STL, but it would >>&gt...

...t; >> #include "llvm/ADT/SmallPtrSet.h" >> #include "llvm/ADT/SmallSet.h" >> #include "llvm/ADT/SmallVector.h" >> #include "llvm/ADT/SparseBitVector.h" >> #include "llvm/ADT/Statistic.h" >> #include "llvm/ADT/StringExtras.h" >> #include "llvm/ADT/StringMap.h" >> #include "llvm/ADT/StringRef.h" >> #include "llvm/ADT/StringSet.h" >> #include "llvm/ADT/StringSwitch.h" >> #include "llvm/ADT/TinyPtrVector.h" >> #include "llvm/...

steve naroff <snaroff at apple.com> writes: > Folks, > > It appears the Windows build has regressed over the past week. > > The build fails quite early (during the "Performing TableGenStep" > phase). > > Any help/pointers would be appreciated. It breaks for me because the usage of INT64_C, which was introduced on r57663 and 57668. Some googling around

...========================================== > --- utils/TableGen/Record.cpp (revision 58037) > +++ utils/TableGen/Record.cpp (working copy) > @@ -15,6 +15,7 @@ > #include "llvm/Support/DataTypes.h" > #include "llvm/Support/Streams.h" > #include "llvm/ADT/StringExtras.h" > +#include "llvm/Config/config.h" > #include <ios> > > using namespace llvm; > Index: win32/config.h > =================================================================== > --- win32/config.h (revision 58037) > +++ win32/config.h (working copy) &...

In the midst of making TableGen Inits unique, I've run into some very odd DenseMap behavior. I converted the TernOpInit to use a factory method that uses a DenseMap to unique objects. I have defined a DenseMapInfo for std::string that uses HashString from StringExtras.h. const TernOpInit *TernOpInit::get(TernaryOp opc, const Init *lhs, const Init *mhs, const Init *rhs, RecTy *Type) { #define WORKS #ifdef WORKS typedef std::pair< std::pair< std::pair<std::pair<unsigned, s...

Does our pass need to ensure that the new names it creates for the field allocations are, in fact, unique? -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69

...lPtrSet.h" >>>> #include "llvm/ADT/SmallSet.h" >>>> #include "llvm/ADT/SmallVector.h" >>>> #include "llvm/ADT/SparseBitVector.h" >>>> #include "llvm/ADT/Statistic.h" >>>> #include "llvm/ADT/StringExtras.h" >>>> #include "llvm/ADT/StringMap.h" >>>> #include "llvm/ADT/StringRef.h" >>>> #include "llvm/ADT/StringSet.h" >>>> #include "llvm/ADT/StringSwitch.h" >>>> #include "llvm/ADT/TinyPtrVect...

Folks, It appears the Windows build has regressed over the past week. The build fails quite early (during the "Performing TableGenStep" phase). Any help/pointers would be appreciated. Thanks, snaroff (a clang developer)

...--git lib/Transforms/Instrumentation/DataFlowSanitizer.cpp lib/Transforms/Instrumentation/DataFlowSanitizer.cpp index 446bcf7..cb84fd6 100644 --- lib/Transforms/Instrumentation/DataFlowSanitizer.cpp +++ lib/Transforms/Instrumentation/DataFlowSanitizer.cpp @@ -51,6 +51,7 @@ #include "llvm/ADT/StringExtras.h" #include "llvm/Analysis/ValueTracking.h" #include "llvm/IR/Dominators.h" +#include "llvm/IR/DebugInfo.h" #include "llvm/IR/IRBuilder.h" #include "llvm/IR/InlineAsm.h" #include "llvm/IR/InstVisitor.h" @@ -243,6 +244,7 @@ class...

...llvm/ADT/SetVector.h" > #include "llvm/ADT/SmallPtrSet.h" > #include "llvm/ADT/SmallSet.h" > #include "llvm/ADT/SmallVector.h" > #include "llvm/ADT/SparseBitVector.h" > #include "llvm/ADT/Statistic.h" > #include "llvm/ADT/StringExtras.h" > #include "llvm/ADT/StringMap.h" > #include "llvm/ADT/StringRef.h" > #include "llvm/ADT/StringSet.h" > #include "llvm/ADT/StringSwitch.h" > #include "llvm/ADT/TinyPtrVector.h" > #include "llvm/ADT/Twine.h" > &...