search for: stringbuf

GCC 7 complains that the fixed size buffers are not large enough (at least in theory) when using ‘-O3 -mtune=broadwell’. --- daemon/devsparts.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/daemon/devsparts.c b/daemon/devsparts.c index 584e7d8b8..eac79197e 100644 --- a/daemon/devsparts.c +++ b/daemon/devsparts.c @@ -125,13 +125,16 @@ foreach_block_device

...} > + > + p = pend; > + } > + > + if (ss) { > + if (add_string (&ret, ss) == -1) { This needs to be add_string_nodup. > + free(ss); No need to free ss here; theoretically add_string will take care of it, be it added to the stringbuf or freed on error. > + return NULL; > + } > + } > + else { > + if (add_string (&ret, strdup("")) == -1) { > + return NULL; > + } > + } If there are no elements for "Snapshot(s)",...

...as value of key in previous line? Note this should be a > general process. field pointing at their non-blank start, and value as null. > > > + free(ss); > > > > No need to free ss here; theoretically add_string will take care of > > it, be it added to the stringbuf or freed on error. > > This is fail case. I don't understand what you mean here, can you please be more verbose? > > > + > > > + continue; > > > + } > > > + > > > + do { colon++; } while (*colon && c_isspace (*colon)...

...} > > + > > + if (ss) { > > + if (add_string (&ret, ss) == -1) { > > This needs to be add_string_nodup. > > > + free(ss); > > No need to free ss here; theoretically add_string will take care of it, > be it added to the stringbuf or freed on error. This is fail case. > > > + return NULL; > > + } > > + } > > + else { > > + if (add_string (&ret, strdup("")) == -1) { > > + return NULL; > > + } > >...

...wine.inf: Add UTC Time Zone. Piotr Caban (5): user32: Test GetIconInfo on other process cursor. ole32: Don't pump all messages in CoWaitForMultipleHandles in threads without apartment window. ole32/tests: Fix new failures in CoWaitForMultipleHandles tests. msvcp90: Fix stringbuf and strstreambuf seekpos implementation. msvcp120: Fix tr2::sys::_Copy_file test failures on non-ntfs file system. Sebastian Lackner (27): server: Use a separate wineserver call to fetch thread times. ntdll: Implement ThreadQuerySetWin32StartAddress info class in NtSetInformation...

If add_string_nodup fails free the passed string instead of leaking it, as that string would have been owned by the stringbuf. Adapt few places to this behaviour. --- daemon/btrfs.c | 4 +--- daemon/devsparts.c | 8 ++++---- daemon/guestfsd.c | 1 + 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 9b52aa8..d70565a 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @...

...lling GetPortCaps. d3dxof/tests: Pass level by value in process_data rather than a pointer. Daniel Lehman (11): msvcp90: Set eof state in istream<>::peek if got eof. msvcp: Sync istream<>::peek implementations. msvcp90: Update fpos<>::off instead of pos in stringbuf<>::seekoff. msvcp90: Fix usage of fpos<>::off vs fpos<>::pos. msvcp90: In istream<>::tellg don't use sentry. msvcp: Sync fpos usage and istream<>::tellg. msvcrt: Return value from MSVCRT____mb_cur_max_func instead of pointer. msvcp90:...

Hi, This is the part1 of improving btrfs support. This series adds missing parameters to btrfs_subvolume_snapshot and btrfs_subvolume_create, and adds two new API btrfs_subvolume_get_default and btrfs_subvolume_show. Other parts will follow. Regards, Hu Hu Tao (6): btrfs: correct words about subvolume and snapshot btrfs: add optional parameter `ro' to btrfs_subvolume_snapshot btrfs: