search for: string_of_partition_cont

...bel : string option; (* Label/name. *) (* What we're going to do: *) mutable p_operation : partition_operation; @@ -84,7 +85,12 @@ let rec debug_partition p = | MBR_ID i -> sprintf "0x%x" i | GPT_Type i -> i ); - eprintf "\tcontent: %s\n" (string_of_partition_content p.p_type) + eprintf "\tcontent: %s\n" (string_of_partition_content p.p_type); + eprintf "\tlabel: %s\n" + (match p.p_label with + | Some label -> label + | None -> "(none)" + ) and string_of_partition_content = function | ContentUnknown ->...

Hi, attached there are few patches to implement a way to get the label of GPT partitions (refactoring an existing function and adding a new daemon API) and using it in virt-resize to restore them when copying partitions. Thanks, Pino Toscano (3): daemon: parted: refactor sgdisk info parsing code New API: part-get-name (RHBZ#593511). resize: preserve GPT partition names (RHBZ#1060404).

...+ (match p.p_mbr_id, p.p_gpt_type with + | None, None -> "(none)" + | Some i, None -> sprintf "0x%x" i + | None, Some i -> i + | Some _, Some _ -> + (* This should not happen. *) + assert false + ); eprintf "\tcontent: %s\n" (string_of_partition_content p.p_type) and string_of_partition_content = function | ContentUnknown -> "unknown data" @@ -440,15 +448,21 @@ read the man page virt-resize(1). let part_num = Int32.to_int part_num in let name = sprintf "/dev/sda%d" part_num in let boot...

...ug_partition p = printf "%s:\n" p.p_name; @@ -99,7 +102,8 @@ let rec debug_partition p = (match p.p_guid with | Some guid -> guid | None -> "(none)" - ) + ); + printf "\tpartition type: %s\n" (string_of_partition_type p.p_mbr_p_type) and string_of_partition_content = function | ContentUnknown -> "unknown data" | ContentPV sz -> sprintf "LVM PV (%Ld bytes)" sz @@ -110,6 +114,11 @@ and string_of_partition_content_no_size = function | ContentPV _ -> "LVM PV" | ContentFS (fs, _) -> sprintf "filesystem...

--- daemon/daemon.h | 1 + daemon/labels.c | 3 +++ daemon/swap.c | 21 +++++++++++++++++++++ generator/actions.ml | 4 ++++ 4 files changed, 29 insertions(+) diff --git a/daemon/daemon.h b/daemon/daemon.h index 79a5288..2379e31 100644 --- a/daemon/daemon.h +++ b/daemon/daemon.h @@ -254,6 +254,7 @@ extern int64_t ntfs_minimum_size (const char *device); /*-- in swap.c --*/

...edPartition (* MBR extended partition *) + | ContentSwap (* Swap partition *) and partition_operation = | OpCopy (* copy it as-is, no resizing *) | OpIgnore (* ignore it (create on target, but don't @@ -104,11 +105,13 @@ and string_of_partition_content = function | ContentPV sz -> sprintf "LVM PV (%Ld bytes)" sz | ContentFS (fs, sz) -> sprintf "filesystem %s (%Ld bytes)" fs sz | ContentExtendedPartition -> "extended partition" + | ContentSwap -> "swap" and string_of_partition_conte...

virt-resize didn't preserve the per-partition GPT GUID. Now that guests using UEFI are becoming common (basically it's the default on aarch64) we need to take into account that sometimes the partition GUID is used by the bootloader NVRAM variables to identify the boot partition, so it must be preserved across resize. This bug caused the 'virt-builder --size' option to fail on

On Tue, Jul 15, 2014 at 09:01:47AM +0100, Richard W.M. Jones wrote: > The answer is I don't know. But there are a few things you can try: > > (1) Most importantly, enable tracing (export LIBGUESTFS_TRACE=1) and > get a list of operations that are performed in the order they are > performed. This is vital for debugging this. > > (2) When the error happens, run

Version 1 of the patch, for discussion, but not to be applied. It does work, but needs a lot more testing. This removes all the psychopathic gettextify cruft, and replaces it with a 99 line Makefile.am. A large win, I think. The third patch implements gettext support in the OCaml tools. The fourth patch is just for illustration. It shows the consequent changes to libguestfs.pot and the po