search for: string_of_overlay

This adds --print-target. In addition, v2 provides a machine-readable version (in JSON format). All of the record -> JSON boilerplate in this patch could be eliminated if we moved the baseline to OCaml 4.02. Rich.

...: string option; output_name : string option; print_source : bool; + print_target : bool; root_choice : Types.root_choice; } diff --git a/v2v/types.ml b/v2v/types.ml index b89bd2fe2..c1f36fdb1 100644 --- a/v2v/types.ml +++ b/v2v/types.ml @@ -281,11 +281,10 @@ type overlay = { } let string_of_overlay ov = - sprintf "\ -ov_overlay_file = %s -ov_sd = %s -ov_virtual_size = %Ld -ov_source = %s + sprintf " overlay file: %s + overlay device name: %s +overlay virtual disk size: %Ld + overlay source qemu URI: %s " ov.ov_overlay_file ov.ov_sd @@ -304,12 +303...

RHV was connecting to the VMware source in order to find out the virtual disk size of the source disk(s), duplicating logic that virt-v2v already provides. This makes that information available using a new ‘virt-v2v --print-target option’. Note in order to get all the information, this has to actually perform the conversion step, so it takes 30 seconds or so before we reach the point where the

...1) nr_disks s t.target_format; | TargetURI s -> - message (f_"Copying disk %d/%d to qemu URI %s (%s)") + message (f_"Preparing disk %d/%d on qemu URI %s (%s)") (i+1) nr_disks s t.target_format ); debug "%s" (string_of_overlay t.target_overlay); @@ -744,19 +744,8 @@ and copy_targets cmdline targets input output = () ); - let cmd = - let filename = - match t.target_file with - | TargetFile filename -> qemu_input_filename filename - | TargetURI uri -> uri in...

This changes the infrastructure to allow the target_file to be a QEMU URI. Rich.