Displaying 3 results from an estimated 3 matches for "str_rtrim".
Did you mean:
str_fstrim
2016 Jan 28
1
Patching CyberPower UPS drivers
...with a "thumbs up" response. (I'm more a hardware guy)
And sscanf was working like poo -- so I figured I'd parse it differently with something that didn't seem so sensitive.
> A few items:
>
> * Since v2.6.5, some of the string functions were renamed. rtrim() -> str_rtrim(), for instance.
I'll take a look at the latest.... as mentioned, 2.6.5 is what's on my CentOS system with nothing later (yet) so I just downloaded the SRPMS to work on.
but I also have 2.7.3 downloaded -- so I'll see what I can do with that.
> * If you are taking out a block of c...
2016 Jan 19
5
Patching CyberPower UPS drivers
Hey there,
I got a new UPS (CyberPower PR1500LCDRTXL2Ua) and found the serial drivers don't quite work...
So I decided to jump in and make changes to the driver that would hopefully make it happier.
I have it working (I really only changed powerp-txt.c) but still have a couple questions... Charles said I should mention them here to talk to anyone interest but specifically Arjen (one of
2016 Jan 28
0
Patching CyberPower UPS drivers
...rsing part works. I just need to alter the collection part so the timeouts work differently.
I definitely like your approach. Thanks for moving some of the "magic numbers" to named constants, as well.
A few items:
* Since v2.6.5, some of the string functions were renamed. rtrim() -> str_rtrim(), for instance.
* If you are taking out a block of code, "#if 0" is better than comment characters (which don't nest), and removing it completely is even better (fewer false positives when searching). If nothing else, it's in version control.
Diff attached.
Thanks,
--
Charles...