search for: str_file

...solv.conf", rs->sysroot_etc_resolv_conf, NULL)); rs->mounted = true; diff --git a/daemon/debug.c b/daemon/debug.c index 9fe57fc..b5470d7 100644 --- a/daemon/debug.c +++ b/daemon/debug.c @@ -41,6 +41,7 @@ GUESTFSD_EXT_CMD(str_xargs, xargs); GUESTFSD_EXT_CMD(str_file, file); GUESTFSD_EXT_CMD(str_grep, grep); GUESTFSD_EXT_CMD(str_gawk, gawk); +GUESTFSD_EXT_CMD(str_sh, sh); /* This command exposes debugging information, internals and * status. There is no comprehensive documentation for this @@ -335,7 +336,7 @@ debug_binaries (const char *subcmd, size_t a...

...s.ml \ sysroot.ml \ chroot.ml \ + file.ml \ callbacks.ml \ daemon.ml diff --git a/daemon/file.c b/daemon/file.c index 84874dc6f..ee79eb507 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -30,7 +30,6 @@ #include "actions.h" #include "optgroups.h" -GUESTFSD_EXT_CMD(str_file, file); GUESTFSD_EXT_CMD(str_zcat, zcat); GUESTFSD_EXT_CMD(str_bzcat, bzcat); @@ -449,85 +448,6 @@ do_pwrite_device (const char *device, const char *content, size_t size, return pwrite_fd (fd, content, size, offset, device, 1); } -/* This runs the 'file' command. */ -char * -do_fi...

...11 CEST Richard W.M. Jones wrote: > diff --git a/daemon/file.c b/daemon/file.c > index 84874dc6f..ee79eb507 100644 > --- a/daemon/file.c > +++ b/daemon/file.c > @@ -30,7 +30,6 @@ > #include "actions.h" > #include "optgroups.h" > > -GUESTFSD_EXT_CMD(str_file, file); When migrating to OCaml, these extra sections in the ELF are not added anymore. I read they were added to help packagers (IIRC it started from the SUSE guys), so they could easily notice the binaries used by the daemon, and add the proper dependencies. Do we still want to keep this possi...

Hi, attached there is a prototype of patch for adding a new copy-attributes command. Such command would allow copy the attributes of a "file" to another, so for example in guestfish: copy-attributes foo bar permissions:true xattributes:false would only copy the permissions of foo to bar, not copying its extended attributes too. Just few notes: - my first daemon command, so

...RPC stubs. diff --git a/daemon/file.c b/daemon/file.c index f348f87..856ab5f 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -28,6 +28,7 @@ #include "guestfs_protocol.h" #include "daemon.h" #include "actions.h" +#include "optgroups.h" GUESTFSD_EXT_CMD(str_file, file); GUESTFSD_EXT_CMD(str_zcat, zcat); @@ -584,3 +585,74 @@ do_filesize (const char *path) return buf.st_size; } + +int +do_copy_attributes (const char *src, const char *dest, int all, int mode, int xattributes, int ownership) +{ + int r; + struct stat srcstat, deststat; + + static con...

...e.c > index f348f87..fd6da71 100644 > --- a/daemon/file.c > +++ b/daemon/file.c > @@ -28,6 +28,7 @@ > #include "guestfs_protocol.h" > #include "daemon.h" > #include "actions.h" > +#include "optgroups.h" > > GUESTFSD_EXT_CMD(str_file, file); > GUESTFSD_EXT_CMD(str_zcat, zcat); > @@ -584,3 +585,46 @@ do_filesize (const char *path) > > return buf.st_size; > } > + > +int > +do_copy_attributes (const char *src, const char *dest, int permissions, int xattributes) > +{ > + int r; > + struct s...

...+ b/daemon/debug.c @@ -32,6 +32,15 @@ #include "daemon.h" #include "actions.h" +GUESTFSD_EXT_CMD(str_printenv, printenv); +GUESTFSD_EXT_CMD(str_ldd, ldd); +GUESTFSD_EXT_CMD(str_ls, ls); +GUESTFSD_EXT_CMD(str_find, find); +GUESTFSD_EXT_CMD(str_xargs, xargs); +GUESTFSD_EXT_CMD(str_file, file); +GUESTFSD_EXT_CMD(str_grep, grep); +GUESTFSD_EXT_CMD(str_gawk, gawk); + /* This command exposes debugging information, internals and * status. There is no comprehensive documentation for this * command. You have to look at the source code in this file @@ -275,7 +284,7 @@ debug_env (c...

...g.c +++ b/daemon/debug.c @@ -32,6 +32,15 @@ #include "daemon.h" #include "actions.h" +GUESTFS_EXT_CMD(str_printenv, printenv); +GUESTFS_EXT_CMD(str_ldd, ldd); +GUESTFS_EXT_CMD(str_ls, ls); +GUESTFS_EXT_CMD(str_find, find); +GUESTFS_EXT_CMD(str_xargs, xargs); +GUESTFS_EXT_CMD(str_file, file); +GUESTFS_EXT_CMD(str_grep, grep); +GUESTFS_EXT_CMD(str_gawk, gawk); + /* This command exposes debugging information, internals and * status. There is no comprehensive documentation for this * command. You have to look at the source code in this file @@ -275,7 +284,7 @@ debug_env (con...

...+ b/daemon/debug.c @@ -33,16 +33,6 @@ #include "daemon.h" #include "actions.h" -GUESTFSD_EXT_CMD(str_printenv, printenv); -GUESTFSD_EXT_CMD(str_ldd, ldd); -GUESTFSD_EXT_CMD(str_ls, ls); -GUESTFSD_EXT_CMD(str_find, find); -GUESTFSD_EXT_CMD(str_xargs, xargs); -GUESTFSD_EXT_CMD(str_file, file); -GUESTFSD_EXT_CMD(str_grep, grep); -GUESTFSD_EXT_CMD(str_gawk, gawk); -GUESTFSD_EXT_CMD(str_sh, sh); - /* This command exposes debugging information, internals and * status. There is no comprehensive documentation for this * command. You have to look at the source code in this file @...

This patch series is just FYI at the moment. However it does pass the tests. The daemon is a self-contained program. We don't need to write it all in C. Writing parts of it in OCaml would make it simpler and less error-prone. In particular if the daemon was written in a more sane programming language then we could move the inspection code to run entirely inside the appliance, which would

...+ b/daemon/debug.c @@ -33,15 +33,8 @@ #include "daemon.h" #include "actions.h" -GUESTFSD_EXT_CMD(str_printenv, printenv); -GUESTFSD_EXT_CMD(str_ldd, ldd); -GUESTFSD_EXT_CMD(str_ls, ls); -GUESTFSD_EXT_CMD(str_find, find); -GUESTFSD_EXT_CMD(str_xargs, xargs); -GUESTFSD_EXT_CMD(str_file, file); -GUESTFSD_EXT_CMD(str_grep, grep); -GUESTFSD_EXT_CMD(str_gawk, gawk); -GUESTFSD_EXT_CMD(str_sh, sh); +DECLARE_EXTERNAL_COMMANDS ("printenv", "ldd", "ls", "find", "xargs", + "file", "grep", "...

....c > > +++ b/daemon/file.c > > @@ -28,6 +28,7 @@ > > > > #include "guestfs_protocol.h" > > #include "daemon.h" > > #include "actions.h" > > > > +#include "optgroups.h" > > > > GUESTFSD_EXT_CMD(str_file, file); > > GUESTFSD_EXT_CMD(str_zcat, zcat); > > > > @@ -584,3 +585,46 @@ do_filesize (const char *path) > > > > return buf.st_size; > > > > } > > > > + > > +int > > +do_copy_attributes (const char *src, const char *dest,...

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’

Version 1 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00003.html This patch series reimplements a few more APIs in OCaml, including some very important core APIs like ?list_filesystems? and ?mount?. All the tests pass after this. The selection of APIs that I have moved may look a little random, but in fact they are all APIs consumed by the inspection code (and some more

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.

v2 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00008.html This series gets as far as a working (and faster) reimplementation of ‘guestfs_list_filesystems’. I also have another patch series on top of this one which reimplements the inspection APIs inside the daemon, but that needs a bit more work still, since inspection turns out to be a very large piece of code. Rich.

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html This series now depends on two small patches which I posted separately: https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html v1 -> v2: - Previously changes to generator/daemon.ml were made incrementally through the patch

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes