search for: storsj

On Mon, 10 Nov 2014, Hugo Beauzee-Luyssen wrote: > On 11/06/2014 10:55 PM, Martin Storsj? wrote: >> On Thu, 6 Nov 2014, Jean-Marc Valin wrote: >> >>> Is there any consensus on what's the correct fix here? >> >> Cameron's fix looks correct to me (I didn't read the code closely enough >> in my first comment). >> > > That look...

I have used the patch to build opus 1.1. Although I have not tried the latest git master, will try that. Will that work for armv7, armv7s and arm64? On Wed, Mar 26, 2014 at 11:01 PM, Martin Storsj? <martin at martin.st> wrote: > On Wed, 26 Mar 2014, Jonathan Lennox wrote: > > >> On Mar 26, 2014, at 7:55 AM, Peter Robinson <pbrobinson at gmail.com> wrote: >> >> On Wed, Mar 26, 2014 at 11:45 AM, Vinay <vinay.nair at novanet.net> wrote: >>&gt...

...ic, but that's not the intended use in the code. The correct definitions are _M_IX86 and _M_X64, as Martin said. I sent a patch to this ML that fixed these a few months ago but it was forgotten/ignored. Hopefully the issue gets addressed this time. Cameron On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st> wrote: > On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > > --- >> celt/float_cast.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/celt/float_cast.h b/celt/float_cast.h >> index ede6574..48...

On Thu, 6 Nov 2014, Jean-Marc Valin wrote: > Is there any consensus on what's the correct fix here? Cameron's fix looks correct to me (I didn't read the code closely enough in my first comment). // Martin

...Mar 27, 2014 at 11:29 AM, Vinay Nair <vinay.nair at novanet.net> wrote: > I have used the patch to build opus 1.1. Although I have not tried the > latest git master, will try that. Will that work for armv7, armv7s and > arm64? > > > On Wed, Mar 26, 2014 at 11:01 PM, Martin Storsj? <martin at martin.st> wrote: > >> On Wed, 26 Mar 2014, Jonathan Lennox wrote: >> >> >>> On Mar 26, 2014, at 7:55 AM, Peter Robinson <pbrobinson at gmail.com> >>> wrote: >>> >>> On Wed, Mar 26, 2014 at 11:45 AM, Vinay <vinay.n...

...ten/ignored. Hopefully the issue gets addressed this time. > > This one, I gather? > > http://lists.xiph.org/pipermail/opus/attachments/20140406/e19d33cd/attachment.obj > > Best, > Tristan > > > > > Cameron > > > > On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st> wrote: > >> > >> On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > >> > >>> --- > >>> celt/float_cast.h | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>&gt...

...please edit your Subject line so it is more specific than "Re: Contents of opus digest..." Today's Topics: 1. Re: opus Digest, Vol 70, Issue 1 (Heng Lou) 2. [PATCH] float_cast: Fix MSVC ARM build (Hugo Beauz?e-Luyssen) 3. Re: [PATCH] float_cast: Fix MSVC ARM build (Martin Storsj?) ---------------------------------------------------------------------- Message: 1 Date: Wed, 5 Nov 2014 20:19:04 +0000 From: Heng Lou <Heng_Lou at starkey.com> Subject: Re: [opus] opus Digest, Vol 70, Issue 1 To: "opus at xiph.org" <opus at xiph.org> Message-ID: <D0ED6...

On Sat, 8 Feb 2014, Martin Storsjo wrote: > This is required in order to build using the built-in assembler > in clang. > --- > I squashed the two changes since it would break the normal gcc > build otherwise. > --- > celt/arm/arm2gnu.pl | 2 ++ > celt/arm/celt_pitch_xcorr_arm.s | 18 +++++++++--...

...that fixed these a few months ago but it was > forgotten/ignored. Hopefully the issue gets addressed this time. This one, I gather? http://lists.xiph.org/pipermail/opus/attachments/20140406/e19d33cd/attachment.obj Best, Tristan > > Cameron > > On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st> wrote: >> >> On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: >> >>> --- >>> celt/float_cast.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/celt/float_cast.h b/celt/...

...ue gets addressed this time. > > This one, I gather? > http://lists.xiph.org/pipermail/opus/attachments/20140406/e19d33cd/attachment.obj > > Best, > Tristan > > > > > Cameron > > > > On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st > <mailto:martin at martin.st>> wrote: > >> > >> On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > >> > >>> --- > >>> celt/float_cast.h | 4 ++-- > >>> 1 file changed...

On 11/06/2014 10:55 PM, Martin Storsj? wrote: > On Thu, 6 Nov 2014, Jean-Marc Valin wrote: > >> Is there any consensus on what's the correct fix here? > > Cameron's fix looks correct to me (I didn't read the code closely enough > in my first comment). > > // Martin > _______________________...

Martin Storsjo wrote: > + [AC_MSG_RESULT([yes]); ARM2GNU_PARAMS="-apple"], I'd prefer --apple instead of -apple, but otherwise these patches both look good to me. Does Apple have equivalent machinery to any of the pieces you disabled? Those were: - object size calculations...

On Mar 26, 2014, at 7:55 AM, Peter Robinson <pbrobinson at gmail.com> wrote: > On Wed, Mar 26, 2014 at 11:45 AM, Vinay <vinay.nair at novanet.net> wrote: >> Hi, >> >> I wanted to build opus along with PJSIP for iOS for the architecture arm64. >> I wanted to know if opus supports arm64? > > The opus code builds fine on ARM64 on Linux at least,

On Thu, 8 Jan 2015, Jonathan Lennox wrote: > Every armv7 (and armv8) iOS device has supported Neon, and Xcode support for > armv6 was dropped with Xcode 4.5. > > Even if you?re compiling with an old Xcode version to support really old iOS > devices, Apple?s armv6/armv7 selection was a compile-time switch (supported > using fat binaries). ?I think the arch can be detected based

--- celt/float_cast.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/celt/float_cast.h b/celt/float_cast.h index ede6574..4892e2c 100644 --- a/celt/float_cast.h +++ b/celt/float_cast.h @@ -90,14 +90,14 @@ #include <math.h> #define float2int(x) lrint(x) -#elif (defined(_MSC_VER) && _MSC_VER >= 1400) && (defined (WIN64) || defined (_WIN64))