search for: storeofload

...if (!Repl) > + Repl = SI->getPointerOperand(); > + else if (Repl != SI->getPointerOperand()) > + return false; > + > + } else > + return false; > + } > > Please do something like this: > > if (!L->hasOneUse()) return false; > StoreInst *StoreOfLoad = dyn_cast<StoreInst>(L->use_back()); > if (StoreOfLoad == 0 || ...) > ... > > > Actually, I see now that the code actually allows multiple stores as > long as they are to the same pointer. That also seems reasonable to > me, but please update the comment above th...

...he size of the object, you can just pass in 1 for both sizes. Please put a comment above the call to AA.alias explaining why you require mustalias here. + // Look for a replacement for our pointer. If more than one found, exit. + if (!L->hasOneUse()) + return false; + StoreInst *StoreOfLoad = dyn_cast<StoreInst>(L->use_back()); + if (!StoreOfLoad) + return false; Please do these check before the MemDep query, they are very cheap and will make the optimization run faster (by avoiding queries). I'm pretty sure that there is still a legality check missing here....

...her." :-) > Please put a comment above the call to AA.alias explaining why you > require mustalias here. > > > > + // Look for a replacement for our pointer. If more than one > found, exit. > + if (!L->hasOneUse()) > + return false; > + StoreInst *StoreOfLoad = dyn_cast<StoreInst>(L->use_back()); > + if (!StoreOfLoad) > + return false; > > Please do these check before the MemDep query, they are very cheap > and will make the optimization run faster (by avoiding queries). > > > > I'm pretty sure that there is...

...)) { + if (SI->isVolatile()) + return false; + + if (!Repl) + Repl = SI->getPointerOperand(); + else if (Repl != SI->getPointerOperand()) + return false; + + } else + return false; + } Please do something like this: if (!L->hasOneUse()) return false; StoreInst *StoreOfLoad = dyn_cast<StoreInst>(L->use_back()); if (StoreOfLoad == 0 || ...) ... Actually, I see now that the code actually allows multiple stores as long as they are to the same pointer. That also seems reasonable to me, but please update the comment above the loop to make it really clear...

Hello, Sorry for my stupid mistakes. I hope that everything is fine now. This patch fixes PR2218. There are no loads in example, however "instcombine" changes memcpy() into store/load. Regards, Jakub Staszak -------------- next part -------------- A non-text attachment was scrubbed... Name: pr2218-2.patch Type: application/octet-stream Size: 6525 bytes Desc: not available URL: