search for: storagevolume

I've rebased the patch series to the current next branch and am sending them again.

...olume.name) - storage_volume.key = volume.key + storage_volume.key = volume.get_attr('key') storage_volume.lv_owner_perms = owner storage_volume.lv_group_perms = group storage_volume.lv_mode_perms = mode @@ -661,14 +661,14 @@ class TaskOmatic existing_vol = StorageVolume.find(:first, :conditions => ["storage_pool_id = ? AND key = ?", - db_pool_phys.id, volume.key]) + db_pool_phys.id, volume.get_attr('key')]) - puts "Existing volume is #{existing_v...

...(+), 27 deletions(-) diff --git a/src/app/controllers/storage_volume_controller.rb b/src/app/controllers/storage_volume_controller.rb index b89513a..fb6bc9c 100644 --- a/src/app/controllers/storage_volume_controller.rb +++ b/src/app/controllers/storage_volume_controller.rb @@ -21,7 +21,11 @@ class StorageVolumeController < ApplicationController include StorageVolumeService def new - svc_new(params[:storage_pool_id], params[:source_volume_id]) + if params[:storage_pool_id] + svc_new(params[:storage_pool_id]) + else + svc_new_lv(params[:source_volume_id]) + end @return_...

...ume.volume_name, volume.name) + storage_volume.write_attribute(storage_volume.volume_name, volume.key) storage_volume.lv_owner_perms = owner storage_volume.lv_group_perms = group storage_volume.lv_mode_perms = mode @@ -644,13 +644,14 @@ class TaskOmatic existing_vol = StorageVolume.find(:first, :conditions => ["storage_pool_id = ? AND #{storage_volume.volume_name} = ?", - db_pool_phys.id, volume.name]) + db_pool_phys.id, volume.key]) + puts "Existing volume is #{exi...

...ernel.rand(62); i += ((i < 10) ? 48 : ((i < 36) ? 55 : 61 ))).chr } - s -end - -def all_storage_pools(conn) - all_pools = conn.list_defined_storage_pools - all_pools.concat(conn.list_storage_pools) - return all_pools -end - -def get_libvirt_lvm_pool_from_volume(db_volume) - phys_volume = StorageVolume.find(:first, :conditions => - [ "lvm_pool_id = ?", db_volume.storage_pool_id]) - - return LibvirtPool.factory(phys_volume.storage_pool) -end - -class LibvirtPool - def initialize(type, name = nil) - @remote_pool = nil - @build_on_start = true -...

..., pool.export_path, logger) elsif pool[:type] == "LvmStoragePool" # OK, if this is LVM storage, there are two cases we need to care about: # 1) this is a LUN with LVM already on it. In this case, all we need to @@ -212,7 +216,7 @@ class LibvirtPool phys_volume = StorageVolume.find(:first, :conditions => [ "lvm_pool_id = ?", pool.id]) return LVMLibvirtPool.new(pool.vg_name, phys_volume.path, - pool.state == StoragePool::STATE_PENDING_SETUP) + pool.sta...

...ge.rb index 77b0166..d698777 100644 --- a/src/task-omatic/task_storage.rb +++ b/src/task-omatic/task_storage.rb @@ -73,7 +73,7 @@ def task_storage_cobbler_setup(db_vm) unless found # Create a new transient NFS storage volume # This volume is *not* persisted. - image_volume = StorageVolume.factory("NFS", :filename => filename) + image_volume = StorageVolume.factory("NFS", :filename => filename, :key => filename) image_volume.storage_pool image_pool = StoragePool.factory(StoragePool::NFS) @@ -116,13 +116,14 @@ class LibvirtPool @x...

This version of the patch includes feedback from jboggs at redhat.com, including fixes to the BuildRequires and Requires in the spec file.

This patch obsoletes any previous ones. This is an upstream candidate, so I'm looking for feedback so we can push this and start using it.

This version fixes a few bugs found by jboggs. It also includes some logging facilities that need to be fleshed out more.

This patch is ready for pushing upstream.

The previous patch was missing this file. Resending.

...just looking for some feedback on the direction I'm going. The code won't get all the way to the define stage since I'm in the middle of retrofitting it to use virtinst instead of a home spun node definition.