search for: storage_nam

...hanged, 1 insertion(+), 1 deletion(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index c72f5e181..c6ba1962f 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -70,7 +70,7 @@ def find_host(connection): system_service = connection.system_service() storage_name = params['output_storage'] data_centers = system_service.data_centers_service().list( - search='storage=%s' % storage_name, + search='storage.name=%s' % storage_name, case_sensitive=False, ) if len(data_centers) == 0: -- 2.17.1

Hi, while trying to investigate the bug I reported last week, I found that there is a broken boundary check in client_find_namespace in src/imap/imap-commands-util.c. The code is: /* make sure two hierarchy separators aren't next to each others */ for (p = storage_name+1; *p != '\0'; p++) { if (p[0] == ns->real_sep && p[-1] == ns->real_sep) { client_send_tagline(cmd, "NO Invalid mailbox name."); return NULL; } } The loop iterates over the string storage_name starting from its second byte. However, the s...

...288..931fcfaa2 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -69,14 +69,34 @@ def find_host(connection): debug("hw_id = %r" % vdsm_id) - hosts_service = connection.system_service().hosts_service() + system_service = connection.system_service() + storage_name = params['output_storage'] + data_centers = system_service.data_centers_service().list( + search='storage=%s' % storage_name, + case_sensitive=False, + ) + if len(data_centers) == 0: + # The storage domain is not attached to a datacenter + # (sh...

...upload-plugin.py b/v2v/rhv-upload-plugin.py > > index c72f5e181..c6ba1962f 100644 > > --- a/v2v/rhv-upload-plugin.py > > +++ b/v2v/rhv-upload-plugin.py > > @@ -70,7 +70,7 @@ def find_host(connection): > > system_service = connection.system_service() > > storage_name = params['output_storage'] > > data_centers = system_service.data_centers_service().list( > > - search='storage=%s' % storage_name, > > + search='storage.name=%s' % storage_name, > > case_sensitive=False, > > Thanks,...

...upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -67,11 +67,23 @@ def find_host(connection): debug("cannot read /etc/vdsm/vdsm.id, using any host: %s" % e) return None - debug("hw_id = %r" % vdsm_id) + system_service = connection.system_service() + storage_name = params['output_storage'] + data_centers = system_service.data_centers_service().list( + search='storage=%s' % storage_name, + case_sensitive=False, + ) + if len(data_centers) == 0: + # The storage domain is not attached to a datacenter + # (sh...

> > With todays nightly: > > > > dsync(wsunpriv at iai.uni-bonn.de): Panic: file imapc-list.c: line 199 (imapc_list_get_vname): assertion failed: (strncmp(prefix, storage_name, prefix_len) == 0 && storage_name[prefix_len] == list->sep) > > Oh, and this would be good to solve too. What does it say with gdb: > > gdb dsync core > fr 5 > p prefix > p storage_name > p prefix_len > p list.sep > p list.ns.prefix Thank you very much f...

...--- v2v/rhv-upload-plugin.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index c6ba1962f..d787c9598 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -71,7 +71,7 @@ def find_host(connection): storage_name = params['output_storage'] data_centers = system_service.data_centers_service().list( search='storage.name=%s' % storage_name, - case_sensitive=False, + case_sensitive=True, ) if len(data_centers) == 0: # The storage domain is not atta...

...upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -69,14 +69,34 @@ def find_host(connection): > > debug("hw_id = %r" % vdsm_id) > > - hosts_service = connection.system_service().hosts_service() > + system_service = connection.system_service() > + storage_name = params['output_storage'] > + data_centers = system_service.data_centers_service().list( > + search='storage=%s' % storage_name, > + case_sensitive=False, > + ) > + if len(data_centers) == 0: > + # The storage domain is not attached...

...t; > diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py > index c72f5e181..c6ba1962f 100644 > --- a/v2v/rhv-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -70,7 +70,7 @@ def find_host(connection): > system_service = connection.system_service() > storage_name = params['output_storage'] > data_centers = system_service.data_centers_service().list( > - search='storage=%s' % storage_name, > + search='storage.name=%s' % storage_name, > case_sensitive=False, Thanks, pushed (commit 2547df8a0de46...

...ad-plugin.py > @@ -67,11 +67,23 @@ def find_host(connection): > debug("cannot read /etc/vdsm/vdsm.id, using any host: %s" % e) > return None > > - debug("hw_id = %r" % vdsm_id) > + system_service = connection.system_service() > + storage_name = params['output_storage'] > + data_centers = system_service.data_centers_service().list( > + search='storage=%s' % storage_name, > + case_sensitive=False, > + ) > + if len(data_centers) == 0: > + # The storage domain is not attached...

...@@ def find_host(connection): > debug("cannot read /etc/vdsm/vdsm.id, using any host: %s" % e) > return None > > - debug("hw_id = %r" % vdsm_id) > I would leave this as is... > + system_service = connection.system_service() > + storage_name = params['output_storage'] > + data_centers = system_service.data_centers_service().list( > + search='storage=%s' % storage_name, > + case_sensitive=False, > + ) > + if len(data_centers) == 0: > + # The storage domain is not attached...

This series extract oVirt SDK and imageio code to make it eaiser to follow the code and improve error handing in open() and close(). The first small patches can be consider as fixes for downstream. Tested based on libguestfs v1.41.5, since I had trouble building virt-v2v and libguestfs from master. Nir Soffer (18): rhv-upload: Remove unused exception class rhv-upload: Check status more

...ommit author Timo Sirainen <tss at iki.fi> Thu Jan 20 20:59:07 2011 +0200 (2011-01-20) changeset 12586 a2780b694b2d parent 12585 b748c622e896 child 12587 c3a258ee96c4 lib-storage: mailbox_alloc() now takes a virtual mailbox name and other related API changes. All storage_name <-> vname conversions now go through the same two mailbox_list methods. This has many benefits, such as: * listescape plugin is now much simpler and bugfree * allows changing lib-storage API to use UTF-8 mailbox names in future * allows creation of "mailbox aliases&quot...

...ailbox *) 0x109f30b0 ctx = (struct imap_select_context *) 0x10a2ef50 args = (const struct imap_arg *) 0x10a316a0 list_args = (const struct imap_arg *) 0x2afabcdd9e2b status = MAILBOX_NAME_EXISTS_MAILBOX mailbox = 0x10a31790 "virtual.allsent" storage_name = 0x109f32b8 "allsent" ret = <value optimized out> __FUNCTION__ = "cmd_select_full" #5 0x000000000041036c in client_command_input (cmd=0x10a2ee48) at imap-client.c:643 client = (struct client *) 0x10a2e6e8 command = <value optimized out...

(gdb) bt full #0 mailbox_list_default_get_vname (list=0x21ceec0, storage_name=0x0) at mailbox-list.c:655 __s2_len = <optimized out> i = <optimized out> prefix_len = <optimized out> name_len = <optimized out> vname = 0x0 list_sep = <optimized out> ns_sep = <optimized out> ret...

...ent_uid = 0, highest_modseq = 0, virtual_size = 48005140525491, keywords = 0x0, cache_fields = 0x80, nonpermanent_modseqs = 0}, mailbox_guid = "{?W\021?+\000\000\200\000\000\000\000\000\000"} ns = <value optimized out> mailbox = 0xcf02d58 "virtual.rapidsolution" storage_name = 0xcebd330 "rapidsolution" error = <value optimized out> #12 0x000000000041055c in client_command_input (cmd=0xcf00410) at imap-client.c:672 client = (struct client *) 0xceffca0 command = <value optimized out> __FUNCTION__ = "client_command_input" #13 0x0000000...

Hello Timo, latest 2.0 hg version (changeset a6b050cc4a9a) segfaults when selecting a virtual mailbox. Backtrace and dovecot -n are attached. Please let me know if I can help with anything else to debug this. Regards, e-frog -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: bt.txt URL:

...7f25f9818b70) at mailbox-list-fs-iter.c:683 node = <value optimized out> flags = MAILBOX_SUBSCRIBED ns = <value optimized out> path = <value optimized out> dir = <value optimized out> fname = <value optimized out> storage_name = 0x7f25f980d410 "public" len = 0 st = {st_dev = 139801076486872, st_ino = 19, st_nlink = 139801053739543, st_mode = 128, st_uid = 0, st_gid = 1, __pad0 = 0, st_rdev = 139801046211004, st_size = 206158430224, st_blksize = 140734110281536, st_blocks = 1407341102...

...dsync_brain_mailbox_tree_sync_change (brain=0x7fe4cedbc7d0, change=0x7fe4cedd5c60) at dsync-brain-mailbox-tree-sync.c:182 box = 0x7fe4cede5cb0 destbox = <optimized out> errstr = <optimized out> func_name = 0x7fe4cd1dedf5 "mailbox_delete" storage_name = <optimized out> error = <optimized out> ret = 1 __FUNCTION__ = "dsync_brain_mailbox_tree_sync_change" #17 0x00007fe4cd1c74d2 in dsync_brain_mailbox_trees_sync (brain=<optimized out>) at dsync-brain-mailbox-tree.c:295 No locals. #18 dsync_brain_...

using latest auto build didn't help. this happens only with a specific account. # doveadm -o imapc_user=----- at domain.com -o imapc_password=---- backup -u =----- at domain.com -R imapc: dsync(---- at domain.com): Panic: pool_data_stack_realloc(): stack frame changed dsync(---- at domain.com): Error: Raw backtrace: /usr/lib/dovecot/libdovecot.so.0(+0x4209a) [0xb762b09a] ->