search for: sterror

...D: Compiling Memory.cpp In file included from /usr/home/llvm/lib/System/Memory.cpp:28: /usr/home/llvm/obj/lib/System/platform/Memory.cpp: In static member function `static void llvm::sys::Memory::ReleaseRWX(llvm::sys::Memory&)': /usr/home/llvm/obj/lib/System/platform/Memory.cpp:47: error: `sterror' undeclared (first use this function) /usr/home/llvm/obj/lib/System/platform/Memory.cpp:47: error: (Each undeclared identifier is reported only once for each function it appears in.) "sterror" should, of course, be "strerror". On Sat, 11 Sep 2004 00:13:01 -0700 Reid Spenc...

Folks, I have recently committed several lib/System changes. As with previous commits, the changes work on Linux but for other platforms I'm only "guessing" at the implementation based on available documentation. Your mileage might vary. If this breaks compilation on your platform, please correct the implementation and check it in or submit patches to me and I'll check it in.

...D shares static storage for strerror() results among all threads, in part because it computes the resulting string via catopen()/catgets()/catclose() and MUST copy the localized string somewhere because the source read via catgets() may not survive catclose(). So we really need to audit all use of sterror() in nbdkit and switch over to strerror_r(), remembering to work around the alternate glibc signature when _GNU_SOURCE is defined. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Our use of "%m" in various error messages is testament to the project's initial life on Linux - but other than Cygwin, I know of no other platforms supporting that glibc extension. We COULD audit the code and manually turn "%m" into "%s"/strerror(errno), but that's a lot of churn. Instead, let's fix the few outliers that can't be easily wrapped, then