search for: status_not_implemented

...>>>> On 07/25/2010 09:45 AM, James McKenzie wrote: >>>>> I think you missed what Nicolay and Dmitry are trying to tell you. >>>>> We are trying to implement, bug for bug, the functionality of what >>>>> Windows does. Does Windows return "STATUS_NOT_IMPLEMENTED" when this >>>>> call is made? If not, your fix is WRONG. Silencing a 'fixme' is NOT a >>>>> fix and this will be REJECTED. >>>>> If this is correct and is what Windows does, then state so. >>>>> Otherwise, >>>>&g...

...wn(); - return Manageable::STATUS_OK; + shutdown(); + return Manageable::STATUS_OK; case _qmf::Host::METHOD_REBOOT: - reboot(); - return Manageable::STATUS_OK; + reboot(); + return Manageable::STATUS_OK; } return Manageable::STATUS_NOT_IMPLEMENTED; } diff --git a/src/host.h b/src/host.h index c69a4f3..06bdbf0 100644 --- a/src/host.h +++ b/src/host.h @@ -1,4 +1,4 @@ -/* Copyright (C) 2009 Red Hat, Inc. +/* host.h - Copyright (C) 2009 Red Hat, Inc. * Written by Arjun Roy <arroy at redhat.com> * * This program is free software; you...

...p; args, string& text) +{ + switch(id) + { + case _qmf::Processors::METHOD_GET_LOAD_AVERAGE: + _qmf::ArgsProcessorsGet_load_average& loadavg = (_qmf::ArgsProcessorsGet_load_average&) args; + loadavg.o_ret = get_load_average(); + return STATUS_OK; + } + + return STATUS_NOT_IMPLEMENTED; +} + +double +ProcessorsAgent::get_load_average(void) +{ + double result; + ifstream input; + + input.open("/proc/loadavg", ios::in); + input >> result; + input.close(); + + return result; +} diff --git a/src/processors.h b/src/processors.h new file mode 100644 index 0000000....

This patch includes one small change: the Processors::get_load_average() method is now const since it does not change the object's state.

...args, string& text) -{ - switch(methodId) { - case _qmf::Host::METHOD_SHUTDOWN: - shutdown(); - return Manageable::STATUS_OK; - case _qmf::Host::METHOD_REBOOT: - reboot(); - return Manageable::STATUS_OK; - } - return Manageable::STATUS_NOT_IMPLEMENTED; + processors.update(); } diff --git a/src/host.h b/src/host.h index 148c91f..c19da3e 100644 --- a/src/host.h +++ b/src/host.h @@ -1,3 +1,6 @@ +#ifndef __HOST_H +#define __HOST_H + /* host.h - Copyright (C) 2009 Red Hat, Inc. * Written by Arjun Roy <arroy at redhat.com> * @@ -32,67 +35...

...hod - static void fillCPUInfo(vector<CPUWrapper*> &cpus, ManagementAgent *agent); - - // QMF Methods - ManagementObject* GetManagementObject(void) const { return mgmt_object; } - - status_t ManagementMethod(uint32_t methodId, Args& args, string& text) { - return STATUS_NOT_IMPLEMENTED; - } - - // Field Accessors - int getCpunum(void) { return cpunum; } - int getCorenum(void) { return corenum; } - int getNumcores(void) { return numcores; } - - int getModel(void) { return model; } - int getFamily(void) { return family; } - int getCpuid_Lvl(void) { return cp...

...& arguments, string& text) +{ + switch(method) + { + case _qmf::Host::METHOD_SHUTDOWN: + _host->shutdown(); + return Manageable::STATUS_OK; + case _qmf::Host::METHOD_REBOOT: + _host->reboot(); + return Manageable::STATUS_OK; + } + + return Manageable::STATUS_NOT_IMPLEMENTED; +} + +void +HostAgent::identify(const int iterations) +{ + // TODO +} + +void +HostAgent::subscribe_to_heartbeat(const HeartbeatListener& listener) +{ + // TODO +} + +void +HostAgent::unsubscribe_from_heartbeat(const HeartbeatListener& listener) +{ + // TODO +} + +void +HostAgent::shutd...

Refactoring the previous patch ended up creating two deltas. This patch pushes them both together into a single commit.

...h (methodId) { - case _qmf::NIC::METHOD_IDENTIFY_NIC: - _qmf::ArgsNICIdentify_nic& ioArgs = (_qmf::ArgsNICIdentify_nic&) args; - int seconds = ioArgs.i_seconds; - ioArgs.o_ret = identifyNIC(seconds); - return STATUS_OK; - } - - return STATUS_NOT_IMPLEMENTED; -} diff --git a/src/nic.h b/src/nic.h deleted file mode 100644 index e0e5874..0000000 --- a/src/nic.h +++ /dev/null @@ -1,95 +0,0 @@ -/* nic.h - Copyright (C) 2009 Red Hat, Inc. - * Written by Arjun Roy <arroy at redhat.com> - * - * This program is free software; you can redistribute it and/...

In looking at the code I realized that the last of the HAL depenencies were removed with this patch. So, I'm pushing an updated patch that contains none of the HAL code in it.