search for: stats_sg_init

...PAGE_SHIFT) >> > >> >> With these changes merged in: >> >> Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > > OK, here's an updated incremental patch: only comment > changed. OK, I've merged this with one change: +static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg) +{ + sg_init_one(sg, vb->stats, sizeof(vb->stats)); +} + ... - sg_init_one(&sg, vb->stats, sizeof(vb->stats)); + stats_sg_init(vb, &sg); This is no longer a meaningful change, so I removed it. Here's the final result: Fro...

...PAGE_SHIFT) >> > >> >> With these changes merged in: >> >> Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > > OK, here's an updated incremental patch: only comment > changed. OK, I've merged this with one change: +static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg) +{ + sg_init_one(sg, vb->stats, sizeof(vb->stats)); +} + ... - sg_init_one(&sg, vb->stats, sizeof(vb->stats)); + stats_sg_init(vb, &sg); This is no longer a meaningful change, so I removed it. Here's the final result: Fro...

...io_balloon_stat_modern stats[VIRTIO_BALLOON_S_NR]; + struct virtio_balloon_stat legacy_stats[VIRTIO_BALLOON_S_NR]; + }; /* To register callback in oom notifier call chain */ struct notifier_block nb; @@ -88,6 +91,14 @@ static struct virtio_device_id id_table[] = { { 0 }, }; +static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg) +{ + if (virtio_has_feature(vb->vdev, VIRTIO_F_VERSION_1)) + sg_init_one(sg, vb->stats, sizeof(vb->stats)); + else + sg_init_one(sg, vb->legacy_stats, sizeof(vb->legacy_stats)); +} + static u32 page_to_balloon_pfn(struct page *pag...

...io_balloon_stat_modern stats[VIRTIO_BALLOON_S_NR]; + struct virtio_balloon_stat legacy_stats[VIRTIO_BALLOON_S_NR]; + }; /* To register callback in oom notifier call chain */ struct notifier_block nb; @@ -88,6 +91,14 @@ static struct virtio_device_id id_table[] = { { 0 }, }; +static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg) +{ + if (virtio_has_feature(vb->vdev, VIRTIO_F_VERSION_1)) + sg_init_one(sg, vb->stats, sizeof(vb->stats)); + else + sg_init_one(sg, vb->legacy_stats, sizeof(vb->legacy_stats)); +} + static u32 page_to_balloon_pfn(struct page *pag...

On Tue, 14 Apr 2015 11:21:11 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > index f81b220..164e0c2 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -52,15 +52,31 @@ struct virtio_balloon_config { > #define

On Tue, 14 Apr 2015 11:21:11 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > index f81b220..164e0c2 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -52,15 +52,31 @@ struct virtio_balloon_config { > #define

...S_NR]; - struct virtio_balloon_stat legacy_stats[VIRTIO_BALLOON_S_NR]; - }; + struct virtio_balloon_stat stats[VIRTIO_BALLOON_S_NR]; /* To register callback in oom notifier call chain */ struct notifier_block nb; @@ -93,10 +90,7 @@ static struct virtio_device_id id_table[] = { static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg) { - if (virtio_has_feature(vb->vdev, VIRTIO_F_VERSION_1)) - sg_init_one(sg, vb->stats, sizeof(vb->stats)); - else - sg_init_one(sg, vb->legacy_stats, sizeof(vb->legacy_stats)); + sg_init_one(sg, vb->stats, sizeof(vb->stats))...

...S_NR]; - struct virtio_balloon_stat legacy_stats[VIRTIO_BALLOON_S_NR]; - }; + struct virtio_balloon_stat stats[VIRTIO_BALLOON_S_NR]; /* To register callback in oom notifier call chain */ struct notifier_block nb; @@ -93,10 +90,7 @@ static struct virtio_device_id id_table[] = { static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg) { - if (virtio_has_feature(vb->vdev, VIRTIO_F_VERSION_1)) - sg_init_one(sg, vb->stats, sizeof(vb->stats)); - else - sg_init_one(sg, vb->legacy_stats, sizeof(vb->legacy_stats)); + sg_init_one(sg, vb->stats, sizeof(vb->stats))...

...S_NR]; - struct virtio_balloon_stat legacy_stats[VIRTIO_BALLOON_S_NR]; - }; + struct virtio_balloon_stat stats[VIRTIO_BALLOON_S_NR]; /* To register callback in oom notifier call chain */ struct notifier_block nb; @@ -93,10 +90,7 @@ static struct virtio_device_id id_table[] = { static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg) { - if (virtio_has_feature(vb->vdev, VIRTIO_F_VERSION_1)) - sg_init_one(sg, vb->stats, sizeof(vb->stats)); - else - sg_init_one(sg, vb->legacy_stats, sizeof(vb->legacy_stats)); + sg_init_one(sg, vb->stats, sizeof(vb->stats))...

...S_NR]; - struct virtio_balloon_stat legacy_stats[VIRTIO_BALLOON_S_NR]; - }; + struct virtio_balloon_stat stats[VIRTIO_BALLOON_S_NR]; /* To register callback in oom notifier call chain */ struct notifier_block nb; @@ -93,10 +90,7 @@ static struct virtio_device_id id_table[] = { static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg) { - if (virtio_has_feature(vb->vdev, VIRTIO_F_VERSION_1)) - sg_init_one(sg, vb->stats, sizeof(vb->stats)); - else - sg_init_one(sg, vb->legacy_stats, sizeof(vb->legacy_stats)); + sg_init_one(sg, vb->stats, sizeof(vb->stats))...

On Tue, 14 Apr 2015 10:42:56 +0930 Rusty Russell <rusty at rustcorp.com.au> wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Wed, Apr 01, 2015 at 02:57:35PM +0200, Michael S. Tsirkin wrote: > >> Virtio 1.0 doesn't include a modern balloon device. At some point we'll likely > >> define an incompatible interface with a

On Tue, 14 Apr 2015 10:42:56 +0930 Rusty Russell <rusty at rustcorp.com.au> wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Wed, Apr 01, 2015 at 02:57:35PM +0200, Michael S. Tsirkin wrote: > >> Virtio 1.0 doesn't include a modern balloon device. At some point we'll likely > >> define an incompatible interface with a