search for: stationport

...@ -336,6 +336,9 @@ void core_udp_sendto(struct pxe_pvt_inode *socket, >>>> const void *data, >>>> >>>> memset(&udata, 0, sizeof(udata)); >>>> >>>> + /* Re-use the existing local port number if any */ >>>> + udata.StationPort = socket->net.efi.localport; >>>> + >>> >>> As HPA noted, this shouldn't be saved here. Commit 7ec052b on my >>> branch efi-fixes (will be renamed to efi-fixes-for-mfleming once Jason >>> gives more feedback). >> >> To clarify, thi...

...;> --- a/efi/udp.c >> +++ b/efi/udp.c >> @@ -336,6 +336,9 @@ void core_udp_sendto(struct pxe_pvt_inode *socket, const void *data, >> >> memset(&udata, 0, sizeof(udata)); >> >> + /* Re-use the existing local port number if any */ >> + udata.StationPort = socket->net.efi.localport; >> + > > As HPA noted, this shouldn't be saved here. Commit 7ec052b on my > branch efi-fixes (will be renamed to efi-fixes-for-mfleming once Jason > gives more feedback). To clarify, this code-quote reuses (needed) while the removed one saves...

...get a different (non-working) behavior. syslinux.efi is correctly downloaded and my tftp server receive requests for ldlinux.e64 and acknowledge options, but receive no response at all. Actually, what happen is that before any packet is actually sent (and Transmit is called), GetModeData return a StationPort = 0. Leading to received packets being discarded by the firmware because of the non-matching port and the absence of AcceptAnyPort flag. Local port, thus, can't be saved before the first call to core_udp_send or core_udp_sendto. Two possible solutions I see: 1) Handle the local port "by h...

...diff --git a/efi/udp.c b/efi/udp.c index 59bb426..7271f1f 100644 --- a/efi/udp.c +++ b/efi/udp.c @@ -336,6 +336,9 @@ void core_udp_sendto(struct pxe_pvt_inode *socket, const void *data, memset(&udata, 0, sizeof(udata)); + /* Re-use the existing local port number if any */ + udata.StationPort = socket->net.efi.localport; + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); @@ -373,6 +376,21 @@ void core_udp_sendto(str...

...udp.c syslinux-master/efi/udp.c --- orig_repo/syslinux-master/efi/udp.c 2015-06-09 02:50:15.000000000 -0700 +++ syslinux-master/efi/udp.c 2015-06-02 05:54:11.000000000 -0700 @@ -150,11 +150,15 @@ void core_udp_connect(struct pxe_pvt_ino /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport; - udata.UseDefaultAddress = TRUE; + udata.UseDefaultAddress = FALSE; memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); udata.RemotePort = port; udata.AcceptPromiscuous = TRUE; udata.TimeToLive = 64; + ip = IPInfo.myip; + memcpy(...

...igure() unsuccessful (%d)\n", f, status); if (!efi_net_def_addr && (status == EFI_INVALID_PARAMETER)) efi_net_def_addr = 2; } @@ -158,6 +158,7 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport; +retry: if (efi_net_def_addr) { udata.UseDefaultAddress = TRUE; } else { @@ -170,6 +171,11 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, udata.TimeToLive = 64; status = core_udp_configure(udp, &udata, L"core_ud...

...t Stappers" <stappers at stappers.nl> wrote: > > Op 2013-11-30 om 13:12 schreef Gene Cumm: > <bigsnip/> > > > > Is there any chance you two could try my branch efi-fixes (commit > > d04b0edf) as I believe this solves the issues of the changing > > StationPort and routing difficulties of both a single subnet and > > multiple subnets? > > What is the URL of the git repository? > > > Groeten > Geert Stappers > who was triggered on "my branch" Sorry about that. The same as usual and mentioned earlier this week. git:/...

...orig_repo/syslinux-master/efi/udp.c 2015-06-09 02:50:15.000000000 > -0700 > +++ syslinux-master/efi/udp.c 2015-06-02 05:54:11.000000000 -0700 > @@ -150,11 +150,15 @@ void core_udp_connect(struct pxe_pvt_ino > /* Re-use the existing local port number */ > udata.StationPort = socket->net.efi.localport; > > - udata.UseDefaultAddress = TRUE; > + udata.UseDefaultAddress = FALSE; > memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > udata.RemotePort = port; > udata.AcceptPromiscuous = TRUE; > udata.TimeToLive = 64; &g...

Op 2013-11-08 om 10:48 schreef H. Peter Anvin: > Thank you for posting the pcap files, by the way. Analyzing them in > Wireshark is so much nicer than reading the text output of tcpdump. Fetch the new capture with wget -O pcap2.zip http://ge.tt/api/1/files/136167y/0/blob?downlad The capture[1] shows two[2] TFTP transmissions of sles113/syslinux.efi, but nothing after that. As if

...inux.git > > > > Branch 1efipxe > > > > _ Silly question: is it clear to everyone / anyone how exactly would > that manual configuration would be achieved? Partial diff between the 1efipxe branch and master /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport; - udata.UseDefaultAddress = TRUE; + if (efi_net_def_addr) { + udata.UseDefaultAddress = TRUE; + } else { + udata.UseDefaultAddress = FALSE; + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); + memcpy(&ud...

...the local port + * number as the TID. + */ + status = uefi_call_wrapper(udp->GetModeData, 5, udp, + &udata, NULL, NULL, NULL); + if (status != EFI_SUCCESS) + Print(L"Failed to get UDP mode data: %d\n", status); + else + socket->net.efi.localport = udata.StationPort; + return 0; bail: @@ -89,7 +100,6 @@ void core_udp_close(struct pxe_pvt_inode *socket) void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, uint16_t port) { - EFI_UDP4_CONFIG_DATA udata; EFI_STATUS status; EFI_UDP4 *udp; @@ -113,20 +123,6 @@ void core_...

I did change both instances of txdata->GatewayAddress, but I think something may be wrong in my toolchain. If I extract syslinux.zip and attempt to make from there (without modifying any files), the cached DHCP packet isn't read on the same subnet. I receive "Succeed to download NBP file." twice before anything from syslinux is loaded, so I believe the duplicate request for

...the local port - * number as the TID. - */ - status = uefi_call_wrapper(udp->GetModeData, 5, udp, - &udata, NULL, NULL, NULL); - if (status != EFI_SUCCESS) - Print(L"Failed to get UDP mode data: %d\n", status); - else - socket->net.efi.localport = udata.StationPort; + + b = efi_create_binding(&Udp4ServiceBindingProtocol, &Udp4Protocol); + if(!b) + return -1; + + udp_io=zalloc(sizeof(UDP_IO)); + if(!udp_io) + goto bail; + + udp_io->b = b; + + udp = (EFI_UDP4 *)b->this; + udp_io->Protocol_Udp4 = udp; + + socket->net.efi.context =...

...truct pxe_pvt_ino EFI_UDP4_CONFIG_DATA udata; EFI_STATUS status; EFI_UDP4 *udp; + uint32_t tip; udp = (EFI_UDP4 *)socket->net.efi.binding->this; @@ -150,7 +151,30 @@ void core_udp_connect(struct pxe_pvt_ino /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport; - udata.UseDefaultAddress = TRUE; + /** + * Determine if this is remote or local subnet to set + * UseDefaultAddress. If ip (TFTP/MTFTP server or + * RemoteAddress) is on same subnet as client, + * which is stored in IPInfo.myip, this is loc...

Signed-off-by: Julien Viard de Galbert <jviarddegalbert at online.net> --- efi/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efi/udp.c b/efi/udp.c index 1088f47..b0f13ad 100644 --- a/efi/udp.c +++ b/efi/udp.c @@ -163,7 +163,7 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, } else { udata.UseDefaultAddress = FALSE;

...ndex 59bb426..7271f1f 100644 > --- a/efi/udp.c > +++ b/efi/udp.c > @@ -336,6 +336,9 @@ void core_udp_sendto(struct pxe_pvt_inode *socket, const void *data, > > memset(&udata, 0, sizeof(udata)); > > + /* Re-use the existing local port number if any */ > + udata.StationPort = socket->net.efi.localport; > + As HPA noted, this shouldn't be saved here. Commit 7ec052b on my branch efi-fixes (will be renamed to efi-fixes-for-mfleming once Jason gives more feedback). -- -Gene

...efi/udp.c >>> @@ -336,6 +336,9 @@ void core_udp_sendto(struct pxe_pvt_inode *socket, >>> const void *data, >>> >>> memset(&udata, 0, sizeof(udata)); >>> >>> + /* Re-use the existing local port number if any */ >>> + udata.StationPort = socket->net.efi.localport; >>> + >> >> As HPA noted, this shouldn't be saved here. Commit 7ec052b on my >> branch efi-fixes (will be renamed to efi-fixes-for-mfleming once Jason >> gives more feedback). > > To clarify, this code-quote reuses (needed)...

Op 2013-11-30 om 13:12 schreef Gene Cumm: <bigsnip/> > > Is there any chance you two could try my branch efi-fixes (commit > d04b0edf) as I believe this solves the issues of the changing > StationPort and routing difficulties of both a single subnet and > multiple subnets? What is the URL of the git repository? Groeten Geert Stappers who was triggered on "my branch"

...1efipxe >> > >> >> _ Silly question: is it clear to everyone / anyone how exactly would >> that manual configuration would be achieved? > > Partial diff between the 1efipxe branch and master > > /* Re-use the existing local port number */ > udata.StationPort = socket->net.efi.localport; > > - udata.UseDefaultAddress = TRUE; > + if (efi_net_def_addr) { > + udata.UseDefaultAddress = TRUE; > + } else { > + udata.UseDefaultAddress = FALSE; > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPIn...

The variable 'ok' is never used and generates a warning. Remove it. Also ntfssect.c is designed to be compiled in non Unicode mode when using MSVC compilers, so remove all ambiguity about it (LPCTSTR -> LPCSTR, use of 'A' API calls) so that it doesn't break when compiled in Unicode mode, which is what Rufus uses with MSVC. -------------- next part --------------