search for: stationaddress

...g/archives/2015-October/024341.html > This report has led to Gene's patch: > > https://github.com/geneC/syslinux/commit/9e0926bb338deb5c634ccb4ee29eb4577158cfdc > it was reported working but I think "it cannot work" if it has these lines > > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); > + memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); > > the StationAddress gets overwritten by a netmask... Thanks for noticing. I've corrected this and I'm reviewing the patch itself. -- -Gene

...1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efi/udp.c b/efi/udp.c index 1088f47..b0f13ad 100644 --- a/efi/udp.c +++ b/efi/udp.c @@ -163,7 +163,7 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, } else { udata.UseDefaultAddress = FALSE; memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); - memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); + memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); } memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); udata.RemotePort = port; -...

...to the packet except that it contains NULL server ip so populate server from ProxyOffer packet. The information is loaded into pkt_v4 and then parsed. In efi/udp.c: Both updates are in core_udp_connect and core_udp_sendto functions. 1. Disable UseDefaultAddress, which is not complete. 2. Set StationAddress and SubnetMask to correct values from IPInfo struct because both fields are not necessarily populated. Signed-off-by: Jeff Sloan <jeff_sloan at selinc.com> --- diffstat results: pxe.c | 16 +++++++++++++++- udp.c | 12 ++++++++++-- 2 files changed, 25 insertions(+), 3 deletions(-) Com...

...aster /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport; - udata.UseDefaultAddress = TRUE; + if (efi_net_def_addr) { + udata.UseDefaultAddress = TRUE; + } else { + udata.UseDefaultAddress = FALSE; + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); + memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); + } memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); udata.RemotePort = port; udata.TimeToLive = 64; So don't worry about "manual"...

On Sat, Nov 9, 2013 at 9:22 AM, Jason Matthews <jason.david.matthews at gmail.com> wrote: > The setup I was using was in a chassis. Slot 8 of the chassis is the client > machine. It goes through Switch 1 (a Brocade switch) to the top of rack > (BNT). The mirror is in the chassis switch. Slot 3 of the same chassis is > connected to the mirror port in Switch 1. > > client =

from: Jeff Sloan <jeff_sloan at selinc.com> Based on commit: 9314e330 Setting UseDefaultAddress to TRUE uses invalid StationAddress and SubnetMask values. This is in a network with a local TFTP/MTFTP server. If the server is local, on the same subnet, UseDefaultAddress is set to false and the client ip and subnetmask are loaded, otherwise set UseDefaultAddress to TRUE. This is added to core_udp_connect and core_udp_sendto....

...formation is loaded into pkt_v4 and then parsed. > > In efi/udp.c: Both updates are in core_udp_connect and core_udp_sendto > functions. > > 1. Disable UseDefaultAddress, which is not complete. Were you able to do a packet capture? Why is it incomplete on your systems? > 2. Set StationAddress and SubnetMask to correct values from IPInfo struct > because both fields are not necessarily populated. > > Signed-off-by: Jeff Sloan <jeff_sloan at selinc.com> > --- > diffstat results: > pxe.c | 16 +++++++++++++++- > udp.c | 12 ++++++++++-- > 2 files changed,...

...out > and bail to repeat the same process until reset. > > Thanks for pointing out the UEFI_Spec_2_3_1.pdf. It help me get a little > more grasp on what's happening. I set it to use the Default Address. If you > set UseDefaultAddress to true and comment out the lines setting > StationAddress and SubnetMask, it takes a second to pull the dhcp info so I > had to put the udp->Configure line in a loop until it's status is not > EFI_NO_MAPPING. Once it's set, It looks like it takes the StationAddress, > SubnetMask and Gateway from the dhcp. Excellent info! I can put an...

...hit the jiffies() loop, time out and bail to repeat the same process until reset. Thanks for pointing out the UEFI_Spec_2_3_1.pdf. It help me get a little more grasp on what's happening. I set it to use the Default Address. If you set UseDefaultAddress to true and comment out the lines setting StationAddress and SubnetMask, it takes a second to pull the dhcp info so I had to put the udp->Configure line in a loop until it's status is not EFI_NO_MAPPING. Once it's set, It looks like it takes the StationAddress, SubnetMask and Gateway from the dhcp.

...al port number */ > udata.StationPort = socket->net.efi.localport; > > - udata.UseDefaultAddress = TRUE; > + if (efi_net_def_addr) { > + udata.UseDefaultAddress = TRUE; > + } else { > + udata.UseDefaultAddress = FALSE; > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); > + memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); > + } > memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > udata.RemotePort = port; > udata.TimeToLive = 64; > > So don'...

...I couldn't find anything wrong there; When you get a minute please assemble the rest of info; so far it's not clear what the symptoms really are. <<< The IP4 config data struct contents from core_udp_open is included below. When UseDefaultAddress is TRUE, it passes 0.0.0.0 for StationAddress and NetMask. core_udp_open calls core_udp_configure which calls efiip4configure (BIOS). BIOS validates SA and NM but special-cases both null to allow for proxy. BIOS tries to find the GUID to configure but fails and returns EFI_UNSUPPORTED error, EFIERR(3). Then core_udp_sendto attempts to sen...

The variable 'ok' is never used and generates a warning. Remove it. Also ntfssect.c is designed to be compiled in non Unicode mode when using MSVC compilers, so remove all ambiguity about it (LPCTSTR -> LPCSTR, use of 'A' API calls) so that it doesn't break when compiled in Unicode mode, which is what Rufus uses with MSVC. -------------- next part --------------

...x.e32" http://www.syslinux.org/archives/2015-October/024341.html This report has led to Gene's patch: https://github.com/geneC/syslinux/commit/9e0926bb338deb5c634ccb4ee29eb4577158cfdc it was reported working but I think "it cannot work" if it has these lines + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); + memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); the StationAddress gets overwritten by a netmask... There's a picture attached comparing performance between the old and new udp.c code. Testing reports are welcome....

...e same process until reset. > > > > Thanks for pointing out the UEFI_Spec_2_3_1.pdf. It help me get a little > > more grasp on what's happening. I set it to use the Default Address. If > you > > set UseDefaultAddress to true and comment out the lines setting > > StationAddress and SubnetMask, it takes a second to pull the dhcp info > so I > > had to put the udp->Configure line in a loop until it's status is not > > EFI_NO_MAPPING. Once it's set, It looks like it takes the StationAddress, > > SubnetMask and Gateway from the dhcp. > >...

...> + * > + * @param:socket, the open socket > + * @param:ip, the ip address > + * @param:port, the port number, host-byte order > + */ > +void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, > + uint16_t port) > +{ > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); > + memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); > + memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > + udata.RemotePort = port; > + udata.AcceptPromiscuous = TRUE; > + Looking at UEFI Spec v...

I have a patch that I think may help your situation of syslinux.efi being unable to load ldlinux.e64/ldlinux.e32 (though I don't know if any of you are using an EFI ia32 platform). The basics are that we try to enable UseDefaultAddress as it helps certain clients with routing and works on numerous other clients. If we timeout on receiving a packet and have never received any packets, disable

...se a port, or > to chose a port "by hand" in core_udp_open. > This patch I propose implements the first solution. Celelibi, Jason: Please see also my request at the bottom. As far as our TFTP traffic from a programming perspective, we need to get a fixed StationPort, regardless of StationAddress or any routing rules, send a packet to 1 RemotePort, receive a packet from another RemotePort then begin a dialog with the second RemotePort and not see other traffic. Would you agree? Outside UEFI, an open() call would typically assign a port to the calling program. When no port is specified, i...

>>> Setting UseDefaultAddress to TRUE uses invalid StationAddress and SubnetMask values. This is in a network with a local TFTP/MTFTP server. If the server is local, on the same subnet, UseDefaultAddress is set to false and the client ip and subnetmask are loaded, otherwise set UseDefaultAddress to TRUE. This is added to core_udp_connect and core_udp_sendto....

...t mirror? Looks like I should try to improve the instructions at http://www.syslinux.org/wiki/index.php/Debugging#PXE-Capture-Mirror to provide examples for Cisco and HP and an inline example with Linux bridging. Reading back, you stated "Strange thing is that the struct shows 0xc78cef71 for StationAddress and 0xc78cef75 for subnetmask when usedefaultaddress is set to true. Since my subnet is 10.39.31.xx, I am completely baffled as to how the default values were set but I will figure it out. I just need to do some additional digging." Did you obtain this based on extra Print() statements? The...

...en socket > > + * @param:ip, the ip address > > + * @param:port, the port number, host-byte order > > + */ > > +void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, > > + uint16_t port) > > +{ > > > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); > > + memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); > > + memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > > + udata.RemotePort = port; > > + udata.AcceptPromiscuous = TRUE; > >...