search for: statetransit

...gt;>> +void State::AddInsnClass(unsigned InsnClass, >>>>>>> Add a top level comment describing the function >>>>>>> >>>>>>> + std::map<State*, std::set<Transition*, ltTransition>, ltState> >>>>>>> stateTransitions; >>>>>>> You should be able to use SmallSet here. Also, this line exceeds 80 >>>>>>> columns. >>>>>> I tried but SmallSet is not iterable. SmallSetPtr could be useful >>>>>> here but it doesn't allow custom sortin...

...t; >>>>>> +void State::AddInsnClass(unsigned InsnClass, >>>>>> Add a top level comment describing the function >>>>>> >>>>>> + std::map<State*, std::set<Transition*, ltTransition>, ltState> >>>>>> stateTransitions; >>>>>> You should be able to use SmallSet here. Also, this line exceeds 80 >>>>>> columns. >>>>> I tried but SmallSet is not iterable. SmallSetPtr could be useful >>>>> here but it doesn't allow custom sorting. >>>&...

...: >>>>> >>>>> +void State::AddInsnClass(unsigned InsnClass, >>>>> Add a top level comment describing the function >>>>> >>>>> + std::map<State*, std::set<Transition*, ltTransition>, ltState> >>>>> stateTransitions; >>>>> You should be able to use SmallSet here. Also, this line exceeds 80 >>>>> columns. >>>> I tried but SmallSet is not iterable. SmallSetPtr could be useful >>>> here but it doesn't allow custom sorting. >>>> >>>...

...ore resources we introduce in the td file the larger it will be. Given an architecture with n resources, LargestInput will take the maximum value, i.e. 2^(n-1), but valid inputs are just a small subset of [0, LargestInput]. But then please remove the > Transition mechanism for the DFA class (stateTransitions). Done! > > For transitions being folded into State: > > std::map<unsigned, Transition *> inputToTrans; > > We don't need a map to Transition* here; we can directly map from input > to stateNum. You should be able to use a LLVM data structure. In that case, (1...

...DFA and another addTransition() for State that populate different data structures. We shouldn't need both. I am okay with transitions being folded into the State class if it results in significant speedup in DFA generation. But then please remove the Transition mechanism for the DFA class (stateTransitions). For transitions being folded into State: > std::map<unsigned, Transition *> inputToTrans; We don't need a map to Transition* here; we can directly map from input to stateNum. You should be able to use a LLVM data structure. -Anshu

...ta wrote: > Hi Ivan, > > The patch looks good to me. I have a couple of minor comments: > > +void State::AddInsnClass(unsigned InsnClass, > Add a top level comment describing the function > > + std::map<State*, std::set<Transition*, ltTransition>, ltState> > stateTransitions; > You should be able to use SmallSet here. Also, this line exceeds 80 > columns. I tried but SmallSet is not iterable. SmallSetPtr could be useful here but it doesn't allow custom sorting. > > > On a related note, is the CachedTable mechanism in DFAPacketizer.h > use...

Hi Ivan, The patch looks good to me. I have a couple of minor comments: +void State::AddInsnClass(unsigned InsnClass, Add a top level comment describing the function + std::map<State*, std::set<Transition*, ltTransition>, ltState> stateTransitions; You should be able to use SmallSet here. Also, this line exceeds 80 columns. On a related note, is the CachedTable mechanism in DFAPacketizer.h useful for your architecture? Currently the DFA generator generates one table for a given architecture. I had originally added the CachedTable me...

...s good to me. I have a couple of minor comments: >>> >>> +void State::AddInsnClass(unsigned InsnClass, >>> Add a top level comment describing the function >>> >>> + std::map<State*, std::set<Transition*, ltTransition>, ltState> >>> stateTransitions; >>> You should be able to use SmallSet here. Also, this line exceeds 80 >>> columns. >> >> I tried but SmallSet is not iterable. SmallSetPtr could be useful >> here but it doesn't allow custom sorting. >> >>> >>> >>> On...

...n the > td file the larger it will be. Given an architecture with n resources, > LargestInput will take the maximum value, i.e. 2^(n-1), but valid > inputs are just a small subset of [0, LargestInput]. > > But then please remove the >> Transition mechanism for the DFA class (stateTransitions). > > Done! > >> >> For transitions being folded into State: >> > std::map<unsigned, Transition *> inputToTrans; >> >> We don't need a map to Transition* here; we can directly map from input >> to stateNum. You should be able to use a L...

...e the larger it will be. Given an architecture with n resources, >> LargestInput will take the maximum value, i.e. 2^(n-1), but valid >> inputs are just a small subset of [0, LargestInput]. >> >> But then please remove the >>> Transition mechanism for the DFA class (stateTransitions). >> >> Done! >> >>> >>> For transitions being folded into State: >>> > std::map<unsigned, Transition *> inputToTrans; >>> >>> We don't need a map to Transition* here; we can directly map from input >>> to sta...

...>> The patch looks good to me. I have a couple of minor comments: >> >> +void State::AddInsnClass(unsigned InsnClass, >> Add a top level comment describing the function >> >> + std::map<State*, std::set<Transition*, ltTransition>, ltState> >> stateTransitions; >> You should be able to use SmallSet here. Also, this line exceeds 80 >> columns. > > I tried but SmallSet is not iterable. SmallSetPtr could be useful here > but it doesn't allow custom sorting. > >> >> >> On a related note, is the CachedTable...

...couple of minor comments: >>>> >>>> +void State::AddInsnClass(unsigned InsnClass, >>>> Add a top level comment describing the function >>>> >>>> + std::map<State*, std::set<Transition*, ltTransition>, ltState> >>>> stateTransitions; >>>> You should be able to use SmallSet here. Also, this line exceeds 80 >>>> columns. >>> >>> I tried but SmallSet is not iterable. SmallSetPtr could be useful >>> here but it doesn't allow custom sorting. >>> >>>> &g...

Hi, I've refactored the DFA generator in TableGen because it takes too much time to build the table of our BE and I'd like to share it. We have 15 functional units and 13 different itineraries which, in the worst case, can produce 13! states. Fortunately, many of those states are reused :-) but it still takes up to 11min to build the entire table. This patch reduces the build time to