search for: state_trackers

...modified to set it causing it to pass uninitialized memory for it to launch_grid. This commit fixes this by zero-ing the entire pipe_grid_info struct when declaring it, to avoid similar problems popping-up in the future. Signed-off-by: Hans de Goede <hdegoede at redhat.com> --- src/gallium/state_trackers/clover/core/kernel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index 8396be9..dad66aa 100644 --- a/src/gallium/state_trackers/clover/core/kernel.cpp +++ b/src/gallium/st...

If we capture transform feedback from n stream in (n-1) buffers we face a NULL buffer, use the buffer (n-1) to capture the output of stream n. This fixes one piglit test with nvc0: arb_gpu_shader5-xfb-streams-without-invocations Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de> --- src/mesa/state_tracker/st_cb_xformfb.c | 5 +++++ 1 file changed, 5 insertions(+)

...it to launch_grid. >> >> This commit fixes this by zero-ing the entire pipe_grid_info struct when >> declaring it, to avoid similar problems popping-up in the future. >> >> Signed-off-by: Hans de Goede <hdegoede at redhat.com> >> --- >> src/gallium/state_trackers/clover/core/kernel.cpp | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp >> index 8396be9..dad66aa 100644 >> --- a/src/gallium/state_tracker...

...l Herbst <karolherbst at gmail.com> --- src/gallium/auxiliary/tgsi/tgsi_build.c | 3 +++ src/gallium/auxiliary/tgsi/tgsi_ureg.c | 14 +++++++--- src/gallium/auxiliary/tgsi/tgsi_ureg.h | 20 +++++++++++--- src/gallium/auxiliary/util/u_simple_shaders.c | 2 +- src/gallium/state_trackers/nine/nine_shader.c | 6 ++--- src/mesa/state_tracker/st_atifs_to_tgsi.c | 38 +++++++++++++-------------- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 ++++----- src/mesa/state_tracker/st_mesa_to_tgsi.c | 8 +++--- src/mesa/state_tracker/st_pbo.c | 2 +- 9 files chan...

...uxiliary/util/u_simple_shaders.c | 2 +- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 + .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 16 ++++ .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 +- src/gallium/include/pipe/p_shader_tokens.h | 3 +- src/gallium/state_trackers/nine/nine_shader.c | 6 +- src/mesa/state_tracker/st_atifs_to_tgsi.c | 38 ++++----- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 92 +++++++++++++++++----- src/mesa/state_tracker/st_mesa_to_tgsi.c | 8 +- src/mesa/state_tracker/st_pbo.c | 2 +-...

...the future. Cc: "11.2" <mesa-stable at lists.freedesktop.org> Signed-off-by: Hans de Goede <hdegoede at redhat.com> --- Changes in v2: -Drop trailing "," from struct initializer -Add Cc: "11.2" <mesa-stable at lists.freedesktop.org> --- src/gallium/state_trackers/clover/core/kernel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index 8396be9..1ab87ec 100644 --- a/src/gallium/state_trackers/clover/core/kernel.cpp +++ b/src/gallium/st...

...the future. Cc: "11.2" <mesa-stable at lists.freedesktop.org> Signed-off-by: Hans de Goede <hdegoede at redhat.com> --- Changes in v2: -Drop trailing "," from struct initializer -Add Cc: "11.2" <mesa-stable at lists.freedesktop.org> --- src/gallium/state_trackers/clover/core/kernel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index 8396be9..1ab87ec 100644 --- a/src/gallium/state_trackers/clover/core/kernel.cpp +++ b/src/gallium/st...

...his by zero-ing the entire pipe_grid_info struct >>>> when >>>> declaring it, to avoid similar problems popping-up in the future. >>>> >>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com> >>>> --- >>>> src/gallium/state_trackers/clover/core/kernel.cpp | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp >>>> b/src/gallium/state_trackers/clover/core/kernel.cpp >>>> index 8396be9..dad66a...

If a transform feedback buffer's size is 0, st_bufferobj_data doesn't end up creating a buffer for it. There's no point in trying to write to such a buffer, so just pretend as if it's not really there. This fixes arb_gpu_shader5-xfb-streams-without-invocations on nvc0. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/mesa/state_tracker/st_cb_xformfb.c | 2 +- 1

On 11.01.2015 06:05, Ilia Mirkin wrote: > Can you elaborate a bit as to why that's the right thing to do? > > On Wed, Jan 7, 2015 at 1:52 PM, Tobias Klausmann > <tobias.johannes.klausmann at mni.thm.de> wrote: >> If we capture transform feedback from n stream in (n-1) buffers we face a >> NULL buffer, use the buffer (n-1) to capture the output of stream n.

...> src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 + >> .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 16 ++++ >> .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 +- >> src/gallium/include/pipe/p_shader_tokens.h | 3 +- >> src/gallium/state_trackers/nine/nine_shader.c | 6 +- >> src/mesa/state_tracker/st_atifs_to_tgsi.c | 38 ++++----- >> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 92 >> +++++++++++++++++----- >> src/mesa/state_tracker/st_mesa_to_tgsi.c | 8 +- >> src/mesa/s...

On 12.01.2015 01:57, Ilia Mirkin wrote: > On Sun, Jan 11, 2015 at 7:43 PM, Tobias Klausmann > <tobias.johannes.klausmann at mni.thm.de> wrote: >> >> On 11.01.2015 06:05, Ilia Mirkin wrote: >>> Can you elaborate a bit as to why that's the right thing to do? >>> >>> On Wed, Jan 7, 2015 at 1:52 PM, Tobias Klausmann >>>

...ass uninitialized memory for it to launch_grid. > > This commit fixes this by zero-ing the entire pipe_grid_info struct when > declaring it, to avoid similar problems popping-up in the future. > > Signed-off-by: Hans de Goede <hdegoede at redhat.com> > --- > src/gallium/state_trackers/clover/core/kernel.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp > index 8396be9..dad66aa 100644 > --- a/src/gallium/state_trackers/clover/core/kernel...

...> >>> This commit fixes this by zero-ing the entire pipe_grid_info struct when >>> declaring it, to avoid similar problems popping-up in the future. >>> >>> Signed-off-by: Hans de Goede <hdegoede at redhat.com> >>> --- >>> src/gallium/state_trackers/clover/core/kernel.cpp | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp >>> b/src/gallium/state_trackers/clover/core/kernel.cpp >>> index 8396be9..dad66aa 100644 >>&gt...

....c | 2 +- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 + > .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 16 ++++ > .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 +- > src/gallium/include/pipe/p_shader_tokens.h | 3 +- > src/gallium/state_trackers/nine/nine_shader.c | 6 +- > src/mesa/state_tracker/st_atifs_to_tgsi.c | 38 ++++----- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 92 +++++++++++++++++----- > src/mesa/state_tracker/st_mesa_to_tgsi.c | 8 +- > src/mesa/state_tracker/st_pbo.c...

--- src/gallium/drivers/nv40/nv40_fragprog.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/nv40/nv40_fragprog.c b/src/gallium/drivers/nv40/nv40_fragprog.c index 1237066..209d211 100644 --- a/src/gallium/drivers/nv40/nv40_fragprog.c +++ b/src/gallium/drivers/nv40/nv40_fragprog.c @@ -843,7 +843,8 @@ nv40_fragprog_translate(struct nv40_context *nv40,

Can you elaborate a bit as to why that's the right thing to do? On Wed, Jan 7, 2015 at 1:52 PM, Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de> wrote: > If we capture transform feedback from n stream in (n-1) buffers we face a > NULL buffer, use the buffer (n-1) to capture the output of stream n. > > This fixes one piglit test with nvc0: >

...re pipe_grid_info struct >>>>> when >>>>> declaring it, to avoid similar problems popping-up in the future. >>>>> >>>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com> >>>>> --- >>>>> src/gallium/state_trackers/clover/core/kernel.cpp | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp >>>>> b/src/gallium/state_trackers/clover/core/kernel.cpp >>>>> i...

...um/drivers/nouveau/codegen/nv50_ir.h | 1 + >>> .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 16 ++++ >>> .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 +- >>> src/gallium/include/pipe/p_shader_tokens.h | 3 +- >>> src/gallium/state_trackers/nine/nine_shader.c | 6 +- >>> src/mesa/state_tracker/st_atifs_to_tgsi.c | 38 ++++----- >>> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 92 >>> +++++++++++++++++----- >>> src/mesa/state_tracker/st_mesa_to_tgsi.c | 8 +- >&...

On Sun, Jan 11, 2015 at 7:43 PM, Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de> wrote: > > > On 11.01.2015 06:05, Ilia Mirkin wrote: >> >> Can you elaborate a bit as to why that's the right thing to do? >> >> On Wed, Jan 7, 2015 at 1:52 PM, Tobias Klausmann >> <tobias.johannes.klausmann at mni.thm.de> wrote: >>>